diff options
author | Ulf Hermann <ulf.hermann@qt.io> | 2024-04-11 15:43:50 +0200 |
---|---|---|
committer | Ulf Hermann <ulf.hermann@qt.io> | 2024-04-13 07:42:34 +0200 |
commit | f59bac55c89733bc9db3a6f715c294bfb499e823 (patch) | |
tree | 47f0828280dbfbd4c8d038e35770597755c505d3 /tests | |
parent | b31bfde4bd840a94cdd4b2223e8f7c345850bd66 (diff) |
qmltyperegistrar: Improve readability and performance
Instead of working on opaque Cbor objects, we can use structs and
classes with named members. This also improves performance as we don't
have to repeatedly query the Cbor data structures.
Task-number: QTBUG-101143
Change-Id: Ifd889323f0fd723a735be3e7d70230e61039b301
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Diffstat (limited to 'tests')
-rw-r--r-- | tests/auto/qml/qmltyperegistrar/tst_qmltyperegistrar.cpp | 12 | ||||
-rw-r--r-- | tests/auto/qml/qmltyperegistrar/tst_qmltyperegistrar.h | 12 |
2 files changed, 12 insertions, 12 deletions
diff --git a/tests/auto/qml/qmltyperegistrar/tst_qmltyperegistrar.cpp b/tests/auto/qml/qmltyperegistrar/tst_qmltyperegistrar.cpp index 47b58889ac..24ba0da26d 100644 --- a/tests/auto/qml/qmltyperegistrar/tst_qmltyperegistrar.cpp +++ b/tests/auto/qml/qmltyperegistrar/tst_qmltyperegistrar.cpp @@ -116,8 +116,8 @@ void tst_qmltyperegistrar::pastMajorVersions() void tst_qmltyperegistrar::implementsInterfaces() { - QVERIFY(qmltypesData.contains("interfaces: [\"Interface\"]")); - QVERIFY(qmltypesData.contains("interfaces: [\"Interface\", \"Interface2\"]")); + QVERIFY(qmltypesData.contains("interfaces: [\"Interface1\"]")); + QVERIFY(qmltypesData.contains("interfaces: [\"Interface1\", \"Interface2\"]")); } void tst_qmltyperegistrar::namespacedElement() @@ -404,8 +404,8 @@ void tst_qmltyperegistrar::duplicateExportWarnings() MetaTypesJsonProcessor processor(true); QVERIFY(processor.processTypes({ ":/duplicatedExports.json" })); processor.postProcessTypes(); - QVector<QCborMap> types = processor.types(); - QVector<QCborMap> typesforeign = processor.foreignTypes(); + QVector<MetaType> types = processor.types(); + QVector<MetaType> typesforeign = processor.foreignTypes(); r.setTypes(types, typesforeign); const auto expectWarning = [](const char *message) { @@ -449,8 +449,8 @@ void tst_qmltyperegistrar::consistencyWarnings() processor.postProcessForeignTypes(); - QVector<QCborMap> types = processor.types(); - QVector<QCborMap> typesforeign = processor.foreignTypes(); + QVector<MetaType> types = processor.types(); + QVector<MetaType> typesforeign = processor.foreignTypes(); r.setTypes(types, typesforeign); QString outputData; diff --git a/tests/auto/qml/qmltyperegistrar/tst_qmltyperegistrar.h b/tests/auto/qml/qmltyperegistrar/tst_qmltyperegistrar.h index c4f8ec4440..5ebb9b6796 100644 --- a/tests/auto/qml/qmltyperegistrar/tst_qmltyperegistrar.h +++ b/tests/auto/qml/qmltyperegistrar/tst_qmltyperegistrar.h @@ -22,28 +22,28 @@ #include <QtCore/qtemporaryfile.h> #include <QtCore/qtimeline.h> -class Interface {}; +class Interface1 {}; class Interface2 {}; class Interface3 {}; QT_BEGIN_NAMESPACE -Q_DECLARE_INTERFACE(Interface, "io.qt.bugreports.Interface"); +Q_DECLARE_INTERFACE(Interface1, "io.qt.bugreports.Interface1"); Q_DECLARE_INTERFACE(Interface2, "io.qt.bugreports.Interface2"); Q_DECLARE_INTERFACE(Interface3, "io.qt.bugreports.Interface3"); QT_END_NAMESPACE -class ImplementsInterfaces : public QObject, public Interface +class ImplementsInterfaces : public QObject, public Interface1 { Q_OBJECT QML_ELEMENT - QML_IMPLEMENTS_INTERFACES(Interface) + QML_IMPLEMENTS_INTERFACES(Interface1) }; -class ImplementsInterfaces2 : public QObject, public Interface, public Interface2 +class ImplementsInterfaces2 : public QObject, public Interface1, public Interface2 { Q_OBJECT QML_ELEMENT - QML_IMPLEMENTS_INTERFACES(Interface Interface2) + QML_IMPLEMENTS_INTERFACES(Interface1 Interface2) }; class ExcessiveVersion : public QObject |