diff options
| author | Ulf Hermann <ulf.hermann@qt.io> | 2020-10-26 13:55:52 +0100 |
|---|---|---|
| committer | Ulf Hermann <ulf.hermann@qt.io> | 2020-10-27 09:29:43 +0100 |
| commit | 03d81887d7edc49bcd76d653a4283336d68b21a6 (patch) | |
| tree | 6e5e3db6889f37736540bc37f28f20c0365fe5cc /tools | |
| parent | bffcb953e1a824156f6021b33a3aa5de3afb56ac (diff) | |
qmllint: Check identifiers before giving up in case of previous errors
The identifier check might yet yield more information.
Change-Id: I96f700acf257736fea7e9c2023b9e8797f702f7c
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Maximilian Goldstein <max.goldstein@qt.io>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/qmllint/findwarnings.cpp | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/tools/qmllint/findwarnings.cpp b/tools/qmllint/findwarnings.cpp index fc90884d60..653c5bc209 100644 --- a/tools/qmllint/findwarnings.cpp +++ b/tools/qmllint/findwarnings.cpp @@ -339,9 +339,6 @@ bool FindWarningVisitor::check() } } - if (m_visitFailed) - return false; - // now that all ids are known, revisit any Connections whose target were perviously unknown for (auto const &outstandingConnection: m_outstandingConnections) { auto targetScope = m_scopesById[outstandingConnection.targetName]; @@ -361,7 +358,8 @@ bool FindWarningVisitor::check() return true; CheckIdentifiers check(&m_colorOut, m_code, m_rootScopeImports, m_filePath); - return check(m_scopesById, m_signalHandlers, m_memberAccessChains, m_globalScope, m_rootId); + return check(m_scopesById, m_signalHandlers, m_memberAccessChains, m_globalScope, m_rootId) + && !m_visitFailed; } bool FindWarningVisitor::visit(QQmlJS::AST::UiObjectBinding *uiob) |