diff options
author | Ulf Hermann <ulf.hermann@qt.io> | 2021-03-30 11:31:52 +0200 |
---|---|---|
committer | Fabian Kosmale <fabian.kosmale@qt.io> | 2021-03-31 08:41:29 +0200 |
commit | 4d233bb0f3c829db68815ce42e8d128751dfee7e (patch) | |
tree | b8adb4e6505d70af922280923558468ea58f30f4 /tools | |
parent | 3fde335a522a9c6ce75c780bc4b89a7c4111d8b4 (diff) |
QQmlJSLogger: Don't store references in a class
This is rather dangerous since we often pass references to stack values
there. Those can easily disappear.
Change-Id: I5a57b4af9035ba032b5fd475aed6af29aa888d83
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Diffstat (limited to 'tools')
-rw-r--r-- | tools/qmllint/findwarnings.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/tools/qmllint/findwarnings.cpp b/tools/qmllint/findwarnings.cpp index df53741d62..bf54122de3 100644 --- a/tools/qmllint/findwarnings.cpp +++ b/tools/qmllint/findwarnings.cpp @@ -407,10 +407,10 @@ FindWarningVisitor::FindWarningVisitor( bool silent) : QQmlJSImportVisitor(importer, implicitImportDirectory(fileName, importer->resourceFileMapper()), - qmltypesFiles, m_filePath, m_code, silent), - m_code(std::move(code)), + qmltypesFiles, fileName, code, silent), + m_code(code), m_rootId(QLatin1String("<id>")), - m_filePath(std::move(fileName)) + m_filePath(fileName) { m_currentScope->setInternalName("global"); |