3 files changed, 22 insertions, 14 deletions
diff --git a/tests/auto/qml/qqmlecmascript/testtypes.cpp b/tests/auto/qml/qqmlecmascript/testtypes.cpp
index c4692fdf31..80da5d7e52 100644
--- a/tests/auto/qml/qqmlecmascript/testtypes.cpp
+++ b/tests/auto/qml/qqmlecmascript/testtypes.cpp
@@ -245,9 +245,16 @@ public:
     MyWorkerObject *o;
 };
 
+MyWorkerObject::~MyWorkerObject()
+{
+    if (m_thread)
+        m_thread->wait();
+}
+
 void MyWorkerObject::doIt()
 {
-    new MyWorkerObjectThread(this);
+    Q_ASSERT(!m_thread);
+    m_thread = new MyWorkerObjectThread(this);
 }
 
 class MyDateClass : public QObject
diff --git a/tests/auto/qml/qqmlecmascript/testtypes.h b/tests/auto/qml/qqmlecmascript/testtypes.h
index eedeb66647..e15a05a00c 100644
--- a/tests/auto/qml/qqmlecmascript/testtypes.h
+++ b/tests/auto/qml/qqmlecmascript/testtypes.h
@@ -1532,12 +1532,17 @@ private:
 class MyWorkerObject : public QObject
 {
     Q_OBJECT
+public:
+    ~MyWorkerObject();
 
 public Q_SLOTS:
     void doIt();
 
 Q_SIGNALS:
     void done(const QString &result);
+
+private:
+    QThread *m_thread = 0;
 };
 
 class MyUnregisteredEnumTypeObject : public QObject
diff --git a/tests/auto/qml/qqmlecmascript/tst_qqmlecmascript.cpp b/tests/auto/qml/qqmlecmascript/tst_qqmlecmascript.cpp
index 7583579de6..899f14b51d 100644
--- a/tests/auto/qml/qqmlecmascript/tst_qqmlecmascript.cpp
+++ b/tests/auto/qml/qqmlecmascript/tst_qqmlecmascript.cpp
@@ -7447,21 +7447,17 @@ void tst_qqmlecmascript::signalEmitted()
 void tst_qqmlecmascript::threadSignal()
 {
     {
-    QQmlComponent c(&engine, testFileUrl("threadSignal.qml"));
-    QObject *object = c.create();
-    QVERIFY(object != 0);
-    QTRY_VERIFY(object->property("passed").toBool());
-    delete object;
+        QQmlComponent c(&engine, testFileUrl("threadSignal.qml"));
+        QScopedPointer<QObject> object(c.create());
+        QVERIFY(!object.isNull());
+        QTRY_VERIFY(object->property("passed").toBool());
     }
     {
-    QQmlComponent c(&engine, testFileUrl("threadSignal.2.qml"));
-    QObject *object = c.create();
-    QVERIFY(object != 0);
-    QSignalSpy doneSpy(object, SIGNAL(done(QString)));
-    QMetaObject::invokeMethod(object, "doIt");
-    QTRY_VERIFY(object->property("passed").toBool());
-    QCOMPARE(doneSpy.count(), 1);
-    delete object;
+        QQmlComponent c(&engine, testFileUrl("threadSignal.2.qml"));
+        QScopedPointer<QObject> object(c.create());
+        QVERIFY(!object.isNull());
+        QMetaObject::invokeMethod(object.data(), "doIt");
+        QTRY_VERIFY(object->property("passed").toBool());
     }
 }