aboutsummaryrefslogtreecommitdiffstats
path: root/tests/auto/quick/qquickitem/tst_qquickitem.cpp
diff options
context:
space:
mode:
Diffstat (limited to 'tests/auto/quick/qquickitem/tst_qquickitem.cpp')
-rw-r--r--tests/auto/quick/qquickitem/tst_qquickitem.cpp237
1 files changed, 226 insertions, 11 deletions
diff --git a/tests/auto/quick/qquickitem/tst_qquickitem.cpp b/tests/auto/quick/qquickitem/tst_qquickitem.cpp
index 23616156d6..e4cc434909 100644
--- a/tests/auto/quick/qquickitem/tst_qquickitem.cpp
+++ b/tests/auto/quick/qquickitem/tst_qquickitem.cpp
@@ -1,5 +1,5 @@
// Copyright (C) 2020 The Qt Company Ltd.
-// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0
+// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only
#include <qtest.h>
@@ -24,7 +24,7 @@
#include <QTranslator>
#include <QtCore/qregularexpression.h>
-#ifdef TEST_QTBUG_60123
+#ifdef QT_WIDGETS_LIB
#include <QWidget>
#include <QMainWindow>
#endif
@@ -217,7 +217,7 @@ private slots:
void shortcutOverride();
-#ifdef TEST_QTBUG_60123
+#ifdef QT_WIDGETS_LIB
void qtBug60123();
#endif
@@ -228,6 +228,9 @@ private slots:
void polishLoopDetection();
void objectCastInDestructor();
+ void listsAreNotLists();
+
+ void transformChanged();
private:
@@ -1993,13 +1996,6 @@ void tst_qquickitem::acceptedMouseButtons()
QCOMPARE(item.releaseCount, 3);
}
-static void gc(QQmlEngine &engine)
-{
- engine.collectGarbage();
- QCoreApplication::sendPostedEvents(nullptr, QEvent::DeferredDelete);
- QCoreApplication::processEvents();
-}
-
void tst_qquickitem::visualParentOwnership()
{
QQmlEngine engine;
@@ -2338,7 +2334,7 @@ void tst_qquickitem::shortcutOverride()
QCOMPARE(view.rootObject()->property("shortcutActivationCount").toInt(), 1);
}
-#ifdef TEST_QTBUG_60123
+#ifdef QT_WIDGETS_LIB
void tst_qquickitem::qtBug60123()
{
QMainWindow main;
@@ -2462,6 +2458,225 @@ void tst_qquickitem::objectCastInDestructor()
QVERIFY(QTest::qWaitFor([&destroyed]{ return destroyed; }));
}
+template<typename T>
+void verifyListProperty(const T &data)
+{
+ QVERIFY(data.object);
+ QVERIFY(data.append);
+ QVERIFY(data.count);
+ QVERIFY(data.at);
+ QVERIFY(data.clear);
+ QVERIFY(data.removeLast);
+
+ // We must not synthesize the replace and removeLast methods on those properties.
+ // They would be even more broken than the explicitly defined methods.
+ QVERIFY(!data.replace);
+}
+
+void tst_qquickitem::listsAreNotLists()
+{
+ QQuickItem item;
+ QQuickItem child;
+ QObject resource;
+
+ QQmlListProperty<QObject> data
+ = item.property("data").value<QQmlListProperty<QObject>>();
+ QQmlListProperty<QObject> resources
+ = item.property("resources").value<QQmlListProperty<QObject>>();
+ QQmlListProperty<QQuickItem> children
+ = item.property("children").value<QQmlListProperty<QQuickItem>>();
+
+ verifyListProperty(data);
+ verifyListProperty(resources);
+ verifyListProperty(children);
+
+
+ QCOMPARE(data.count(&data), 0);
+ QCOMPARE(resources.count(&resources), 0);
+ QCOMPARE(children.count(&children), 0);
+ children.append(&children, &child);
+ QCOMPARE(data.count(&data), 1);
+ QCOMPARE(resources.count(&resources), 0);
+ QCOMPARE(children.count(&children), 1);
+ children.removeLast(&children);
+ QCOMPARE(data.count(&data), 0);
+ QCOMPARE(resources.count(&resources), 0);
+ QCOMPARE(children.count(&children), 0);
+ data.append(&data, &child);
+ QCOMPARE(data.count(&data), 1);
+ QCOMPARE(resources.count(&resources), 0);
+ QCOMPARE(children.count(&children), 1);
+ data.removeLast(&data);
+ QCOMPARE(data.count(&data), 0);
+ QCOMPARE(resources.count(&resources), 0);
+ QCOMPARE(children.count(&children), 0);
+ children.append(&children, &child);
+ QCOMPARE(data.count(&data), 1);
+ QCOMPARE(resources.count(&resources), 0);
+ QCOMPARE(children.count(&children), 1);
+ data.removeLast(&data);
+ QCOMPARE(data.count(&data), 0);
+ QCOMPARE(resources.count(&resources), 0);
+ QCOMPARE(children.count(&children), 0);
+ data.append(&data, &child);
+ QCOMPARE(data.count(&data), 1);
+ QCOMPARE(resources.count(&resources), 0);
+ QCOMPARE(children.count(&children), 1);
+ children.removeLast(&children);
+ QCOMPARE(data.count(&data), 0);
+ QCOMPARE(resources.count(&resources), 0);
+ QCOMPARE(children.count(&children), 0);
+
+
+ resources.append(&resources, &resource);
+ QCOMPARE(data.count(&data), 1);
+ QCOMPARE(resources.count(&resources), 1);
+ QCOMPARE(children.count(&children), 0);
+ resources.removeLast(&resources);
+ QCOMPARE(data.count(&data), 0);
+ QCOMPARE(resources.count(&resources), 0);
+ QCOMPARE(children.count(&children), 0);
+ data.append(&data, &resource);
+ QCOMPARE(data.count(&data), 1);
+ QCOMPARE(resources.count(&resources), 1);
+ QCOMPARE(children.count(&children), 0);
+ data.removeLast(&data);
+ QCOMPARE(data.count(&data), 0);
+ QCOMPARE(resources.count(&resources), 0);
+ QCOMPARE(children.count(&children), 0);
+ resources.append(&resources, &resource);
+ QCOMPARE(data.count(&data), 1);
+ QCOMPARE(resources.count(&resources), 1);
+ QCOMPARE(children.count(&children), 0);
+ data.removeLast(&data);
+ QCOMPARE(data.count(&data), 0);
+ QCOMPARE(resources.count(&resources), 0);
+ QCOMPARE(children.count(&children), 0);
+ data.append(&data, &resource);
+ QCOMPARE(data.count(&data), 1);
+ QCOMPARE(resources.count(&resources), 1);
+ QCOMPARE(children.count(&children), 0);
+ resources.removeLast(&resources);
+ QCOMPARE(data.count(&data), 0);
+ QCOMPARE(resources.count(&resources), 0);
+ QCOMPARE(children.count(&children), 0);
+
+
+ children.append(&children, &child);
+ resources.append(&resources, &resource);
+ QCOMPARE(data.count(&data), 2);
+ QCOMPARE(resources.count(&resources), 1);
+ QCOMPARE(children.count(&children), 1);
+ children.removeLast(&children);
+ QCOMPARE(data.count(&data), 1);
+ QCOMPARE(resources.count(&resources), 1);
+ QCOMPARE(children.count(&children), 0);
+ resources.removeLast(&resources);
+ QCOMPARE(data.count(&data), 0);
+ QCOMPARE(resources.count(&resources), 0);
+ QCOMPARE(children.count(&children), 0);
+
+
+ children.append(&children, &child);
+ resources.append(&resources, &resource);
+ QCOMPARE(data.count(&data), 2);
+ QCOMPARE(resources.count(&resources), 1);
+ QCOMPARE(children.count(&children), 1);
+ resources.removeLast(&resources);
+ QCOMPARE(data.count(&data), 1);
+ QCOMPARE(resources.count(&resources), 0);
+ QCOMPARE(children.count(&children), 1);
+ children.removeLast(&children);
+ QCOMPARE(data.count(&data), 0);
+ QCOMPARE(resources.count(&resources), 0);
+ QCOMPARE(children.count(&children), 0);
+
+
+ data.append(&data, &child);
+ data.append(&data, &resource);
+ QCOMPARE(data.count(&data), 2);
+ QCOMPARE(resources.count(&resources), 1);
+ QCOMPARE(children.count(&children), 1);
+ data.removeLast(&data);
+ QCOMPARE(data.count(&data), 1);
+ QCOMPARE(resources.count(&resources), 1);
+ QCOMPARE(children.count(&children), 0);
+ data.removeLast(&data);
+ QCOMPARE(data.count(&data), 0);
+ QCOMPARE(resources.count(&resources), 0);
+ QCOMPARE(children.count(&children), 0);
+}
+
+class TransformItemPrivate;
+class TransformItem : public QQuickItem {
+ Q_OBJECT
+ Q_DECLARE_PRIVATE(TransformItem)
+public:
+ TransformItem(QQuickItem *parent = nullptr);
+
+ bool transformChanged = false;
+};
+
+class TransformItemPrivate :public QQuickItemPrivate
+{
+protected:
+ Q_DECLARE_PUBLIC(TransformItem)
+
+ bool transformChanged(QQuickItem *transformedItem) override
+ {
+ Q_Q(TransformItem);
+ q->transformChanged = true;
+ return true;
+ }
+};
+
+TransformItem::TransformItem(QQuickItem *parent)
+ : QQuickItem(*(new TransformItemPrivate), parent)
+{
+}
+
+void tst_qquickitem::transformChanged()
+{
+ QQuickItem rootItem;
+ QQuickItem *parents[2][3] = {};
+ for (int i = 0; i < 2; ++i) {
+ for (int j = 0; j < 3; ++j) {
+ auto *item = new QQuickItem;
+ item->setObjectName(QString("Item-%1.%2").arg(i).arg(j));
+ item->setParentItem(j > 0 ? parents[i][j - 1] : &rootItem);
+ parents[i][j] = item;
+ }
+ }
+
+ // Setting the root item's position will result in transformChanged,
+ // which will clear the subtreeTransformChangedEnabled flag that is
+ // by default set to true, since there are no children that observe
+ // the viewport.
+ parents[0][0]->setPosition(QPoint(100, 100));
+ parents[1][0]->setPosition(QPoint(200, 200));
+
+ TransformItem transformItem;
+ transformItem.setParentItem(parents[0][2]);
+ transformItem.setFlag(QQuickItem::ItemObservesViewport);
+ QCOMPARE(transformItem.mapToScene(QPoint(0, 0)), parents[0][0]->position());
+
+ parents[0][0]->setPosition(QPoint(110, 110));
+ QVERIFY2(transformItem.transformChanged,
+ "Moving an ancestor should trigger transformChanged");
+
+ transformItem.transformChanged = false;
+ transformItem.setParentItem(parents[1][2]);
+ QVERIFY2(transformItem.transformChanged,
+ "Reparenting the item should result in a transformChanged");
+ QCOMPARE(transformItem.mapToScene(QPoint(0, 0)), parents[1][0]->position());
+
+ transformItem.transformChanged = false;
+ parents[1][0]->setPosition(QPoint(220, 220));
+ QVERIFY2(transformItem.transformChanged,
+ "Changing one of the new ancestors should result in transformChanged");
+ QCOMPARE(transformItem.mapToScene(QPoint(0, 0)), parents[1][0]->position());
+}
+
QTEST_MAIN(tst_qquickitem)
#include "tst_qquickitem.moc"
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-27 14:00:53 +0000