diff options
author | Samuli Piippo <samuli.piippo@qt.io> | 2023-08-23 09:01:54 +0000 |
---|---|---|
committer | Samuli Piippo <samuli.piippo@qt.io> | 2023-08-23 14:48:31 +0300 |
commit | 90ef9d16533ded8bbec6a294229c891bdc095ddb (patch) | |
tree | 54774bdcdc7d4d43bf1a63f9511c888b83fb65b1 /src/networksettings/connman/qnetworksettingsmanager_p.cpp | |
parent | 736d6595d3e86526a2a185e0c77a187d59b3f4e0 (diff) |
Port away from foreach
Use range for loop instead.
Change-Id: I17d6d27fc3d784cb87d00153f87785377c7ec062
Reviewed-by: Pasi Petäjäjärvi <pasi.petajajarvi@qt.io>
Diffstat (limited to 'src/networksettings/connman/qnetworksettingsmanager_p.cpp')
-rw-r--r-- | src/networksettings/connman/qnetworksettingsmanager_p.cpp | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/src/networksettings/connman/qnetworksettingsmanager_p.cpp b/src/networksettings/connman/qnetworksettingsmanager_p.cpp index 77bf66f..94eec14 100644 --- a/src/networksettings/connman/qnetworksettingsmanager_p.cpp +++ b/src/networksettings/connman/qnetworksettingsmanager_p.cpp @@ -180,7 +180,7 @@ void QNetworkSettingsManagerPrivate::onTechnologyAdded(const QDBusObjectPath &te { Q_Q(QNetworkSettingsManager); - foreach (QNetworkSettingsInterface* item, m_interfaceModel.getModel()) { + for (QNetworkSettingsInterface* item : m_interfaceModel.getModel()) { ConnmanSettingsInterface* interface = qobject_cast<ConnmanSettingsInterface*>(item); if (interface->path() == technology.path()) { return; // we already know the interface/technology @@ -204,7 +204,7 @@ void QNetworkSettingsManagerPrivate::onTechnologyRemoved(const QDBusObjectPath & { Q_Q(QNetworkSettingsManager); - foreach (QNetworkSettingsInterface* item, m_interfaceModel.getModel()) { + for (QNetworkSettingsInterface* item : m_interfaceModel.getModel()) { ConnmanSettingsInterface* tech = qobject_cast<ConnmanSettingsInterface*>(item); if (tech->path() == technology.path()) { m_interfaceModel.removeInterface(tech->name()); @@ -221,7 +221,7 @@ void QNetworkSettingsManagerPrivate::getServicesFinished(QDBusPendingCallWatcher if (reply.isError()) return; - foreach (const ConnmanMapStruct &object, reply.value()) { + for (const ConnmanMapStruct &object : reply.value()) { const QString servicePath = object.objectPath.path(); handleNewService(servicePath); } @@ -236,7 +236,7 @@ void QNetworkSettingsManagerPrivate::getTechnologiesFinished(QDBusPendingCallWat if (reply.isError()) return; - foreach (const ConnmanMapStruct &object, reply.value()) { + for (const ConnmanMapStruct &object : reply.value()) { ConnmanSettingsInterface *item = new ConnmanSettingsInterface(object.objectPath.path(), object.propertyMap, this); item->scanServices(); @@ -253,7 +253,7 @@ void QNetworkSettingsManagerPrivate::getTechnologiesFinished(QDBusPendingCallWat void QNetworkSettingsManagerPrivate::onServicesChanged(ConnmanMapStructList changed, const QList<QDBusObjectPath> &removed) { Q_Q(QNetworkSettingsManager); - foreach (const QDBusObjectPath &dpath, removed) { + for (const QDBusObjectPath &dpath : removed) { QString path = dpath.path(); if (m_serviceModel->removeService(path)) @@ -279,14 +279,14 @@ void QNetworkSettingsManagerPrivate::onServicesChanged(ConnmanMapStructList chan } QStringList newServices; - foreach (const ConnmanMapStruct &map, changed) { + for (const ConnmanMapStruct &map : changed) { QString path = map.objectPath.path(); if (m_unknownServices.contains(path) || m_unnamedServices.contains(path)) continue; bool found = false; - foreach (QNetworkSettingsService* service, m_serviceModel->getModel()) { + for (QNetworkSettingsService* service : m_serviceModel->getModel()) { if (service->id() == path && service->placeholderState() == false) { found = true; break; @@ -296,7 +296,7 @@ void QNetworkSettingsManagerPrivate::onServicesChanged(ConnmanMapStructList chan newServices.append(map.objectPath.path()); } - foreach (QString newService, newServices) { + for (QString newService : newServices) { handleNewService(newService); } @@ -370,7 +370,7 @@ void QNetworkSettingsManagerPrivate::serviceReady() } //Update the interface state accordingly - foreach (QNetworkSettingsInterface* item, m_interfaceModel.getModel()) { + for (QNetworkSettingsInterface* item : m_interfaceModel.getModel()) { ConnmanSettingsInterface* technology = qobject_cast<ConnmanSettingsInterface*>(item); if (technology->name() == service->name() && technology->type() == service->type()) { technology->setState(technology->state()); |