diff options
author | Pasi Petäjäjärvi <pasi.petajajarvi@qt.io> | 2023-09-21 12:42:09 +0300 |
---|---|---|
committer | Pasi Petäjäjärvi <pasi.petajajarvi@qt.io> | 2023-09-21 14:13:29 +0300 |
commit | 1e0a0e5ff8dda33bdbaf7f2b8b506a3ecc26068e (patch) | |
tree | 905f9e599e8627ea5bd781c8e44f58ad1998c043 /src/networksettings/connman/qnetworksettingsservice_p.cpp | |
parent | 9e04294969addf942bedbfbbe7fab6df535fe714 (diff) |
Prevent copying QString in loop
In member function void QNetworkSettingsServicePrivate::updateProperty():
warning: loop variable ‘str’ creates a copy from type ‘const QString’
[-Wrange-loop-construct]
442 | for (const QString str : value) {
| ^~~
note: use reference type to prevent copying
442 | for (const QString str : value) {
| ^~~
Change-Id: I41e66113d0e2fc4022edff4ac09a9221e867ecf8
Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
Diffstat (limited to 'src/networksettings/connman/qnetworksettingsservice_p.cpp')
-rw-r--r-- | src/networksettings/connman/qnetworksettingsservice_p.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/networksettings/connman/qnetworksettingsservice_p.cpp b/src/networksettings/connman/qnetworksettingsservice_p.cpp index d3849b5..082b458 100644 --- a/src/networksettings/connman/qnetworksettingsservice_p.cpp +++ b/src/networksettings/connman/qnetworksettingsservice_p.cpp @@ -439,7 +439,7 @@ void QNetworkSettingsServicePrivate::updateProperty(const QString& key, const QV else if (key == PropertySecurity) { QStringList value = qdbus_cast<QStringList>(val); QNetworkSettingsWireless::Securities securities; - for (const QString str : value) { + for (const QString &str : value) { if (str == AttributeNone || str == AttributeWps) { securities |= QNetworkSettingsWireless::Security::None; } |