summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Make network type available from the modelSamuli Piippo2023-11-301-0/+4
| | | | | | | | | Network type was available in the model Roles enum, but it was not available with a role name and the data was never returned. Pick-to: 6.6 6.5 Change-Id: I2d0b39c0c3ba6dba3842b022f7111af0a565a014 Reviewed-by: Pasi Petäjäjärvi <pasi.petajajarvi@qt.io>
* Prevent copying QString in loopPasi Petäjäjärvi2023-09-211-1/+1
| | | | | | | | | | | | | | In member function void QNetworkSettingsServicePrivate::updateProperty(): warning: loop variable ‘str’ creates a copy from type ‘const QString’ [-Wrange-loop-construct] 442 | for (const QString str : value) { | ^~~ note: use reference type to prevent copying 442 | for (const QString str : value) { | ^~~ Change-Id: I41e66113d0e2fc4022edff4ac09a9221e867ecf8 Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* Do not shadow FINAL property modelDataPasi Petäjäjärvi2023-09-193-4/+6
| | | | | | | | | | | | | | | | | | Qt 6.6 changed many properties to FINAL for preventing adding new properties with same name (QTBUG-108739) and did break accessing Interface and Service related entries in the model. Document the model role for accessing underlying delegate properties. [ChangeLog][Important Behavior Changes][QtDeviceUtilities] Interface or Service from respective model cannot be no longer accessed by modelData anymore, use entry instead. Task-number: QTBUG-117041 Pick-to: 6.6 6.6.0 Change-Id: I467071fddb982093b757d448c0dfaa0ce1ad492a Reviewed-by: Samuli Piippo <samuli.piippo@qt.io> Reviewed-by: Kimmo Ollila <kimmo.ollila@qt.io>
* Port away from foreachSamuli Piippo2023-08-235-18/+18
| | | | | | | Use range for loop instead. Change-Id: I17d6d27fc3d784cb87d00153f87785377c7ec062 Reviewed-by: Pasi Petäjäjärvi <pasi.petajajarvi@qt.io>
* Fix missing qnetworksettingsglobal.h includeJoerg Bornemann2022-12-121-0/+1
| | | | | | | | | The header needs to appear in the list of sources for syncqt/cpp. Fixes: QTBUG-109338 Change-Id: Icce8e7ea9763405d4d6f5f921c56f5a0cd38b4ef Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io> Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
* Fix include style to what's mandated for public headersJoerg Bornemann2022-12-128-9/+9
| | | | | | | This fixes errors for the developer-build. Change-Id: Ibd2be59e5f39688b5d7a3de5b3e2a716372ec850 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Fix occasional segmentation fault when processing wireless networksJanne Juntunen2022-11-081-2/+12
| | | | | | | | | | | Disconnect signals from a service which is about to be deleted later, so that it will not get added to the m_serviceModel list and become a dangling pointer there later on. Fixes: QTBUG-107561 Pick-to: 6.4 6.2 5.15 Change-Id: Ifcd99bfacda8d4a932a93d10a94fa0e1613cbe98 Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* Fix connman dbus interfaceSamuli Piippo2022-08-221-1/+1
| | | | | | | | | | | Signal argument should be outgoing. Fixes interface generation now that compatibility code was removed from qdbusxml2cpp (qtbase e163c4943593aec7f69c2bbaf49a0020d806d23d) Fixes: QTBUG-105849 Pick-to: 6.4 Change-Id: I95910d8a31f6f905d3a2fd49941c9464470bea94 Reviewed-by: Pasi Petäjäjärvi <pasi.petajajarvi@qt.io>
* CMake: use PUBLIC_LIBRARIES as now NetworksSettings is pure libraryPasi Petäjäjärvi2022-06-271-1/+1
| | | | | | Pick-to: 6.4 Change-Id: I4e6d583baef0437dae4b6a677d1d3113504c3d46 Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* Use CMake-generated exports header filePasi Petäjäjärvi2022-06-2710-14/+55
| | | | | | | | | | | | | Fixes linking issues with gcc 12.1.0 + ld.gold (binutils 2.38) for qemu86_64 target. requires dynamic R_X86_64_PC32 reloc against '_ZN23QNetworkSettingsManager16staticMetaObjectE' which may overflow at runtime; recompile with -fPIC Pick-to: 6.3 6.4 Change-Id: Ifbc26357c5c360829b95e10e21ca37d2dd03efcf Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* Doc: Fix documentation issuesTopi Reinio2022-06-154-4/+5
| | | | | | | | | | | Add unversioned project name as a \keyword. This fixes a number of links to "Qt Device Utilities". Fix a number of typos and other minor issues. Pick-to: 6.4 6.3 Change-Id: I0c1ed8812b2c360181189a22afd022df51bb21e7 Reviewed-by: Nicholas Bennett <nicholas.bennett@qt.io>
* Docs: Update SettingUI git link pathNicholas Bennett2022-06-131-1/+2
| | | | | | | | | | The code location was moved to the examples folder, have updated the link path to match. Fixes: QTBUG-104115 Pick-to: 6.3 6.4 Change-Id: I69ab649fd389dd348212dbaeaed7f6df61cd2392 Reviewed-by: Pasi Petäjäjärvi <pasi.petajajarvi@qt.io>
* Fix crash when unplugging/plugging ethernet cablePasi Petäjäjärvi2022-05-191-2/+4
| | | | | | | | | | | | We do not remove the ethernet service (network) when cable is disconnected. Instead it's "hold in place" via placeholder but that is not checked and plugging cable back will cause crash. Pick-to: 5.15 6.2 6.3 Fixes: QTBUG-103327 Change-Id: If14a4f28217ba5883dbc23ba42a1e91b004b7d58 Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* Fix having zero initial technologies (interfaces) on devicePasi Petäjäjärvi2022-05-121-12/+15
| | | | | | | | | | | We always expect to have at least one technology available when new technology is added via onTechnologyAdded Pick-to: 5.15 6.2 6.3 Fixes: QTBUG-102816 Change-Id: Ia4f1c0b807ea14645a27bb1bc758f8879c5c2473 Reviewed-by: <schilling@mueller-elektronik.de> Reviewed-by: Teemu Holappa <teemu.holappa@qt.io>
* Docs: Remove device creation license informationNicholas Bennett2022-05-092-6/+2
| | | | | | | | | | | | | | | What commercial package a module is currently a part of should not be included in the technical documentation. That information is available here: https://www.qt.io/product/features Updated landing page. Removed an obsolete link. Pick-to: 6.3 6.2 Change-Id: I977f07d54cdc454c07e16cadbb8ae1d2e8202a20 Reviewed-by: Pasi Petäjäjärvi <pasi.petajajarvi@qt.io>
* Cleanup codePasi Petäjäjärvi2022-01-1720-79/+71
| | | | | | | | | | | | * Replace Q_NULLPTR with nullptr * Remove usage of QT_FORWARD_DECLARE_CLASS * Clean header includes Task-number: QTBUG-99742 Pick-to: 6.2 6.3 Change-Id: I1d33f33620fa70062381ba2d8597810e8840183c Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* Refactor using Q_ENUM instead of deprecated Q_ENUMSPasi Petäjäjärvi2022-01-1414-130/+155
| | | | | | | | Task-number: QTBUG-99742 Pick-to: 6.2 6.3 Change-Id: I9f3fc10b562d5cf25b366cca9f299cc53bb0f9f5 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* Fix dynamic interface handlingPasi Petäjäjärvi2021-12-172-8/+3
| | | | | | | | | Properly add/remove interface/technology when either physically added/removed or disable with connman Pick-to: 6.2 6.3 Change-Id: I8d527c60a0e9218e3ae01ba6a685e067182622c1 Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* Doc: Fix CMake build configuration for doc buildsTopi Reinio2021-12-168-19/+32
| | | | | | | | | | | * Add src/doc into the build * Select the correct doc template for online doc builds * Move and update the online sidebar * Fix q QDoc warning in passing Pick-to: 6.3 6.2 Change-Id: Ib40e5e05de337da59b69ce950edf2e9e041af536 Reviewed-by: Nicholas Bennett <nicholas.bennett@qt.io>
* Docs: Revert c5aa5c partiallyNicholas Bennett2021-12-161-1/+1
| | | | | | | | Reverted the change to the default-module.qdocconf include. Pick-to: 6.2 6.3 Change-Id: I80501abc4dcd20f13055ea247cb0dc068f07f557 Reviewed-by: Pasi Petäjäjärvi <pasi.petajajarvi@qt.io>
* Docs: Fix cannot find networksettingsqml warningNicholas Bennett2021-12-151-2/+2
| | | | | | | | Updated the location to ../networksettingsqml . Pick-to: 6.2 6.3 Change-Id: I62273c488a2c03c4c4661af67851381571c5aa5c Reviewed-by: Pasi Petäjäjärvi <pasi.petajajarvi@qt.io>
* Refactor SettingsUI source code and add QML module supportPasi Petäjäjärvi2021-12-1451-3524/+5
| | | | | | | | | | | | | | Split application and plugins structure to use QML modules feature Move settingsui binary and plugins it uses under examples as those are not really documented nor production quality. Task-number: QTBUG-97737 Pick-to: 6.2 6.3 Change-Id: I4b030a5a42b29554a45c23eab4170be980cd5dc5 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* Do not leak QNetworkSettingsService instances for unnamed networksRobert Griebl2021-12-032-22/+63
| | | | | | | | | | | | | | | | | For unnamed/hidden networks, a QNetworkSettingsService object was allocated every time connman reported these networks via its ServicesChanged signal. Depending on the system setup, this could happen as often as every 30sec. We now track these objects in m_unnamedServices and m_unknownServices to avoid those re-allocations. Also fixed a potential dangling pointer being returned from current{Wifi,Wired}Connection() Fixes: QTBUG-94864 Pick-to: 5.15 6.2 Change-Id: I0a217b1bd334073cc6621397ad09ce6a98776ab1 Reviewed-by: Pasi Petäjäjärvi <pasi.petajajarvi@qt.io>
* Fix servicesChanged() signal not being sentJanne Juntunen2021-12-021-1/+5
| | | | | | | | | | | Added servicesChanged() signal emitting when QNetworkSettingsManager notices that an existing wireless access point has disappeared. This functionality was missing previously. Fixes: QTBUG-90574 Pick-to: 5.15 6.2 Change-Id: I21c22d2fe30daa980db0db90419fdd4051add29d Reviewed-by: Pasi Petäjäjärvi <pasi.petajajarvi@qt.io>
* Fix exported QML typesPasi Petäjäjärvi2021-11-044-14/+14
| | | | | | | | | | | Currently exposed QML API is incorrect. Also move folder to prevent issues with pch generation with syncqt Task-number: QTBUG-97737 Change-Id: Iac58a2ba90f87302fc52a608ce7dea9acaedbdb6 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* Doc: Remove references to qmake support, it's already gonePasi Petäjäjärvi2021-10-271-8/+0
| | | | | | Pick-to: 6.2 Change-Id: I5ae83f4e68ae292926246e195855451e6e9ae8a4 Reviewed-by: Nicholas Bennett <nicholas.bennett@qt.io>
* CMake: use LIBRARIES in pluginsSamuli Piippo2021-09-223-3/+3
| | | | | | | | | | Fix CMake warnings caused by using PUBLIC_LIBRARIES in plugins. Plugins are not intended to be linked to. They should not have any public properties, but LIBRARIES instead of PUBLIC_LIBRARIES. Pick-to: 6.2 Change-Id: I35644c7ea97f03f26086c2ae5d2ea14a9e7a0a78 Reviewed-by: Mikko Gronoff <mikko.gronoff@qt.io>
* Add full include path for dbus headerSamuli Piippo2021-09-221-1/+1
| | | | | | | src/networksettings/connman/connmancommon.h:33:10: fatal error: QtDBus: No such file or directory Change-Id: I4f6b4870533e6c178d425ea6d06fb2c7bba8564e Reviewed-by: Mikko Gronoff <mikko.gronoff@qt.io>
* Port qtdeviceutilities to use declarative typesDan Ackers2021-06-2423-702/+274
| | | | | | Task-number: QTBUG-94426 Change-Id: I9ac17f38eccff96e25a6c1d40998b222d349274d Reviewed-by: Teemu Holappa <teemu.holappa@qt.io>
* CMake: skip build on wasmSamuli Piippo2021-06-141-5/+1
| | | | | | | | ... and do some cleanup on the CMake files. Change-Id: I999a76728bb5af1f53a3bde076143febc51d4d2c Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Teemu Holappa <teemu.holappa@qt.io>
* CMake: Update to latest Qt CMake APISamuli Piippo2021-06-145-74/+27
| | | | | | | Task-number: QTBUG-91621 Fixes: QTBUG-94396 Change-Id: Ieaf5241eeb297a86775bb784c39217eb2b92b1b9 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Remove all qmake filesSamuli Piippo2021-06-1410-175/+0
| | | | | | | Support builds only with CMake. Change-Id: I4b242a27d2d747ffa2d9b55a43f0d2b8f5f4cbc2 Reviewed-by: Teemu Holappa <teemu.holappa@qt.io>
* Doc: Fix documentation build issuesTopi Reinio2021-05-054-27/+16
| | | | | | | | | | | | * Add dependency to Qt Core for the documentation build; QDoc requires Qt-specific include paths * Restore custom module header to pull in NetworkSettings include path * Restore doc.pro as it's referenced from src.pro Task-number: QTBUG-93174 Change-Id: Ie06858bd6737348a0a7711560be83eef60de3af6 Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* Support Conan buildsLassi Lehikoinen2021-03-161-3/+1
| | | | | | Task-number: QTBUG-87956 Change-Id: I9ffbaa512db918d406489e5d9667c26b95c3dd54 Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>
* Enable documentation buildLassi Lehikoinen2021-03-043-17/+4
| | | | | | | | | Added a configuration flag to build the documentation. Qttools dependency is required for the QDoc for building the docs. Task-number: QTBUG-90829 Change-Id: I8dbff713184939db24f087129b3891e5a553adad Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* Update documentation regarding Qt 6 changesLassi Lehikoinen2020-12-295-58/+31
| | | | | | Task-number: QTBUG-88332 Change-Id: Ie6b9310e73b5515c97c892fbc27cd89009011c98 Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* Modify settingsui to work against Qt 6Lassi Lehikoinen2020-12-21111-302/+102
| | | | | | | | | | | | | Following modules are removed in Qt 6 - XmlListModel - QtGraphicalEffects Adapt settingsui to work without them. Also remove needless resources and make miscallaneous improvements. Task-number: QTBUG-89065 Change-Id: Ie66d73e4d8f9c1dd4cbec2fe5f9f71f32f7d1bdf Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* Build device utilities with CMake and qmake against Qt 6Lassi Lehikoinen2020-12-1623-25/+336
| | | | | | | | Also fix compiler warnings. Task-number: QTBUG-88317 Change-Id: Iff6014613a7d12426b6fe692dff0000c92930ace Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* Remove all device utilities except network settingsLassi Lehikoinen2020-12-1692-7827/+1
| | | | | | | | | Also remove USB ethernet functionality from Qt Network Settings. Task-number: QTBUG-88315 Change-Id: I06c41b61854b57f57c264b3c98940333902222d2 Reviewed-by: Samuli Piippo <samuli.piippo@qt.io> Reviewed-by: Rami Potinkara <rami.potinkara@qt.io>
* new menu item for usb ethernet protocol selectionRami Potinkara2020-07-156-81/+357
| | | | | | Task-number: QTBUG-83011 Change-Id: I8098ef26c9fa42cdf301145937eca011365d6f19 Reviewed-by: Teemu Holappa <teemu.holappa@qt.io>
* Doc: Override generated include statementPaul Wicking2020-06-301-0/+2
| | | | | | | | | | | | Specify the containing header file with the \inheaderfile QDoc command. Pick-to: 5.15 Fixes: QTBUG-81742 Change-Id: I15421748f2b5da636e4dbf9734720d0a82ecece2 Reviewed-by: Tarja Sundqvist <tarja.sundqvist@qt.io> Reviewed-by: Rami Potinkara <rami.potinkara@qt.io> Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
* Doc: Override generated include statementPaul Wicking2020-06-301-0/+1
| | | | | | | | | | | | Specify the containing header file with the \inheaderfile QDoc command. Pick-to: 5.15 Fixes: QTBUG-81741 Change-Id: I31b3d4b410877a0c8e28fea0603a14e0ba0148ad Reviewed-by: Tarja Sundqvist <tarja.sundqvist@qt.io> Reviewed-by: Rami Potinkara <rami.potinkara@qt.io> Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
* Change NTP setting synchronouslySamuli Piippo2020-05-121-1/+1
| | | | | | | | | | | | | Changing both NTP and Time may lead to error: Error org.freedesktop.timedate1.AutomaticTimeSyncEnabled: Previous request is not finished, refusing. Make sure we finish NTP request before attempting to set Time. Task-number: QTBUG-80721 Change-Id: I97c945b4ad4eeed6b077e7843ba061784592c299 Reviewed-by: Teemu Holappa <teemu.holappa@qt.io>
* Fix time zone selectionSamuli Piippo2020-05-121-0/+1
| | | | | | | | | | Set initial index to invalid to correctly map TimeManager.timeZone to the model index, otherwize index 0 was always used for the time zone when switching views. Task-number: QTBUG-80721 Change-Id: Ia242bbde9706e8771ffa9a630fdd8e50ed7ff1e2 Reviewed-by: Teemu Holappa <teemu.holappa@qt.io>
* Use function syntax for ConnectionSamuli Piippo2020-05-127-10/+10
| | | | | | | Implicitly defined onFoo properties in Connections are deprecated. Change-Id: I973a363437df27e0d7ad12e08991b211d62357dd Reviewed-by: Teemu Holappa <teemu.holappa@qt.io>
* fix incomplete QPainterPathMikko Gronoff2020-03-121-0/+1
| | | | | | | | Fix error: aggregate 'QPainterPath path' has incomplete type and cannot be defined Change-Id: I2f169fa0a5d0def2f9cc485270905b4395738def Reviewed-by: Teemu Holappa <teemu.holappa@qt.io>
* Merge remote-tracking branch 'origin/5.13' into 5.14Mikko Gronoff2019-10-091-1/+1
|\ | | | | | | | | | | | | | | * origin/5.13: fad870b Merge remote-tracking branch 'origin/5.12' into 5.13 39772d9 Fix static ip address showing after reconnection Change-Id: I48a3f8ef1c787c37ae9c1fa0373ef9c797fd21df
| * Merge remote-tracking branch 'origin/5.12' into 5.13Mikko Gronoff2019-10-081-1/+1
| |\ | | | | | | | | | | | | | | | | | | * origin/5.12: 39772d9 Fix static ip address showing after reconnection Change-Id: I534bd8b4877893750fb902238bb8ff44394b8286
| | * Fix static ip address showing after reconnectionTeemu Holappa2019-10-081-1/+1
| | | | | | | | | | | | | | | | | | Task-number: QTBUG-76224 Change-Id: I2684941df342c2a9ee0439a2e13a8894dd862965 Reviewed-by: Ville Voutilainen <ville.voutilainen@qt.io>
* | | Fix compiler warnings in network settingsTeemu Holappa2019-10-081-4/+3
|/ / | | | | | | | | Change-Id: I4dbcb432c404bdb167a986390aa90c1092f88593 Reviewed-by: Ville Voutilainen <ville.voutilainen@qt.io>
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-03 22:49:22 +0000