aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJędrzej Nowacki <jedrzej.nowacki@digia.com>2014-05-05 12:52:39 +0200
committerThe Qt Project <gerrit-noreply@qt-project.org>2014-05-05 14:08:11 +0200
commitc416ada9bebed82c9859882da14078222354c0d4 (patch)
tree66463500611702fa4c72255ef871d3a785f8d6e6
parent9ec6d950bc8f3694c6f39ca5cd09fe27737df798 (diff)
Add debug output tst_files test.
The test seems to be flaky on CI and lately it fails quite often, sadly nobody can reproduce the failure locally. Change-Id: I8e98c2946b7fd4f9750dc80e45ff007b56fd2fdc Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
-rw-r--r--tests/auto/files/tst_files.cpp22
1 files changed, 16 insertions, 6 deletions
diff --git a/tests/auto/files/tst_files.cpp b/tests/auto/files/tst_files.cpp
index 8ac1924..bc1d14d 100644
--- a/tests/auto/files/tst_files.cpp
+++ b/tests/auto/files/tst_files.cpp
@@ -258,9 +258,14 @@ void tst_Files::fileUploadDownload()
QNetworkRequest req;
req.setUrl(QUrl(downloadData["expiringUrl"].toString()));
QNetworkReply *reply = client.networkManager()->get(req);
- QVERIFY(reply);
- QSignalSpy downloadSpy(reply, SIGNAL(finished()));
- QTRY_COMPARE(downloadSpy.count(), 1);
+ QTRY_VERIFY(reply->isFinished());
+ if (reply->error() != QNetworkReply::NoError) {
+ // the test has failed already, let's printout some debugging information
+ qDebug() << downloadData;
+ qDebug() << req.url();
+ qDebug() << reply->readAll();
+ QCOMPARE(reply->error(), QNetworkReply::NoError);
+ }
QByteArray imageData = reply->readAll();
reply->deleteLater();
QImage img = QImage::fromData(imageData);
@@ -325,9 +330,14 @@ void tst_Files::fileUploadDownload()
QNetworkRequest req;
req.setUrl(QUrl(downloadData["expiringUrl"].toString()));
QNetworkReply *reply = client.networkManager()->get(req);
- QVERIFY(reply);
- QSignalSpy downloadSpy(reply, SIGNAL(finished()));
- QTRY_COMPARE(downloadSpy.count(), 1);
+ QTRY_VERIFY(reply->isFinished());
+ if (reply->error() != QNetworkReply::NoError) {
+ // the test has failed already, let's printout some debugging information
+ qDebug() << downloadData;
+ qDebug() << req.url();
+ qDebug() << reply->readAll();
+ QCOMPARE(reply->error(), QNetworkReply::NoError);
+ }
QByteArray imageData = reply->readAll();
reply->deleteLater();
QImage img = QImage::fromData(imageData);