diff options
| author | Alexey Edelev <alexey.edelev@qt.io> | 2024-04-09 14:15:47 +0200 |
|---|---|---|
| committer | Alexey Edelev <alexey.edelev@qt.io> | 2024-04-10 14:10:41 +0200 |
| commit | bbf73aea1331a42b8f4b349e9e2caf88b486241d (patch) | |
| tree | d6df2c06f3593995fd6e3ecd99ef7349c68d67fd | |
| parent | ab86f0f755377edac1224d293094592905b3ad9e (diff) | |
Remove redundant const modifiers from QGrpcChannelOperation::sendData signal
The Qt signals shouldn't be const. The hole chain of const modifiers
was the result of some intermediate implenentation. In general the
QGrpcChannelOperation *QGrpcOperation::channelOperation return value
doesn't require to be const and the depdendent const modifier of
QGrpcChannelOperation::sendData signal can be removed too.
Change-Id: I64719307b1b33f136b6073af90759628048142bb
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
| -rw-r--r-- | src/grpc/qgrpcchanneloperation.cpp | 2 | ||||
| -rw-r--r-- | src/grpc/qgrpcchanneloperation.h | 2 | ||||
| -rw-r--r-- | src/grpc/qgrpcoperation.cpp | 2 | ||||
| -rw-r--r-- | src/grpc/qgrpcoperation.h | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/src/grpc/qgrpcchanneloperation.cpp b/src/grpc/qgrpcchanneloperation.cpp index 4b6f768..1301517 100644 --- a/src/grpc/qgrpcchanneloperation.cpp +++ b/src/grpc/qgrpcchanneloperation.cpp @@ -35,7 +35,7 @@ QT_BEGIN_NAMESPACE */ /*! - \fn void QGrpcChannelOperation::sendData(const QByteArray &data) const + \fn void QGrpcChannelOperation::sendData(const QByteArray &data) The signal is emitted when the client tries to send a new message to the channel. diff --git a/src/grpc/qgrpcchanneloperation.h b/src/grpc/qgrpcchanneloperation.h index 8e69d5b..61961db 100644 --- a/src/grpc/qgrpcchanneloperation.h +++ b/src/grpc/qgrpcchanneloperation.h @@ -47,7 +47,7 @@ public: Q_SIGNALS: void dataReady(const QByteArray &data); - void sendData(const QByteArray &data) const; + void sendData(const QByteArray &data); void errorOccurred(const QGrpcStatus &status); void finished(); diff --git a/src/grpc/qgrpcoperation.cpp b/src/grpc/qgrpcoperation.cpp index 8978565..1b7da9a 100644 --- a/src/grpc/qgrpcoperation.cpp +++ b/src/grpc/qgrpcoperation.cpp @@ -153,7 +153,7 @@ QLatin1StringView QGrpcOperation::method() const noexcept \internal Returns a pointer to the assigned channel-side QGrpcChannelOperation. */ -const QGrpcChannelOperation *QGrpcOperation::channelOperation() const noexcept +QGrpcChannelOperation *QGrpcOperation::channelOperation() const noexcept { return d_func()->channelOperation.get(); } diff --git a/src/grpc/qgrpcoperation.h b/src/grpc/qgrpcoperation.h index 4f3e7df..59c2044 100644 --- a/src/grpc/qgrpcoperation.h +++ b/src/grpc/qgrpcoperation.h @@ -49,7 +49,7 @@ Q_SIGNALS: protected: explicit QGrpcOperation(std::shared_ptr<QGrpcChannelOperation> channelOperation); - [[nodiscard]] const QGrpcChannelOperation *channelOperation() const noexcept; + [[nodiscard]] QGrpcChannelOperation *channelOperation() const noexcept; [[nodiscard]] std::shared_ptr<const QAbstractProtobufSerializer> serializer() const noexcept; private: |