aboutsummaryrefslogtreecommitdiffstats
path: root/taglib/flac
diff options
context:
space:
mode:
authorTsuda Kageyu <tsuda.kageyu@gmail.com>2017-01-16 00:59:12 +0900
committerTsuda Kageyu <tsuda.kageyu@gmail.com>2017-01-16 01:00:28 +0900
commit406e872ac3f6a59f6bdfe6cf9d2d5968aa3a9f39 (patch)
tree415a44a53c78ebac1a3cde7a316c9bc3fc2f8b0c /taglib/flac
parent193cbe3b6b019fd83fbc86dcd73591cb68aec2c9 (diff)
Always use parentheses with new. It's a bit safer.
Diffstat (limited to 'taglib/flac')
-rw-r--r--taglib/flac/flacfile.cpp2
-rw-r--r--taglib/flac/flacpicture.cpp8
-rw-r--r--taglib/flac/flacunknownmetadatablock.cpp5
3 files changed, 7 insertions, 8 deletions
diff --git a/taglib/flac/flacfile.cpp b/taglib/flac/flacfile.cpp
index b2014886..09e184f0 100644
--- a/taglib/flac/flacfile.cpp
+++ b/taglib/flac/flacfile.cpp
@@ -300,7 +300,7 @@ ID3v2::Tag *FLAC::File::ID3v2Tag(bool create)
if(!create || d->tag[FlacID3v2Index])
return static_cast<ID3v2::Tag *>(d->tag[FlacID3v2Index]);
- d->tag.set(FlacID3v2Index, new ID3v2::Tag);
+ d->tag.set(FlacID3v2Index, new ID3v2::Tag());
return static_cast<ID3v2::Tag *>(d->tag[FlacID3v2Index]);
}
diff --git a/taglib/flac/flacpicture.cpp b/taglib/flac/flacpicture.cpp
index 72c97247..ec07ad14 100644
--- a/taglib/flac/flacpicture.cpp
+++ b/taglib/flac/flacpicture.cpp
@@ -50,14 +50,14 @@ public:
ByteVector data;
};
-FLAC::Picture::Picture()
+FLAC::Picture::Picture() :
+ d(new PicturePrivate())
{
- d = new PicturePrivate;
}
-FLAC::Picture::Picture(const ByteVector &data)
+FLAC::Picture::Picture(const ByteVector &data) :
+ d(new PicturePrivate())
{
- d = new PicturePrivate;
parse(data);
}
diff --git a/taglib/flac/flacunknownmetadatablock.cpp b/taglib/flac/flacunknownmetadatablock.cpp
index dcd5d651..f9cf6e65 100644
--- a/taglib/flac/flacunknownmetadatablock.cpp
+++ b/taglib/flac/flacunknownmetadatablock.cpp
@@ -39,11 +39,10 @@ public:
ByteVector data;
};
-FLAC::UnknownMetadataBlock::UnknownMetadataBlock(int code, const ByteVector &data)
+FLAC::UnknownMetadataBlock::UnknownMetadataBlock(int code, const ByteVector &data) :
+ d(new UnknownMetadataBlockPrivate())
{
- d = new UnknownMetadataBlockPrivate;
d->code = code;
- //debug(String(data.toHex()));
d->data = data;
}