aboutsummaryrefslogtreecommitdiffstats
path: root/taglib/mpeg/id3v2/id3v2framefactory.cpp
diff options
context:
space:
mode:
authorJonathan Marshall <jmarshall@never.you.mind>2012-11-04 19:52:10 +1300
committerJonathan Marshall <jmarshall@never.you.mind>2012-11-04 19:52:10 +1300
commitc42bdeab43dc1a0fa1c15ddf025e76932ba26f62 (patch)
tree0425270586b59da9af07961dc35d4f84bcfca102 /taglib/mpeg/id3v2/id3v2framefactory.cpp
parent044da877e629ea180d734ba86339564dc0886a7f (diff)
fixes noop frame id size check in ID3v2::FrameFactory::createFrame
Diffstat (limited to 'taglib/mpeg/id3v2/id3v2framefactory.cpp')
-rw-r--r--taglib/mpeg/id3v2/id3v2framefactory.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/taglib/mpeg/id3v2/id3v2framefactory.cpp b/taglib/mpeg/id3v2/id3v2framefactory.cpp
index 7e2e98a8..bba2985c 100644
--- a/taglib/mpeg/id3v2/id3v2framefactory.cpp
+++ b/taglib/mpeg/id3v2/id3v2framefactory.cpp
@@ -99,7 +99,7 @@ Frame *FrameFactory::createFrame(const ByteVector &origData, Header *tagHeader)
// A quick sanity check -- make sure that the frameID is 4 uppercase Latin1
// characters. Also make sure that there is data in the frame.
- if(!frameID.size() == (version < 3 ? 3 : 4) ||
+ if(frameID.size() != (version < 3 ? 3 : 4) ||
header->frameSize() <= uint(header->dataLengthIndicator() ? 4 : 0) ||
header->frameSize() > data.size())
{