Reduce useless memory reallocation in String::upper().

1 files changed, 2 insertions, 3 deletions

diff --git a/taglib/toolkit/tstring.cpp b/taglib/toolkit/tstring.cpp
index bee4fb7e..863bbf59 100644
--- a/taglib/toolkit/tstring.cpp
+++ b/taglib/toolkit/tstring.cpp
@@ -469,12 +469,11 @@ String & String::clear()
 String String::upper() const
 {
   String s;
-
-  static int shift = 'A' - 'a';
+  s.d->data.reserve(size());
 
   for(ConstIterator it = begin(); it != end(); ++it) {
     if(*it >= 'a' && *it <= 'z')
-      s.d->data.push_back(*it + shift);
+      s.d->data.push_back(*it + 'A' - 'a');
     else
       s.d->data.push_back(*it);
   }