Fix not all members of a class are initialized inside the constructor

Change-Id: Ibe879ace0f4bda98df3f142b5ac2c29a3156dfc8
Reviewed-by: Andrew O'Doherty <andrew.odoherty@qt.io>
Reviewed-by: Karsten Heimrich <karsten.heimrich@qt.io>

13 files changed, 36 insertions, 35 deletions

diff --git a/src/knx/knxproj/qknxbuildings_p.h b/src/knx/knxproj/qknxbuildings_p.h
index 923ef6e..6baa7ef 100644
--- a/src/knx/knxproj/qknxbuildings_p.h
+++ b/src/knx/knxproj/qknxbuildings_p.h
@@ -56,7 +56,7 @@ public:
     QString Name; // 255 character max.
     QString RefId; // non-colonized name, pattern [\i-[:]][\c-[:]]*
     QString Role; // optional, 255 character max.
-    qint32 Puid;
+    qint32 Puid { 0 };
 
     bool parseElement(QXmlStreamReader *reader, bool pedantic);
 };
@@ -77,7 +77,7 @@ public:
     QString CompletionStatus { QLatin1String("Undefined") }; // optional
 
     QString DefaultGroupRange; // optional, non-colonized name, pattern [\i-[:]][\c-[:]]*
-    qint32 Puid;
+    qint32 Puid { 0 };
 
     QVector<QKnxGroupAddressRef> GroupAddressRef; // 0..n
 
@@ -100,7 +100,7 @@ public:
     QString CompletionStatus { QLatin1String("Undefined") }; // optional
 
     QString DefaultLine; // optional
-    qint32 Puid;
+    qint32 Puid { 0 };
 
     QVector<QKnxBuildingPart> BuildingPart; // 0..n
     QVector<QString> DeviceInstanceRef; // 0..n, non-colonized name, pattern [\i-[:]][\c-[:]]*
diff --git a/src/knx/knxproj/qknxdeviceinstance_p.h b/src/knx/knxproj/qknxdeviceinstance_p.h
index 96c0642..6d94c68 100644
--- a/src/knx/knxproj/qknxdeviceinstance_p.h
+++ b/src/knx/knxproj/qknxdeviceinstance_p.h
@@ -121,7 +121,7 @@ struct Q_KNX_EXPORT QKnxAdditionalAddress
     Q_DECLARE_TR_FUNCTIONS(QKnxAdditionalAddress)
 
 public:
-    quint8 Address; // min. value 1, 255 value max.
+    quint8 Address { 0 }; // min. value 1, 255 value max.
     QString Name; // optional, 255 character max.
     QString Description; // optional
     QString Comment; // optional
@@ -168,7 +168,7 @@ public:
     QString LoadedDeviceManagementPassword; // optional, 20 character max.
     QString ToolKey; // optional, 40 character max.
     QString LoadedToolKey; // optional, 40 character max.
-    quint32 SequenceNumber; // optional
+    quint32 SequenceNumber { 0 }; // optional
     QDateTime SequenceNumberTimestamp; // optional
 
     bool parseElement(QXmlStreamReader *reader, bool pedantic);
@@ -198,13 +198,13 @@ public:
     QString Id; // non-colonized name, pattern [\i-[:]][\c-[:]]*
     QString ProductRefId; // non-colonized name, pattern [\i-[:]][\c-[:]]*
     QString Hardware2ProgramRefId; // optional, non-colonized name, pattern [\i-[:]][\c-[:]]*
-    qint32 Address; // optional, min. value 0, 255 value max.
+    qint32 Address { 0 }; // optional, min. value 0, 255 value max.
     QString Comment; // optional
     QDateTime LastModified; // optional
     QDateTime LastDownload; // optional
-    quint16 LastUsedAPDULength; // optional
-    quint16 ReadMaxAPDULength; // optional
-    quint16 ReadMaxRoutingAPDULength; // optional
+    quint16 LastUsedAPDULength { 0 }; // optional
+    quint16 ReadMaxAPDULength { 0 }; // optional
+    quint16 ReadMaxRoutingAPDULength { 0 }; // optional
     QString InstallationHints; // optional
 
     // Undefined, Editing, FinishedDesign, FinishedCommissioning, Tested, Accepted, Locked
@@ -218,12 +218,12 @@ public:
     QByteArray LoadedImage; // optional, Base64 encoded
     QString Description; // optional
     QByteArray CheckSums; // optional, Base64 encoded
-    bool IsCommunicationObjectVisibilityCalculated; // optional
+    bool IsCommunicationObjectVisibilityCalculated { false }; // optional
     bool Broken { false }; // optional
     QByteArray SerialNumber; // optional, Base64 encoded
     QString UniqueId; // optional, pattern \{[0-9A-F]{8}-[0-9A-F]{4}-[0-9A-F]{4}-[0-9A-F]{4}-[0-9A-F]{12}\}
     bool IsRFRetransmitter { false }; // optional
-    qint32 Puid;
+    qint32 Puid { 0 };
 
     QVector<QKnxParameterInstanceRef> ParameterInstanceRefs; // 0..n
     QVector<QKnxComObjectInstanceRef> ComObjectInstanceRefs; // 0..n
diff --git a/src/knx/knxproj/qknxgroupaddresses_p.h b/src/knx/knxproj/qknxgroupaddresses_p.h
index 6fad1d2..3bace75 100644
--- a/src/knx/knxproj/qknxgroupaddresses_p.h
+++ b/src/knx/knxproj/qknxgroupaddresses_p.h
@@ -100,12 +100,12 @@ struct Q_KNX_EXPORT QKnxGroupRange
 public:
     QString Id; // non-colonized name, pattern [\i-[:]][\c-[:]]*
     QString Name; // 255 character max.
-    quint16 RangeStart;
-    quint16 RangeEnd;
+    quint16 RangeStart { 0 };
+    quint16 RangeEnd { 0 };
     bool Unfiltered { false }; // optional
     QString Description; // optional
     QString Comment; // optional
-    qint32 Puid;
+    qint32 Puid { 0 };
     QString Security { QLatin1String("Auto") }; // optional, Auto, On, Off
 
     QVector<QKnxGroupRange> GroupRange; // 0..65535
diff --git a/src/knx/knxproj/qknxinstallation_p.h b/src/knx/knxproj/qknxinstallation_p.h
index 8f4afa9..f2c4a6a 100644
--- a/src/knx/knxproj/qknxinstallation_p.h
+++ b/src/knx/knxproj/qknxinstallation_p.h
@@ -65,7 +65,7 @@ public:
     QString CompletionStatus { QLatin1String("Undefined") }; // optional
 
     QString Description; // optional
-    qint32 Puid;
+    qint32 Puid { 0 };
 
     QVector<QKnxTrade> Trade; // 0..n
     QVector<QString> DeviceInstanceRef; // 0..n, non-colonized name, pattern [\i-[:]][\c-[:]]*
@@ -90,7 +90,7 @@ struct Q_KNX_EXPORT QKnxInstallation
 
 public:
     QString Name; // 50 character max.
-    quint16 InstallationId; // optional, value max. 15
+    quint16 InstallationId { 0 }; // optional, value max. 15
     quint32 BCUKey { 4294967295 }; //optional
 
     // pattern ((25[0-5]|2[0-4][0-9]|1[0-9][0-9]|[1-9][0-9]|[0-9])\.){3}(25[0-5]|2[0-4][0-9]|1[0-9][0-9]|[1-9][0-9]|[0-9])
@@ -98,7 +98,7 @@ public:
 
     quint8 MulticastTTL { 16 }; // optional
     QString IPRoutingBackboneKey; // optional, 40 character max.
-    quint16 IPRoutingLatencyTolerance; // optional
+    quint16 IPRoutingLatencyTolerance { 0 }; // optional
     float IPSyncLatencyFraction { 0.1f }; // optional
     QString DefaultLine; // optional
 
diff --git a/src/knx/knxproj/qknxprojectinformation_p.h b/src/knx/knxproj/qknxprojectinformation_p.h
index 8411c71..8a14ae2 100644
--- a/src/knx/knxproj/qknxprojectinformation_p.h
+++ b/src/knx/knxproj/qknxprojectinformation_p.h
@@ -119,7 +119,7 @@ public:
     QDateTime LastModified; // optional
     QDateTime ProjectStart; // optional
     QDateTime ProjectEnd; // optional
-    quint16 ProjectId; // optional, value max. 4095
+    quint16 ProjectId { 0 }; // optional, value max. 4095
     QString ProjectPassword; // optional, 20 character max
     QString Comment; // optional
 
@@ -134,8 +134,8 @@ public:
     QString CodePage; // optional, US-ASCII, UTF8, ISO-8859-1 -> ISO-8859-15
     bool BusAccessLegacyMode { false }; // optional
     QString Guid;
-    quint32 LastUsedPuid;
-    quint32 DeviceCount; // (optional) not declared inside the knx_project.xsd
+    quint32 LastUsedPuid { 0 };
+    quint32 DeviceCount { 0 }; // (optional) not declared inside the knx_project.xsd
 
     QVector<QKnxHistoryEntry> HistoryEntries; // 0..n
     QVector<QKnxToDoItem> ToDoItems; // 0..n
diff --git a/src/knx/knxproj/qknxtopology_p.h b/src/knx/knxproj/qknxtopology_p.h
index caf86c9..c4867d8 100644
--- a/src/knx/knxproj/qknxtopology_p.h
+++ b/src/knx/knxproj/qknxtopology_p.h
@@ -78,16 +78,16 @@ struct Q_KNX_EXPORT QKnxLine
 public:
     QString Id; // non-colonized name, pattern [\i-[:]][\c-[:]]*
     QString Name; // 255 character max.
-    qint32 Address; // optional, min. value 0, 15 value max.
+    qint32 Address { 0 }; // optional, min. value 0, 15 value max.
     QString MediumTypeRefId; // non-colonized name, pattern [\i-[:]][\c-[:]]*
     QString Comment; // optional
-    qint32 DomainAddress; // optional
+    qint32 DomainAddress { 0 }; // optional
 
     // Undefined, Editing, FinishedDesign, FinishedCommissioning, Tested, Accepted, Locked
     QString CompletionStatus { QLatin1String("Undefined") }; // optional
 
     QString Description; // optional
-    qint32 Puid;
+    qint32 Puid { 0 };
 
     QVector<QKnxDeviceInstance> DeviceInstance; // 0..n
     QVector<QKnxBusAccess> BusAccess; // 0..1
@@ -103,14 +103,14 @@ struct Q_KNX_EXPORT QKnxArea
 public:
     QString Id; // optional, non-colonized name, pattern [\i-[:]][\c-[:]]*
     QString Name; // 255 character max.
-    qint32 Address; // optional, min. value 0, 15 value max.
+    qint32 Address { 0 }; // optional, min. value 0, 15 value max.
     QString Comment; // optional
 
     // Undefined, Editing, FinishedDesign, FinishedCommissioning, Tested, Accepted, Locked
     QString CompletionStatus { QLatin1String("Undefined") }; // optional
 
     QString Description; // optional
-    qint32 Puid;
+    qint32 Puid { 0 };
 
     QVector<QKnxLine> Line; // 0..16
 
diff --git a/src/knx/netip/qknxnetipconnectionstateresponse.h b/src/knx/netip/qknxnetipconnectionstateresponse.h
index 47e3e91..726054d 100644
--- a/src/knx/netip/qknxnetipconnectionstateresponse.h
+++ b/src/knx/netip/qknxnetipconnectionstateresponse.h
@@ -59,7 +59,7 @@ public:
         QKnxNetIpFrame create() const;
 
     private:
-        quint8 m_channelId;
+        quint8 m_channelId { 0 };
         QKnxNetIp::Error m_status { QKnxNetIp::Error::None };
     };
     static QKnxNetIpConnectionStateResponseProxy::Builder builder();
diff --git a/src/knx/netip/qknxnetipconnectresponse.h b/src/knx/netip/qknxnetipconnectresponse.h
index 2fb4c75..07cc53e 100644
--- a/src/knx/netip/qknxnetipconnectresponse.h
+++ b/src/knx/netip/qknxnetipconnectresponse.h
@@ -65,7 +65,7 @@ public:
         QKnxNetIpFrame create() const;
 
     private:
-        quint8 m_channelId;
+        quint8 m_channelId { 0 };
         QKnxNetIp::Error m_status { QKnxNetIp::Error::None };
         QKnxNetIpHpai m_hpai;
         QKnxNetIpCrd m_crd;
diff --git a/src/knx/netip/qknxnetipdisconnectresponse.h b/src/knx/netip/qknxnetipdisconnectresponse.h
index 51cb62f..beff274 100644
--- a/src/knx/netip/qknxnetipdisconnectresponse.h
+++ b/src/knx/netip/qknxnetipdisconnectresponse.h
@@ -59,7 +59,7 @@ public:
         QKnxNetIpFrame create() const;
 
     private:
-        quint8 m_channelId;
+        quint8 m_channelId { 0 };
         QKnxNetIp::Error m_status { QKnxNetIp::Error::None };
     };
     static QKnxNetIpDisconnectResponseProxy::Builder builder();
diff --git a/src/knx/netip/qknxnetiproutinglostmessage.h b/src/knx/netip/qknxnetiproutinglostmessage.h
index 97d019c..397b875 100644
--- a/src/knx/netip/qknxnetiproutinglostmessage.h
+++ b/src/knx/netip/qknxnetiproutinglostmessage.h
@@ -60,7 +60,7 @@ public:
 
     private:
         QKnxNetIp::DeviceState m_state { QKnxNetIp::DeviceState::KnxFault };
-        quint16 m_lostMessageCount;
+        quint16 m_lostMessageCount { 0 };
 
     };
     static QKnxNetIpRoutingLostMessageProxy::Builder builder();
diff --git a/src/knx/netip/qknxnetipserverdescriptionagent_p.h b/src/knx/netip/qknxnetipserverdescriptionagent_p.h
index 84b54aa..4117903 100644
--- a/src/knx/netip/qknxnetipserverdescriptionagent_p.h
+++ b/src/knx/netip/qknxnetipserverdescriptionagent_p.h
@@ -76,7 +76,7 @@ private:
     QUdpSocket *socket { nullptr };
     QTimer *receiveTimer { nullptr };
 
-    quint16 port { 0 }, usedPort;
+    quint16 port { 0 }, usedPort { 0 };
     QHostAddress address { QHostAddress::AnyIPv4 };
 
     quint8 ttl { 60 };
diff --git a/src/knx/netip/qknxnetipserverdiscoveryagent_p.h b/src/knx/netip/qknxnetipserverdiscoveryagent_p.h
index 2d68f9f..9ec4409 100644
--- a/src/knx/netip/qknxnetipserverdiscoveryagent_p.h
+++ b/src/knx/netip/qknxnetipserverdiscoveryagent_p.h
@@ -77,7 +77,7 @@ private:
     QTimer *receiveTimer { nullptr };
     QTimer *frequencyTimer { nullptr };
 
-    quint16 port { 0 }, usedPort;
+    quint16 port { 0 }, usedPort { 0 };
     QHostAddress address { QHostAddress::AnyIPv4 }, usedAddress;
 
     const quint16 multicastPort { QKnxNetIp::Constants::DefaultPort };
diff --git a/src/knx/qknxdevicemanagementframefactory.h b/src/knx/qknxdevicemanagementframefactory.h
index 2715ca5..381e097 100644
--- a/src/knx/qknxdevicemanagementframefactory.h
+++ b/src/knx/qknxdevicemanagementframefactory.h
@@ -53,9 +53,10 @@ public:
     QKnxDeviceManagementFrame createFrame() const;
 
 private:
-    QKnxDeviceManagementFrame::MessageCode m_code;
+    QKnxDeviceManagementFrame::MessageCode m_code
+        { QKnxDeviceManagementFrame::MessageCode::Unknown };
     QKnxInterfaceObjectType m_type { QKnxInterfaceObjectType::Invalid };
-    quint8 m_instance;
+    quint8 m_instance { 0 };
     QKnxInterfaceObjectProperty m_pid { QKnxInterfaceObjectProperty::Invalid };
     QKnxByteArray m_data;
 };
@@ -116,8 +117,8 @@ public:
     QKnxDeviceManagementFrame createIndication(const QKnxByteArray &data) const;
 
 private:
-    int m_numberOfElements;
-    int m_startIndex;
+    int m_numberOfElements { 0 };
+    int m_startIndex { 0 };
     mutable QKnxDeviceManagementFrame::Builder m_builder;
 };