summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKonstantin Ritt <ritt.ks@gmail.com>2019-04-05 22:20:11 +0300
committerKonstantin Ritt <ritt.ks@gmail.com>2020-07-30 00:39:30 +0300
commit04ed0dcd88a8fb3d7c27213fd3f8396a2a5bb1df (patch)
treef3a72b9aef5c195e49ea3a5c814c87f392bff42d
parent2f929f204dba0c28f06c6b74aeff891ec5538fe9 (diff)
BatchRenderer: fix potential memory leak
if BatchRenderer would ever destroyed, we are leaking the BM objects tree and the pre-rendered frames of the not-yet unregistered animation(s) Change-Id: Ia55f58769c3efb725dcd60fc475988767b1f46b3 Reviewed-by: Rebecca Worledge <rebecca.worledge@theqtcompany.com>
-rw-r--r--src/imports/rasterrenderer/batchrenderer.cpp6
1 files changed, 5 insertions, 1 deletions
diff --git a/src/imports/rasterrenderer/batchrenderer.cpp b/src/imports/rasterrenderer/batchrenderer.cpp
index 0cd2cc6..7600b95 100644
--- a/src/imports/rasterrenderer/batchrenderer.cpp
+++ b/src/imports/rasterrenderer/batchrenderer.cpp
@@ -69,7 +69,11 @@ BatchRenderer::~BatchRenderer()
{
QMutexLocker mlocker(&m_mutex);
- qDeleteAll(m_animData);
+ for (Entry *entry : qAsConst(m_animData)) {
+ qDeleteAll(entry->frameCache);
+ delete entry->bmTreeBlueprint;
+ delete entry;
+ }
}
BatchRenderer *BatchRenderer::instance()