Define properties as QList/QSet instead of const QList/QSet &

Since QVariant always return a copy of the value returned by
READ method, there is no point in define property as const
QList/QSet &. Qt containers are implicitly shared, so that
returning by copy wouldn't imply too much cost. That also
eliminates the need of clients being responsible for release
data from derived properties.

Change-Id: I802a3f23b9fa571e7ed96a3bbb2253f690ff870d
Reviewed-by: Sandro S. Andrade <sandroandrade@kde.org>

1 files changed, 23 insertions, 30 deletions

diff --git a/examples/uml/nested-packages/main.cpp b/examples/uml/nested-packages/main.cpp
index 0a235745..293c3730 100644
--- a/examples/uml/nested-packages/main.cpp
+++ b/examples/uml/nested-packages/main.cpp
@@ -16,10 +16,6 @@
 using namespace QtUml;
 using namespace QtWrappedObjects;
 
-typedef const QSet<QPackage *> QPackageList;
-typedef const QSet<QStereotype *> QStereotypeList;
-typedef const QSet<QType *> QTypeList;
-
 void checkProperties(QObject *object)
 {
     const QMetaObject *metaObject = object->metaObject();
@@ -57,11 +53,11 @@ int main ()
     model->addPackagedElement(package);
     model->addOwnedType(primitiveType);
 
-    qDebug() << "model->ownedElements()->size():" << model->ownedElements().size();
-    qDebug() << "model->members()->size():" << model->members().size();
-    qDebug() << "model->ownedMembers()->size():" << model->ownedMembers().size();
-    qDebug() << "model->ownedRules()->size():" << model->ownedRules().size();
-    qDebug() << "model->packagedElements()->size():" << model->packagedElements().size();
+    qDebug() << "model->ownedElements().size():" << model->ownedElements().size();
+    qDebug() << "model->members().size():" << model->members().size();
+    qDebug() << "model->ownedMembers().size():" << model->ownedMembers().size();
+    qDebug() << "model->ownedRules().size():" << model->ownedRules().size();
+    qDebug() << "model->packagedElements().size():" << model->packagedElements().size();
     qDebug();
     qDebug() << "package->qualifiedName():" << package->qualifiedName();
     qDebug() << "package->nestingPackage() ?" << ((package->nestingPackage() == 0) ? "Nao":"Sim");
@@ -73,14 +69,14 @@ int main ()
     //model->removeNestedPackage(package);
     model->removePackagedElement(package);
     //model->addNestedPackage(package);
-    model->addPackagedElement(package);
+    //model->addPackagedElement(package);
     qDebug() << "REMOVED";
 
-    qDebug() << "model->ownedElements()->size():" << model->ownedElements().size();
-    qDebug() << "model->members()->size():" << model->members().size();
-    qDebug() << "model->ownedMembers()->size():" << model->ownedMembers().size();
-    qDebug() << "model->ownedRules()->size():" << model->ownedRules().size();
-    qDebug() << "model->packagedElements()->size():" << model->packagedElements().size();
+    qDebug() << "model->ownedElements().size():" << model->ownedElements().size();
+    qDebug() << "model->members().size():" << model->members().size();
+    qDebug() << "model->ownedMembers().size():" << model->ownedMembers().size();
+    qDebug() << "model->ownedRules().size():" << model->ownedRules().size();
+    qDebug() << "model->packagedElements().size():" << model->packagedElements().size();
     qDebug();
     qDebug() << "package->qualifiedName():" << package->qualifiedName();
     qDebug() << "package->nestingPackage() ?" << ((package->nestingPackage() == 0) ? "Nao":"Sim");
@@ -89,14 +85,11 @@ int main ()
     qDebug() << "primitiveType->qualifiedName():" << primitiveType->qualifiedName();
     qDebug() << "directionIn->qualifiedName():" << directionIn->qualifiedName();
 
-    QScopedPointer<QPackageList> nestedPackages (&model->nestedPackages());
-    qDebug() << "model->nestedPackages()->size():" << nestedPackages->size();
+    qDebug() << "model->nestedPackages().size():" << model->nestedPackages().size();
 
-    QScopedPointer<QStereotypeList> ownedStereotypes (&model->ownedStereotypes());
-    qDebug() << "model->ownedStereotypes()->size():" << ownedStereotypes->size();
+    qDebug() << "model->ownedStereotypes().size():" << model->ownedStereotypes().size();
 
-    QScopedPointer<QTypeList> ownedTypes (&model->ownedTypes());
-    qDebug() << "model->ownedTypes()->size():" << ownedTypes->size();
+    qDebug() << "model->ownedTypes().size():" << model->ownedTypes().size();
 
     checkProperties(model);
 
@@ -105,19 +98,19 @@ int main ()
     QWrappedObjectPointer<QComponentRealization> cr = new QComponentRealization;
     cr->setAbstraction(c1);
     qDebug();
-    qDebug() << "cr->suppliers()->size():" << cr->suppliers().size();
-    qDebug() << "c1->realizations()->size():" << c1->realizations().size();
-    qDebug() << "c2->realizations()->size():" << c2->realizations().size();
+    qDebug() << "cr->suppliers().size():" << cr->suppliers().size();
+    qDebug() << "c1->realizations().size():" << c1->realizations().size();
+    qDebug() << "c2->realizations().size():" << c2->realizations().size();
     cr->setAbstraction(c2);
     qDebug();
-    qDebug() << "cr->suppliers()->size():" << cr->suppliers().size();
-    qDebug() << "c1->realizations()->size():" << c1->realizations().size();
-    qDebug() << "c2->realizations()->size():" << c2->realizations().size();
+    qDebug() << "cr->suppliers().size():" << cr->suppliers().size();
+    qDebug() << "c1->realizations().size():" << c1->realizations().size();
+    qDebug() << "c2->realizations().size():" << c2->realizations().size();
     cr->setAbstraction(0);
     qDebug();
-    qDebug() << "cr->suppliers()->size():" << cr->suppliers().size();
-    qDebug() << "c1->realizations()->size():" << c1->realizations().size();
-    qDebug() << "c2->realizations()->size():" << c2->realizations().size();
+    qDebug() << "cr->suppliers().size():" << cr->suppliers().size();
+    qDebug() << "c1->realizations().size():" << c1->realizations().size();
+    qDebug() << "c2->realizations().size():" << c2->realizations().size();
     cr->setAbstraction(c1);
     package->addOwnedType(c1);
     package->addOwnedType(c2);