summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLars Knoll <lars.knoll@qt.io>2021-01-20 12:53:39 +0100
committerLars Knoll <lars.knoll@qt.io>2021-01-29 08:47:17 +0000
commit5ba50181b3b2a13b2fbb96bb2fd171f54de52327 (patch)
tree2612fe5394854afb5721feeedbae92ca8272e428
parent0f794eebb691238892bfaa30566aa523920e3420 (diff)
Remove the supportedMimeTypes() API in QMediaPlayer
We might want to re-add a "supportedContainerFormats()" method later on, but then implement something that actually works. For now it's probably better if the method is simply gone (it was only working on AVFoundation anyway). Change-Id: I3a19529b35c9d7916df7385b406fcccf19d7f484 Reviewed-by: Doris Verria <doris.verria@qt.io> Reviewed-by: Lars Knoll <lars.knoll@qt.io>
-rw-r--r--examples/multimediawidgets/player/player.cpp5
-rw-r--r--examples/multimediawidgets/videographicsitem/videoplayer.cpp3
-rw-r--r--examples/multimediawidgets/videowidget/videoplayer.cpp3
-rw-r--r--src/multimedia/playback/qmediaplayer.cpp31
-rw-r--r--src/multimedia/playback/qmediaplayer.h5
-rw-r--r--tests/auto/unit/qmediaplayer/tst_qmediaplayer.cpp8
6 files changed, 0 insertions, 55 deletions
diff --git a/examples/multimediawidgets/player/player.cpp b/examples/multimediawidgets/player/player.cpp
index 9ddc72ab2..b3d1d4123 100644
--- a/examples/multimediawidgets/player/player.cpp
+++ b/examples/multimediawidgets/player/player.cpp
@@ -222,11 +222,6 @@ void Player::open()
QFileDialog fileDialog(this);
fileDialog.setAcceptMode(QFileDialog::AcceptOpen);
fileDialog.setWindowTitle(tr("Open Files"));
- QStringList supportedMimeTypes = m_player->supportedMimeTypes();
- if (!supportedMimeTypes.isEmpty()) {
- supportedMimeTypes.append("audio/x-m3u"); // MP3 playlists
- fileDialog.setMimeTypeFilters(supportedMimeTypes);
- }
fileDialog.setDirectory(QStandardPaths::standardLocations(QStandardPaths::MoviesLocation).value(0, QDir::homePath()));
if (fileDialog.exec() == QDialog::Accepted)
addToPlaylist(fileDialog.selectedUrls());
diff --git a/examples/multimediawidgets/videographicsitem/videoplayer.cpp b/examples/multimediawidgets/videographicsitem/videoplayer.cpp
index 1b263c3bb..d0f5129c9 100644
--- a/examples/multimediawidgets/videographicsitem/videoplayer.cpp
+++ b/examples/multimediawidgets/videographicsitem/videoplayer.cpp
@@ -126,9 +126,6 @@ void VideoPlayer::openFile()
QFileDialog fileDialog(this);
fileDialog.setAcceptMode(QFileDialog::AcceptOpen);
fileDialog.setWindowTitle(tr("Open Movie"));
- const QStringList supportedMimeTypes = m_mediaPlayer->supportedMimeTypes();
- if (!supportedMimeTypes.isEmpty())
- fileDialog.setMimeTypeFilters(supportedMimeTypes);
fileDialog.setDirectory(QStandardPaths::standardLocations(QStandardPaths::MoviesLocation).value(0, QDir::homePath()));
if (fileDialog.exec() == QDialog::Accepted)
load(fileDialog.selectedUrls().constFirst());
diff --git a/examples/multimediawidgets/videowidget/videoplayer.cpp b/examples/multimediawidgets/videowidget/videoplayer.cpp
index 879637603..4ac868730 100644
--- a/examples/multimediawidgets/videowidget/videoplayer.cpp
+++ b/examples/multimediawidgets/videowidget/videoplayer.cpp
@@ -109,9 +109,6 @@ void VideoPlayer::openFile()
QFileDialog fileDialog(this);
fileDialog.setAcceptMode(QFileDialog::AcceptOpen);
fileDialog.setWindowTitle(tr("Open Movie"));
- QStringList supportedMimeTypes = m_mediaPlayer->supportedMimeTypes();
- if (!supportedMimeTypes.isEmpty())
- fileDialog.setMimeTypeFilters(supportedMimeTypes);
fileDialog.setDirectory(QStandardPaths::standardLocations(QStandardPaths::MoviesLocation).value(0, QDir::homePath()));
if (fileDialog.exec() == QDialog::Accepted)
setUrl(fileDialog.selectedUrls().constFirst());
diff --git a/src/multimedia/playback/qmediaplayer.cpp b/src/multimedia/playback/qmediaplayer.cpp
index c3ebd6f3d..fcf044cf7 100644
--- a/src/multimedia/playback/qmediaplayer.cpp
+++ b/src/multimedia/playback/qmediaplayer.cpp
@@ -619,37 +619,6 @@ void QMediaPlayer::setMedia(const QUrl &media, QIODevice *stream)
}
/*!
- Returns the level of support a media player has for a \a mimeType and a set of \a codecs.
-
- The \a flags argument allows additional requirements such as performance indicators to be
- specified.
-*/
-QMultimedia::SupportEstimate QMediaPlayer::hasSupport(const QString &mimeType,
- const QStringList& codecs)
-{
- return QMediaServiceProvider::defaultServiceProvider()->hasSupport(QByteArray(Q_MEDIASERVICE_MEDIAPLAYER),
- mimeType,
- codecs);
-}
-
-/*!
- \deprecated
- Returns a list of MIME types supported by the media player.
-
- The \a flags argument causes the resultant list to be restricted to MIME types which can be supported
- given additional requirements, such as performance indicators.
-
- This function may not return useful results on some platforms, and support for a specific file of a
- given mime type is not guaranteed even if the mime type is in general supported. In addition, in some
- cases this function will need to load all available media plugins and query them for their support, which
- may take some time.
-*/
-QStringList QMediaPlayer::supportedMimeTypes()
-{
- return QMediaServiceProvider::defaultServiceProvider()->supportedMimeTypes(QByteArray(Q_MEDIASERVICE_MEDIAPLAYER));
-}
-
-/*!
Sets the audio output to \a device.
Setting a null QAudioDeviceInfo, sets the output to the system default.
diff --git a/src/multimedia/playback/qmediaplayer.h b/src/multimedia/playback/qmediaplayer.h
index 5c8f9997d..591383c30 100644
--- a/src/multimedia/playback/qmediaplayer.h
+++ b/src/multimedia/playback/qmediaplayer.h
@@ -108,11 +108,6 @@ public:
explicit QMediaPlayer(QObject *parent = nullptr);
~QMediaPlayer();
- // ### this needs a better solution
- static QMultimedia::SupportEstimate hasSupport(const QString &mimeType,
- const QStringList& codecs = QStringList());
- static QStringList supportedMimeTypes();
-
// new API
// bool enableLowLatencyPlayback(bool tryEnable);
// bool isLowLatencyPlaybackEnabled() const;
diff --git a/tests/auto/unit/qmediaplayer/tst_qmediaplayer.cpp b/tests/auto/unit/qmediaplayer/tst_qmediaplayer.cpp
index c98d2a9e5..64436d768 100644
--- a/tests/auto/unit/qmediaplayer/tst_qmediaplayer.cpp
+++ b/tests/auto/unit/qmediaplayer/tst_qmediaplayer.cpp
@@ -120,7 +120,6 @@ private slots:
void testSetVideoOutputDestruction();
void debugEnums();
void testDestructor();
- void testSupportedMimeTypes();
void testQrc_data();
void testQrc();
void testAudioRole();
@@ -837,13 +836,6 @@ void tst_QMediaPlayer::debugEnums()
qDebug() << QMediaPlayer::NetworkError;
}
-void tst_QMediaPlayer::testSupportedMimeTypes()
-{
- QStringList mimeList = QMediaPlayer::supportedMimeTypes();
-
- // This is empty on some platforms, and not on others, so can't test something here at the moment.
-}
-
void tst_QMediaPlayer::testQrc_data()
{
QTest::addColumn<QUrl>("mediaContent");