diff options
| author | Artem Dyomin <artem.dyomin@qt.io> | 2023-05-02 16:07:32 +0200 |
|---|---|---|
| committer | Artem Dyomin <artem.dyomin@qt.io> | 2023-06-02 11:56:29 +0000 |
| commit | 3d9cca86bfb59d6cfefad2b32d53268d3ad205bf (patch) | |
| tree | 71d2e8d2ba631f7770b9f5b90af8d5991f11c351 /src/plugins/multimedia/ffmpeg/playbackengine/qffmpegaudiorenderer_p.h | |
| parent | 24c854fff9af00461b0920074b23d156e345a804 (diff) | |
Handle QMediaPlayer outputs corner cases
- Clean-up the video sink frame after stop, QMediaPlayer deleting,
and after setting new media.
- ensure no frames lost if change QVideoSink
- ensure no frames sent after changing of outputs.
The patch fixes problems with tests on Android, summarizing of
the related commits:
codereview.qt-project.org/c/qt/qtmultimedia/+/472214
codereview.qt-project.org/c/qt/qtmultimedia/+/470890
codereview.qt-project.org/c/qt/qtmultimedia/+/472052
Users want to have flush mode customization as it was it Qt5.
It might be added in 6.6 afterwards.
Fixes: QTBUG-112173
Task-number: QTBUG-111912
Change-Id: I0e4d34de06fcf23adf8a5736cbff4119478e9baf
Reviewed-by: Lars Knoll <lars@knoll.priv.no>
Diffstat (limited to 'src/plugins/multimedia/ffmpeg/playbackengine/qffmpegaudiorenderer_p.h')
| -rw-r--r-- | src/plugins/multimedia/ffmpeg/playbackengine/qffmpegaudiorenderer_p.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/plugins/multimedia/ffmpeg/playbackengine/qffmpegaudiorenderer_p.h b/src/plugins/multimedia/ffmpeg/playbackengine/qffmpegaudiorenderer_p.h index b5aef8a71..594af6edb 100644 --- a/src/plugins/multimedia/ffmpeg/playbackengine/qffmpegaudiorenderer_p.h +++ b/src/plugins/multimedia/ffmpeg/playbackengine/qffmpegaudiorenderer_p.h @@ -35,6 +35,8 @@ class AudioRenderer : public Renderer public: AudioRenderer(const TimeController &tc, QAudioOutput *output); + void setOutput(QAudioOutput *output); + ~AudioRenderer() override; protected: |