GStreamer: replace gst allocating ctors with factory functions

Factory functions are a bit more expressive, tooling-friendly, and make
it easier to reason about the code.

Pick-to: 6.5 6.6 6.7
Change-Id: I3f42f9b24216c28ff8430a8f7d4fbbc459839fb5
Reviewed-by: Jøger Hansegård <joger.hansegard@qt.io>
Reviewed-by: Artem Dyomin <artem.dyomin@qt.io>

1 files changed, 4 insertions, 4 deletions

diff --git a/src/plugins/multimedia/gstreamer/audio/qgstreameraudiosource.cpp b/src/plugins/multimedia/gstreamer/audio/qgstreameraudiosource.cpp
index deb1ca1f6..e3a2129bb 100644
--- a/src/plugins/multimedia/gstreamer/audio/qgstreameraudiosource.cpp
+++ b/src/plugins/multimedia/gstreamer/audio/qgstreameraudiosource.cpp
@@ -148,7 +148,7 @@ bool QGStreamerAudioSource::open()
     qDebug() << "Caps: " << gst_caps_to_string(gstCaps);
 #endif
 
-    gstPipeline = QGstPipeline("pipeline");
+    gstPipeline = QGstPipeline::create("pipeline");
 
     auto *gstBus = gst_pipeline_get_bus(gstPipeline.pipeline());
     gst_bus_add_watch(gstBus, &QGStreamerAudioSource::busMessage, this);
@@ -157,8 +157,8 @@ bool QGStreamerAudioSource::open()
     gstAppSink = createAppSink();
     gstAppSink.set("caps", gstCaps);
 
-    QGstElement conv("audioconvert", "conv");
-    gstVolume = QGstElement("volume", "volume");
+    QGstElement conv = QGstElement::createFromFactory("audioconvert", "conv");
+    gstVolume = QGstElement::createFromFactory("volume", "volume");
     Q_ASSERT(gstVolume);
     if (m_volume != 1.)
         gstVolume.set("volume", m_volume);
@@ -282,7 +282,7 @@ void QGStreamerAudioSource::reset()
 
 QGstElement QGStreamerAudioSource::createAppSink()
 {
-    QGstElement sink("appsink", "appsink");
+    QGstElement sink = QGstElement::createFromFactory("appsink", "appsink");
     GstAppSink *appSink = reinterpret_cast<GstAppSink *>(sink.element());
 
     GstAppSinkCallbacks callbacks;