diff options
| author | Yoann Lopes <yoann.lopes@theqtcompany.com> | 2016-07-07 12:26:53 +0200 |
|---|---|---|
| committer | Yoann Lopes <yoann.lopes@qt.io> | 2016-07-07 10:42:01 +0000 |
| commit | 17d54a2eb57816dbc531feee80dbd25f835e733a (patch) | |
| tree | 0ac612390256c78c607ed8fbcf727e8bbd121717 /src/plugins/wasapi | |
| parent | 27681cba4695355f2a0a6b01b85c429186d11a34 (diff) | |
WASAPI: remove irrelevant TODOs
The final volume conversion API has changed. In any case, we don't need
to convert the volume here; the Qt volume is linear and so is the
volume expected by IAudioStreamVolume.
Change-Id: I6065505735a6140843dcfefd8b2e0447fc83102d
Reviewed-by: Maurice Kalinowski <maurice.kalinowski@qt.io>
Diffstat (limited to 'src/plugins/wasapi')
| -rw-r--r-- | src/plugins/wasapi/qwasapiaudioinput.cpp | 1 | ||||
| -rw-r--r-- | src/plugins/wasapi/qwasapiaudiooutput.cpp | 1 |
2 files changed, 0 insertions, 2 deletions
diff --git a/src/plugins/wasapi/qwasapiaudioinput.cpp b/src/plugins/wasapi/qwasapiaudioinput.cpp index 1cc1c38f7..226c09ee8 100644 --- a/src/plugins/wasapi/qwasapiaudioinput.cpp +++ b/src/plugins/wasapi/qwasapiaudioinput.cpp @@ -169,7 +169,6 @@ void QWasapiAudioInput::setVolume(qreal vol) quint32 channelCount; HRESULT hr = m_volumeControl->GetChannelCount(&channelCount); for (quint32 i = 0; i < channelCount; ++i) { - // ### TODO: Use QAudioHelperInternal::qScaleVolumeFromLinear when integrated hr = m_volumeControl->SetChannelVolume(i, vol); RETURN_VOID_IF_FAILED("Could not set audio volume."); } diff --git a/src/plugins/wasapi/qwasapiaudiooutput.cpp b/src/plugins/wasapi/qwasapiaudiooutput.cpp index a45bc1f07..40a2b0cef 100644 --- a/src/plugins/wasapi/qwasapiaudiooutput.cpp +++ b/src/plugins/wasapi/qwasapiaudiooutput.cpp @@ -183,7 +183,6 @@ void QWasapiAudioOutput::setVolume(qreal vol) quint32 channelCount; HRESULT hr = m_volumeControl->GetChannelCount(&channelCount); for (quint32 i = 0; i < channelCount; ++i) { - // ### TODO: Use QAudioHelperInternal::qScaleVolumeFromLinear when integrated hr = m_volumeControl->SetChannelVolume(i, vol); RETURN_VOID_IF_FAILED("Could not set audio volume."); } |