Remove QCamera::Status

The enum is not really useful. Instead isActive() and error()
provide all the information required.

Change-Id: I2856c833745e79f74bb2a9d95f0ef65eafd24413
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>

1 files changed, 5 insertions, 12 deletions

diff --git a/tests/auto/integration/qcamerabackend/tst_qcamerabackend.cpp b/tests/auto/integration/qcamerabackend/tst_qcamerabackend.cpp
index 75e06a4a4..7bcc0dc72 100644
--- a/tests/auto/integration/qcamerabackend/tst_qcamerabackend.cpp
+++ b/tests/auto/integration/qcamerabackend/tst_qcamerabackend.cpp
@@ -164,10 +164,8 @@ void tst_QCameraBackend::testCameraStates()
 
     QSignalSpy errorSignal(&camera, SIGNAL(errorOccurred(QCamera::Error, const QString &)));
     QSignalSpy activeChangedSignal(&camera, SIGNAL(activeChanged(bool)));
-    QSignalSpy statusChangedSignal(&camera, SIGNAL(statusChanged(QCamera::Status)));
 
     QCOMPARE(camera.isActive(), false);
-    QCOMPARE(camera.status(), QCamera::InactiveStatus);
 
     // Camera should not startup with a null QCameraDevice as device
     camera.start();
@@ -182,14 +180,10 @@ void tst_QCameraBackend::testCameraStates()
     QCOMPARE(camera.isActive(), true);
     QTRY_COMPARE(activeChangedSignal.size(), 1);
     QCOMPARE(activeChangedSignal.last().first().value<bool>(), true);
-    QTRY_COMPARE(camera.status(), QCamera::ActiveStatus);
-    QCOMPARE(statusChangedSignal.last().first().value<QCamera::Status>(), QCamera::ActiveStatus);
 
     camera.stop();
     QCOMPARE(camera.isActive(), false);
     QCOMPARE(activeChangedSignal.last().first().value<bool>(), false);
-    QTRY_COMPARE(camera.status(), QCamera::InactiveStatus);
-    QCOMPARE(statusChangedSignal.last().first().value<QCamera::Status>(), QCamera::InactiveStatus);
 
     QCOMPARE(camera.errorString(), QString());
 }
@@ -212,7 +206,6 @@ void tst_QCameraBackend::testCameraStartParallel()
     camera2.start();
 
     QCOMPARE(camera1.isActive(), true);
-    QTRY_COMPARE(camera1.status(), QCamera::ActiveStatus);
     QCOMPARE(camera1.error(), QCamera::NoError);
     QCOMPARE(camera2.isActive(), true);
     QCOMPARE(camera2.error(), QCamera::NoError);
@@ -250,7 +243,7 @@ void tst_QCameraBackend::testCameraCapture()
     camera.start();
 
     QTRY_VERIFY(imageCapture.isReadyForCapture());
-    QCOMPARE(camera.status(), QCamera::ActiveStatus);
+    QVERIFY(camera.isActive());
     QCOMPARE(errorSignal.size(), 0);
 
     int id = imageCapture.captureToFile();
@@ -289,7 +282,7 @@ void tst_QCameraBackend::testCaptureToBuffer()
 
     camera.setActive(true);
 
-    QTRY_COMPARE(camera.status(), QCamera::ActiveStatus);
+    QTRY_VERIFY(camera.isActive());
 
     QSignalSpy capturedSignal(&imageCapture, SIGNAL(imageCaptured(int,QImage)));
     QSignalSpy imageAvailableSignal(&imageCapture, SIGNAL(imageAvailable(int,QVideoFrame)));
@@ -377,7 +370,7 @@ void tst_QCameraBackend::testExposureCompensation()
 
     //exposure compensation should be preserved during start
     camera.start();
-    QTRY_COMPARE(camera.status(), QCamera::ActiveStatus);
+    QTRY_VERIFY(camera.isActive());
 
     QCOMPARE(camera.exposureCompensation(), 1.0);
 
@@ -407,7 +400,7 @@ void tst_QCameraBackend::testExposureMode()
     }
 
     camera.stop();
-    QTRY_COMPARE(camera.status(), QCamera::InactiveStatus);
+    QTRY_VERIFY(!camera.isActive());
 
     // Auto
     camera.setExposureMode(QCamera::ExposureAuto);
@@ -472,7 +465,7 @@ void tst_QCameraBackend::testVideoRecording()
     }
     QTRY_VERIFY(camera->isActive());
 
-    QTRY_COMPARE(camera->status(), QCamera::ActiveStatus);
+    QTRY_VERIFY(camera->isActive());
     QTRY_COMPARE(recorder.status(), QMediaRecorder::StoppedStatus);
 
     for (int recordings = 0; recordings < 2; ++recordings) {