diff options
| author | Lars Knoll <lars.knoll@qt.io> | 2020-12-23 10:03:12 +0100 |
|---|---|---|
| committer | Lars Knoll <lars.knoll@qt.io> | 2021-01-21 19:55:52 +0000 |
| commit | 1175c3b5405015a27bc28d836e96582f02d3ce00 (patch) | |
| tree | 9d466f156414b29b4264acf748860283ec96c499 /tests/auto/unit/qmediaserviceprovider/mockserviceplugin3/mockserviceplugin3.cpp | |
| parent | 083d12af7be12a6076e1be779452909f37262a61 (diff) | |
Modernize code base
Run clang-tidy over the code base with some code modernization
options.
Change-Id: I9e74d1225bce333e74224e3b92c02c7e9884d8f5
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
Reviewed-by: Doris Verria <doris.verria@qt.io>
Diffstat (limited to 'tests/auto/unit/qmediaserviceprovider/mockserviceplugin3/mockserviceplugin3.cpp')
| -rw-r--r-- | tests/auto/unit/qmediaserviceprovider/mockserviceplugin3/mockserviceplugin3.cpp | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/tests/auto/unit/qmediaserviceprovider/mockserviceplugin3/mockserviceplugin3.cpp b/tests/auto/unit/qmediaserviceprovider/mockserviceplugin3/mockserviceplugin3.cpp index dc59e2108..5b29c6327 100644 --- a/tests/auto/unit/qmediaserviceprovider/mockserviceplugin3/mockserviceplugin3.cpp +++ b/tests/auto/unit/qmediaserviceprovider/mockserviceplugin3/mockserviceplugin3.cpp @@ -37,7 +37,7 @@ class MockServicePlugin3 : public QMediaServiceProviderPlugin, Q_INTERFACES(QMediaServiceSupportedDevicesInterface) Q_PLUGIN_METADATA(IID "org.qt-project.qt.mediaserviceproviderfactory/5.0" FILE "mockserviceplugin3.json") public: - QStringList keys() const + [[nodiscard]] QStringList keys() const { return QStringList() << QLatin1String(Q_MEDIASERVICE_MEDIAPLAYER) << @@ -45,20 +45,20 @@ public: QLatin1String(Q_MEDIASERVICE_CAMERA); } - QMediaService* create(QString const& key) + QMediaService* create(QString const& key) override { if (keys().contains(key)) return new MockMediaService("MockServicePlugin3"); else - return 0; + return nullptr; } - void release(QMediaService *service) + void release(QMediaService *service) override { delete service; } - QByteArray defaultDevice(const QByteArray &service) const + [[nodiscard]] QByteArray defaultDevice(const QByteArray &service) const override { if (service == Q_MEDIASERVICE_AUDIOSOURCE) return "audiosource1"; @@ -69,7 +69,7 @@ public: return QByteArray(); } - QList<QByteArray> devices(const QByteArray &service) const + [[nodiscard]] QList<QByteArray> devices(const QByteArray &service) const override { QList<QByteArray> res; if (service == Q_MEDIASERVICE_AUDIOSOURCE) @@ -81,7 +81,7 @@ public: return res; } - QString deviceDescription(const QByteArray &service, const QByteArray &device) + QString deviceDescription(const QByteArray &service, const QByteArray &device) override { if (devices(service).contains(device)) return QString(device)+" description"; |