1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
|
// Copyright (C) 2024 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only
#include <QtTest/QtTest>
#include <qmediaplayer.h>
#include <qvideoframe.h>
#include <qdebug.h>
#include "mediafileselector.h"
#include "testvideosink.h"
#include "private/qvideotexturehelper_p.h"
#include "private/qvideowindow_p.h"
#include <thread>
QT_USE_NAMESPACE
class tst_QVideoFrameBackend : public QObject
{
Q_OBJECT
public slots:
void initTestCase();
void init() { }
void cleanup() { }
private slots:
void testMediaFilesAreSupported();
void toImage_retainsThePreviousMappedState_data();
void toImage_retainsThePreviousMappedState();
void toImage_rendersUpdatedFrame_afterMappingInWriteModeAndModifying_data();
void toImage_rendersUpdatedFrame_afterMappingInWriteModeAndModifying();
void toImage_returnsImage_whenCalledFromSeparateThreadAndWhileRenderingToWindow();
private:
QVideoFrame createDefaultFrame() const;
QVideoFrame createMediaPlayerFrame() const;
using FrameCreator = decltype(&tst_QVideoFrameBackend::createDefaultFrame);
template <typename F>
void addMediaPlayerFrameTestData(F &&f);
private:
MaybeUrl m_oneRedFrameVideo = QUnexpect{};
MaybeUrl m_colorsVideo = QUnexpect{};
MediaFileSelector m_mediaSelector;
};
QVideoFrame tst_QVideoFrameBackend::createDefaultFrame() const
{
return QVideoFrame(QVideoFrameFormat(QSize(10, 20), QVideoFrameFormat::Format_ARGB8888));
}
QVideoFrame tst_QVideoFrameBackend::createMediaPlayerFrame() const
{
if (!m_oneRedFrameVideo)
return {};
TestVideoSink sink;
QMediaPlayer player;
player.setVideoOutput(&sink);
player.setSource(*m_oneRedFrameVideo);
player.play();
return sink.waitForFrame();
}
template <typename F>
void tst_QVideoFrameBackend::addMediaPlayerFrameTestData(F &&f)
{
if (!m_oneRedFrameVideo) {
qWarning() << "Skipping test data with mediaplayer as the source cannot be open."
"\nSee the test case 'testMediaFilesAreSupported' for details";
return;
}
f();
}
void tst_QVideoFrameBackend::initTestCase()
{
#ifdef Q_OS_ANDROID
qWarning() << "Skip media selection, QTBUG-118571";
return;
#endif
m_oneRedFrameVideo = m_mediaSelector.select("qrc:/testdata/one_red_frame.mp4");
m_colorsVideo = m_mediaSelector.select("qrc:/testdata/colors.mp4");
}
void tst_QVideoFrameBackend::testMediaFilesAreSupported()
{
#ifdef Q_OS_ANDROID
QSKIP("Skip test cases with mediaPlayerFrame on Android CI, because of QTBUG-118571");
#endif
QCOMPARE(m_mediaSelector.dumpErrors(), "");
}
void tst_QVideoFrameBackend::toImage_retainsThePreviousMappedState_data()
{
QTest::addColumn<FrameCreator>("frameCreator");
QTest::addColumn<QVideoFrame::MapMode>("initialMapMode");
// clang-format off
QTest::addRow("defaulFrame.notMapped") << &tst_QVideoFrameBackend::createDefaultFrame
<< QVideoFrame::NotMapped;
QTest::addRow("defaulFrame.readOnly") << &tst_QVideoFrameBackend::createDefaultFrame
<< QVideoFrame::ReadOnly;
addMediaPlayerFrameTestData([]()
{
QTest::addRow("mediaPlayerFrame.notMapped")
<< &tst_QVideoFrameBackend::createMediaPlayerFrame
<< QVideoFrame::NotMapped;
QTest::addRow("mediaPlayerFrame.readOnly")
<< &tst_QVideoFrameBackend::createMediaPlayerFrame
<< QVideoFrame::ReadOnly;
});
// clang-format on
}
void tst_QVideoFrameBackend::toImage_retainsThePreviousMappedState()
{
QFETCH(const FrameCreator, frameCreator);
QFETCH(const QVideoFrame::MapMode, initialMapMode);
const bool initiallyMapped = initialMapMode != QVideoFrame::NotMapped;
QVideoFrame frame = std::invoke(frameCreator, this);
QVERIFY(frame.isValid());
frame.map(initialMapMode);
QCOMPARE(frame.mapMode(), initialMapMode);
QImage image = frame.toImage();
QVERIFY(!image.isNull());
QCOMPARE(frame.mapMode(), initialMapMode);
QCOMPARE(frame.isMapped(), initiallyMapped);
}
void tst_QVideoFrameBackend::toImage_rendersUpdatedFrame_afterMappingInWriteModeAndModifying_data()
{
QTest::addColumn<FrameCreator>("frameCreator");
QTest::addColumn<QVideoFrame::MapMode>("mapMode");
// clang-format off
QTest::addRow("defaulFrame.writeOnly") << &tst_QVideoFrameBackend::createDefaultFrame
<< QVideoFrame::WriteOnly;
QTest::addRow("defaulFrame.readWrite") << &tst_QVideoFrameBackend::createDefaultFrame
<< QVideoFrame::ReadWrite;
addMediaPlayerFrameTestData([]()
{
QTest::addRow("mediaPlayerFrame.writeOnly")
<< &tst_QVideoFrameBackend::createMediaPlayerFrame
<< QVideoFrame::WriteOnly;
QTest::addRow("mediaPlayerFrame.readWrite")
<< &tst_QVideoFrameBackend::createMediaPlayerFrame
<< QVideoFrame::ReadWrite;
});
// clang-format on
}
void tst_QVideoFrameBackend::toImage_rendersUpdatedFrame_afterMappingInWriteModeAndModifying()
{
QFETCH(const FrameCreator, frameCreator);
QFETCH(const QVideoFrame::MapMode, mapMode);
// Arrange
QVideoFrame frame = std::invoke(frameCreator, this);
QVERIFY(frame.isValid());
QImage originalImage = frame.toImage();
QVERIFY(!originalImage.isNull());
// Act: map the frame in write mode and change the top level pixel
frame.map(mapMode);
QVERIFY(frame.isWritable());
QCOMPARE_NE(frame.pixelFormat(), QVideoFrameFormat::Format_Invalid);
const QVideoTextureHelper::TextureDescription *textureDescription =
QVideoTextureHelper::textureDescription(frame.pixelFormat());
QVERIFY(textureDescription);
uchar *firstPlaneBits = frame.bits(0);
QVERIFY(firstPlaneBits);
for (int i = 0; i < textureDescription->strideFactor; ++i)
firstPlaneBits[i] = ~firstPlaneBits[i];
frame.unmap();
// get an image from modified frame
QImage modifiedImage = frame.toImage();
// Assert
QVERIFY(!frame.isMapped());
QCOMPARE_NE(originalImage.pixel(0, 0), modifiedImage.pixel(0, 0));
QCOMPARE(originalImage.pixel(1, 0), modifiedImage.pixel(1, 0));
QCOMPARE(originalImage.pixel(1, 1), modifiedImage.pixel(1, 1));
}
void tst_QVideoFrameBackend::toImage_returnsImage_whenCalledFromSeparateThreadAndWhileRenderingToWindow()
{
if (qEnvironmentVariable("QTEST_ENVIRONMENT").toLower() == "ci") {
#ifdef Q_OS_MACOS
QSKIP("SKIP on macOS because of crash and error \"Failed to create QWindow::MetalSurface. Metal is not supported by any of the GPUs in this system.\"");
#elif defined(Q_OS_ANDROID)
QSKIP("SKIP initTestCase on CI, because of QTBUG-118571");
#endif
}
// Arrange
QVideoWindow window;
window.show();
QVERIFY(QTest::qWaitForWindowExposed(&window));
QMediaPlayer player;
player.setVideoOutput(&window);
const QVideoSink *sink = window.videoSink();
std::vector<QImage> images;
// act
connect(sink, &QVideoSink::videoFrameChanged, sink, [&](const QVideoFrame &frame) {
// Run toImage on separate thread to exercise special code path
QImage image;
auto t = std::thread([&] { image = frame.toImage(); });
t.join();
if (!image.isNull())
images.push_back(image);
});
// Arrange some more
player.setSource(*m_colorsVideo);
player.setLoops(10);
player.play();
// assert
QTRY_COMPARE_GE_WITH_TIMEOUT(images.size(), 10u, std::chrono::seconds(60) );
}
QTEST_MAIN(tst_QVideoFrameBackend)
#include "tst_qvideoframebackend.moc"
|
