diff options
| author | Edward Welbourne <edward.welbourne@qt.io> | 2024-01-22 14:31:08 +0100 |
|---|---|---|
| committer | Edward Welbourne <edward.welbourne@qt.io> | 2024-01-25 13:20:33 +0100 |
| commit | fc43e67e18ce68292fa36c20ac51394e2e1a2c45 (patch) | |
| tree | 0d9596a5d964792dcb05ad4995840900071927bd | |
| parent | 3b2121f02d9b92ee4968d5e3a13a7a411f558e4c (diff) | |
Ignore commented-out qt_internal_add...module() uses
A comment in a CMakeLists.txt file would produce a bogus entry in the
list of Qt modules that api-review-gen tried to scan the CMake files
for.
Change-Id: I0c22bf691ac6e7026f85502164b3e6f6b5c9f4bb
Reviewed-by: Dimitrios Apostolou <jimis@qt.io>
| -rwxr-xr-x | scripts/api-review/api-review-gen | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/api-review/api-review-gen b/scripts/api-review/api-review-gen index 339b1f71..0bfda3d2 100755 --- a/scripts/api-review/api-review-gen +++ b/scripts/api-review/api-review-gen @@ -114,7 +114,7 @@ modules () { # Scan for CMakeLists.txt files defining non-Private, non-plugin Qt modules: # Known variants on qt_internal_add_*_module: protobuf, qml find src -type d -name .git -prune -o -type f -name CMakeLists.txt -print \ - | xargs grep 'qt_internal_add\(_[a-z][a-z]*\)\?_module(' \ + | xargs grep '^[^#]*qt_internal_add\(_[a-z][a-z]*\)\?_module(' \ | grep -wv 'qt_internal_add.*module([A-Za-z0-9]*Private' \ | grep -wv 'qt_internal_add.*module([A-Za-z0-9]*plugin' \ | sed -e 's/: *qt_internal_add.*_module(/ /' \ |