diff options
| author | Rohan McGovern <rohan.mcgovern@nokia.com> | 2012-10-25 14:54:00 +1000 |
|---|---|---|
| committer | The Qt Project <gerrit-noreply@qt-project.org> | 2012-10-25 23:38:23 +0200 |
| commit | 8170a57d5b6a9683799bd0f65776ee42860f869e (patch) | |
| tree | 9b4a503e17e08b4682f1b4f8f78bd20292389b3e /scripts/qt | |
| parent | ece3d8ba2a29d947c97119c56911b7238e26ba47 (diff) | |
qt_update_submodules: fixed double quoting of gerrit comments
QtQA::Gerrit::review already takes care of quoting internally, so we no
longer need to do it explicitly here. This was resulting in leading and
trailing " characters in the posted comments.
Change-Id: I7a41961161183ee7a9d1a806fac43bbc2d5dbb7a
Reviewed-by: Janne Anttila <janne.anttila@digia.com>
Reviewed-by: Samuli Piippo <samuli.piippo@digia.com>
Reviewed-by: Toby Tomkins <tjtomkins@gmail.com>
Diffstat (limited to 'scripts/qt')
| -rwxr-xr-x | scripts/qt/qt_update_submodules.pl | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/scripts/qt/qt_update_submodules.pl b/scripts/qt/qt_update_submodules.pl index 0e3d9a79..7ae50235 100755 --- a/scripts/qt/qt_update_submodules.pl +++ b/scripts/qt/qt_update_submodules.pl @@ -370,14 +370,6 @@ sub post_git_submodule_summary # Indent all text by two spaces, causing gerrit to consider it preformatted $summary = q{ }.join(qq{\n }, split( qq{\n}, $summary ) ); - # Quote the text for posting to gerrit. - # gerrit's quoting is quite bizarre. This quoting should be unnecessary - # since we are passing this as a separate argument anyway, but gerrit seems to - # join all the arguments and parse them again, requiring double quoting. - $summary =~ s{"}{}g; - $summary = qq{"$summary"}; - - my %gerrit = $self->gerrit_giturl_split( $qt_git_url ); if (!$gerrit{ host }) { # not gerrit, nothing to be done |