diff options
| author | Ville Voutilainen <ville.voutilainen@qt.io> | 2021-09-03 09:23:52 +0300 |
|---|---|---|
| committer | Ville Voutilainen <ville.voutilainen@qt.io> | 2021-10-28 08:38:44 +0000 |
| commit | b32ae49fbfdb1b0a07ec4f0247a50e85ebea608c (patch) | |
| tree | 20e23a9c9a73a9b54478a348c754cfb81f677993 /tests/postbuild | |
| parent | 7c25f17cb36bcaf28f17b937ce4507cd38796681 (diff) | |
Blacklist QBindingStatus and QQmlPrivate::AOTCompiledFunction
It's a bit unfortunate that we need this. QBindingStatus is not used in a way
that would require its size to never change, it has had data members added to
it. The BIC test doesn't have a way to blacklist it in a way that would just
keep its member offsets stable. We should eventually rewrite all of this
to use libabigail, and add support for being able to say that a class is bic-stable
as long as its existing data members don't move.
Pick-to: master
Change-Id: I97b13236249a76dc6ab24037d4d8d29611356f40
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Diffstat (limited to 'tests/postbuild')
| -rw-r--r-- | tests/postbuild/bic/tst_bic.cpp | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/tests/postbuild/bic/tst_bic.cpp b/tests/postbuild/bic/tst_bic.cpp index 8ce9cb13..c768e442 100644 --- a/tests/postbuild/bic/tst_bic.cpp +++ b/tests/postbuild/bic/tst_bic.cpp @@ -321,6 +321,10 @@ tst_Bic::tst_Bic(const char *appFilePath) bic.addBlacklistedClass(QLatin1String("QQmlPrivate::RegisterSingletonType")); bic.addBlacklistedClass(QLatin1String("QQmlPrivate::RegisterInterface")); + /* this class is not used in a way that requires its size to be stable, + but it has grown between releases */ + bic.addBlacklistedClass(QLatin1String("QQmlPrivate::AOTCompiledFunction")); + /* according to Thiago this is a false positive */ bic.addBlacklistedClass(QLatin1String("QLoggingCategory::AtomicBools")); bic.addBlacklistedClass(QLatin1String("QOperatingSystemVersion::HighSierra")); @@ -335,6 +339,10 @@ tst_Bic::tst_Bic(const char *appFilePath) bic.addBlacklistedClass(QLatin1String("QOpenGLFunctions_3_0_CoreBackend")); bic.addBlacklistedClass(QLatin1String("QOpenGLFunctions_3_3_CoreBackend")); bic.addBlacklistedClass(QLatin1String("QOpenGLFunctions_4_3_CoreBackend")); + + /* this class is not used in a way that requires its size to be stable, + but it has grown between releases */ + bic.addBlacklistedClass(QLatin1String("QBindingStatus")); } void tst_Bic::initTestCase() |