| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Change-Id: I394be90ae43dc9a0b8aa6fed9d5368b2e58d89b1
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: If2f73e03f8b9d9505bee989776ce393bd1337376
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
|
|
| |
Indicate that the SOA and real NS records may not match what's in this file.
Change-Id: I6979d02a7395405cbf23fffd17c99657b698f8df
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
|
|
|
|
|
|
|
|
| |
Will need for QDnsLookup features.
Task-number: QTQAINFRA-6269
Change-Id: I455fe22ef4ad4b2f9b01fffd17c770302d4787c3
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
|
|
|
|
|
|
|
|
| |
Explicit termination is necessary after the cancellation of an
asyncio.subprocess.Process.wait().
Change-Id: I205352008f492cdcd5a741d3ae83570ff5cb7d0d
Reviewed-by: Daniel Smith <daniel.smith@qt.io>
|
|
|
|
|
|
|
| |
Match-statements are error-prone. Use simple if-statements instead.
Change-Id: Ib287ade80187585142b2aa7ab39ea5c7bf3605dd
Reviewed-by: Daniel Smith <daniel.smith@qt.io>
|
|
|
|
|
| |
Change-Id: I9cc385af3846c4f9819ebfa70b010f3e566b0e1e
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Current behavior of picking to the first-found parent in a
relation chain can sometimes cause issues with broken dependencies.
This change modifies the behavior to always wait for the expected
parent to be picked before picking the child. If the wait times out,
the bot will fall back to the old behavior of walking the chain
to find the nearest suitable parent.
Fixes: QTQAINFRA-6167
Change-Id: I3074988b10e4efad7307770ef5ac218bb39d5066
Reviewed-by: Daniel Smith <daniel.smith@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch introduces /jiracloser/fixversion endpoint which
calculates the JIRA FixVersion for a gerrit change. The
The endpoint accepts only the unique gerrit change number in the
"change" query parameter. Gerrit Change Ids are not supported.
The endpoint responds with 200 status code and a JSON body of
one or more JIRA fixVersions.
Change-Id: Iddaf3b6bfb4527c1d384d77b5ee8ff8794fd0cb3
Reviewed-by: Daniel Smith <daniel.smith@qt.io>
Reviewed-by: Audun Sutterud <audun.sutterud@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Non-numeric branches cannot follow a logical order for cherry-
picking. This patch fixes a bug where a crash would occur
if the source branch was non-numeric, but the target branch
was numeric/dev/master. The waterfall logic will now correctly
return a flat list of targets when either source or target branches
are non-compliant.
Fixes: QTQAINFRA-6241
Change-Id: If228ed0a49e566873b9c2677ca3c675b698fc669
Reviewed-by: Daniel Smith <daniel.smith@qt.io>
|
|
|
|
|
| |
Change-Id: I26f63f90c7a93cb5df59abfb296df41704a59af0
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
| |
Follows up on commit 3abeab87a0cbaaba4a6897dba4c7fcba241adc2a adding
the new parameter to the second call to print_failed_test(), which has
been broken - leading to TypeError when hit - since that commit.
Pick-to: master
Change-Id: Ic460b406bbea7a5fe8034c39d1d52ea8955c43e5
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
|
|
|
|
| |
Change-Id: I52876059594b2541d97e09599febb9b4033ab8af
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: I2f5b24154aa4bfb251bf28abc93510deeb202e0e
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using match-statements to catch errors can be unsafe. If there are
multiple error-types, a match-statement targeted at the wrong one can
let errors fall through. A bug like this was fixed recently. This commit
attempts to guard against cases like that by simplifying the error
hierarchy, removing all types but one, and by using simpler
if-statements instead of match-statements where this makes sense.
Change-Id: I4b4307b9b94d98833cfb26ac86095f551e918470
Reviewed-by: Daniel Smith <daniel.smith@qt.io>
|
|
|
|
|
|
|
|
| |
A function returned the wrong error type, causing match-statements to
fall through and errors to go uncaught.
Change-Id: Ic71b69fca3916d61c3ed6def2cddefc350d511c7
Reviewed-by: Daniel Smith <daniel.smith@qt.io>
|
|
|
|
|
| |
Change-Id: I2afc85d235bae46f3d089cbb943aa553afb25a24
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: Ifc6a2a9944402032befb01005d78d94e7d48e0d0
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
|
|
|
| |
- from .bin to .app
Pick-to: master
Change-Id: I682618f5eceefd069709c62f32dd691ceeb3d3b2
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
|
|
|
|
|
| |
Pick-to: master
Change-Id: I255d45985e91bb93e88e7affee926e58460ae77e
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
|
|
|
|
|
| |
Change-Id: Ic794e9f63817d2dc00b7e906d6e8e4863da2d363
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
|
|
|
| |
QtTest is by design ABI-unstable nowadays.
Task-number: QTBUG-124181
Change-Id: I1b15e7f9c93659ed5aae6eef0fc267c422631077
Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>
|
|
|
|
|
| |
Change-Id: I368d3caa4b29f871c949e8bcc6ce731a5b404f52
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: I182b2cbb4d184b7fd7bab14e43d9da2c338257df
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
|
|
| |
Pick-to: master
Task-number: PYSIDE-2655
Change-Id: Id7bbd2159931b684e7c125399e5d623bbeb7855e
Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io>
|
|
|
|
|
| |
Change-Id: Iaf06f61749736511021cdf4ec381a89409a54af9
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: I1bcb14a771dfeaac546b2e60bfbba797d23cb53c
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: I99b4c47b10b49e81b60613b4970c949b1fdbace9
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: I51bb93b53e1d55ae4e417bbfe32971f345494dc8
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
| |
We can use fixup! commits for the former; for the latter, we need to
move the old branch aside, only deleting it when we're finished, so
that we can look up each commit's prior Change-Id as we record it.
Fixes: QTQAINFRA-5757
Change-Id: I3d674133b4c2e27357ca89f9b72ce2b15bb3ea9a
Reviewed-by: Daniel Smith <daniel.smith@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
On a follow-up to update a review, if the module had no changes since
the prior review, api-review-gen would delete the existing review
branch. Don't do that; only delete if the branch was newly made.
Report a revised completion message in the case that omits this.
Change-Id: I8a50a1cd37f77ccc9961a0575c47a706c0ce6cae
Reviewed-by: Dimitrios Apostolou <jimis@qt.io>
Reviewed-by: Daniel Smith <daniel.smith@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
When resetboring has more than one (non-trivial) line in the old code
that could be a match to a new line, prefer an exact match if present
or one with the same indent otherwise. It's still crude, but slightly
less so than just taking the first - and marginally reduces noise.
Change-Id: I913fb51363cf81efea37ac0a24c698bfa3572200
Reviewed-by: Daniel Smith <daniel.smith@qt.io>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some repos are in submit-only mode and do not use the CI.
This patch adds support for using the submit command instead,
based on configuration in the config.json or environment variables.
This config is only made available per-repo, and cannot be used
to make a specific branch submit-only.
Using configuration over deductive or fallback logic is intended to
be more explicit to reduce security concerns of unreviewed code
being hard-submitted in unapproved repos.
Task-number: QTQAINFRA-6157
Change-Id: If2d0e538369c470e0753d311e183ea736981b63c
Reviewed-by: Daniel Smith <daniel.smith@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Due to how the jira closer matches fix version based on raw
version strings, it was incorrectly checking gerrit for the
existence of tqtc/lts- and lts- prefixed branches as the raw
branch without the prefix. This caused the bot to believe that
the target branch was not yet created, and assign the wrong fix
version to the jira issue.
Fixes: QTQAINFRA-6064
Change-Id: If3879ba0a696eca613432ee01d633bb347accc99
Reviewed-by: Daniel Smith <daniel.smith@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The jira closer bot performs a check on branching date
to determine if a given change merged to a branch before
a given branching date. This is done with MomentJS, and a
check which validates that cached datetime is a Moment object
fails due to improperly populating the local cache from database
upon startup. This ultimately leads to the wrong version being chosen
when a change is merged to a branch after the branching date.
Fixes: QTQAINFRA-6064
Change-Id: I1ef32f3cae9ee5bc38c2b5b7f5b3a77adc4f668e
Reviewed-by: Daniel Smith <daniel.smith@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This plugin will post a welcome message to new contributors when they
submit their first patchset to The Qt Project, also adding
a random selection of four users from a buddy group of reviewers
that have volunteered to help new contributors.
This patch also includes some minor fixups found in related code
discovered during development of this plugin.
Fixes: QTQAINFRA-5973
Change-Id: I1762a1047aa6c72e30b60c7ee5d277cee5750ade
Reviewed-by: Daniel Smith <daniel.smith@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change addresses a bug where if the immediate branch
targets are on different major branches, the target for the
higher major branch can be considered a child of an older major
branch. This occurs when the one of the targets is a release branch
for 6.x.x and the other is 5.x where the feature branch of 5.x is
greater than that of the 6.x target.
Fixes: QTQAINFRA-6200
Change-Id: Id061740c70bd6215ddb03aa74cf4133bcb074c76
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
|
|
|
|
|
|
|
| |
Fixes: QTQAINFRA-6187
Change-Id: I910e392cbeb8a681b1e717e1652b7584bc07529c
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
|
|
|
|
|
|
|
|
| |
The test depends on the default configuration file. This causes issues
when modifying the configuration file for testing purposes.
Change-Id: I0017b810f1d735b86934714a8d946729557988ff
Reviewed-by: Daniel Smith <daniel.smith@qt.io>
|
|
|
|
|
| |
Change-Id: Ib2d3e61edc18909a67789d4815f8abba4ab3c79c
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: I1c6a6617d8154546e3d334d26b501537b725037b
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: I43c62f5d0ed28c8dd225891b39186ba0e8ca544d
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: Ide3257ef9e143fc8134014eea8e22728a0480cdb
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: I17c00f9f696aaa648027a57af6e66fcef3d4c6de
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: I39797c221d8b4ffbb30e1f144e6613b739f2e47c
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We should use the production instance of the Cherrypick-bot.
We should not hardcode login credentials. These should always be
selected.
The various parameters in the Git URL should be configured through
~/.ssh/config, as specified in the README file.
Change-Id: I8b4f37b3a8004c278ce063d416cef43ea006fbec
Reviewed-by: Daniel Smith <daniel.smith@qt.io>
|
|
|
|
|
| |
Change-Id: If2455258650cebf73f01ab8ee7ea9a737413576b
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: Ib9d2c42a6c5a56d97ded8bd53d735bb18c6cb084
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: I3eae647289084fdd413da3b29eda721761d522bb
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The 6.7 review for QSql included a file where all that had changed was
some s/Type& name/Type &name/ fixes. This arose because there was no
other change to the lines in question and the initial scan of the new
lines thus concluded nothing boring had changed, so there was no point
recording the line for comparison to old lines. Retain at least one
representation of each non-trivial line to match, so that we do catch
cases where the only boring change is to spacing. Package the
non-trivial line check (previously used when reversing strip) in a
function since we're reusing it; and include backslash in its list of
trivia, since that arises in trivial lines of a macro body.
Change-Id: I10443bd1494932696f176f90b663035a772ca805
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
|