summaryrefslogtreecommitdiffstats
path: root/tests/auto/declarative
diff options
context:
space:
mode:
authorNils Jeisecke <jeisecke@saltation.de>2014-02-28 12:53:43 +0100
committerNils Jeisecke <jeisecke@saltation.de>2014-09-10 18:26:05 +0200
commitf09b12cea1143f1b2763064bb0d3e6592081de2b (patch)
tree3589e5aaf0591cda2a9c15f04faf6cf9a73dc736 /tests/auto/declarative
parent8898cabfbf84a126257cf537b8172e799501682c (diff)
Make sure that the itemview's count property is reliable
This fixes a missing countChanged signal when model changes happen while the itemview component is not completely initialized. Task-number: QTBUG-37115 Change-Id: I20c749b9e521b0292186adbecd09e1d362520881 Reviewed-by: Alan Alpert <aalpert@blackberry.com>
Diffstat (limited to 'tests/auto/declarative')
-rw-r--r--tests/auto/declarative/qdeclarativelistview/data/qtbug37115.qml71
-rw-r--r--tests/auto/declarative/qdeclarativelistview/tst_qdeclarativelistview.cpp48
2 files changed, 119 insertions, 0 deletions
diff --git a/tests/auto/declarative/qdeclarativelistview/data/qtbug37115.qml b/tests/auto/declarative/qdeclarativelistview/data/qtbug37115.qml
new file mode 100644
index 00000000..d6f86fca
--- /dev/null
+++ b/tests/auto/declarative/qdeclarativelistview/data/qtbug37115.qml
@@ -0,0 +1,71 @@
+/****************************************************************************
+**
+** Copyright (C) 2013 Digia Plc and/or its subsidiary(-ies).
+** Contact: http://www.qt-project.org/legal
+**
+** This file is part of the test suite of the Qt Toolkit.
+**
+** $QT_BEGIN_LICENSE:LGPL$
+** Commercial License Usage
+** Licensees holding valid commercial Qt licenses may use this file in
+** accordance with the commercial license agreement provided with the
+** Software or, alternatively, in accordance with the terms contained in
+** a written agreement between you and Digia. For licensing terms and
+** conditions see http://qt.digia.com/licensing. For further information
+** use the contact form at http://qt.digia.com/contact-us.
+**
+** GNU Lesser General Public License Usage
+** Alternatively, this file may be used under the terms of the GNU Lesser
+** General Public License version 2.1 as published by the Free Software
+** Foundation and appearing in the file LICENSE.LGPL included in the
+** packaging of this file. Please review the following information to
+** ensure the GNU Lesser General Public License version 2.1 requirements
+** will be met: http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
+**
+** In addition, as a special exception, Digia gives you certain additional
+** rights. These rights are described in the Digia Qt LGPL Exception
+** version 1.1, included in the file LGPL_EXCEPTION.txt in this package.
+**
+** GNU General Public License Usage
+** Alternatively, this file may be used under the terms of the GNU
+** General Public License version 3.0 as published by the Free Software
+** Foundation and appearing in the file LICENSE.GPL included in the
+** packaging of this file. Please review the following information to
+** ensure the GNU General Public License version 3.0 requirements will be
+** met: http://www.gnu.org/copyleft/gpl.html.
+**
+**
+** $QT_END_LICENSE$
+**
+****************************************************************************/
+import QtQuick 1.1
+import org.test.models 1.0
+
+Rectangle {
+
+ width: 360
+ height: 360
+
+ ListModel {
+ id: m
+ ListElement { filter: "X*" }
+ }
+
+ Repeater {
+ model: m
+ delegate: Column {
+ property string mfilter: model.filter
+ ListView {
+ objectName: "listview"
+ property int countCopy: count // without the fix this won't get updated correctly due to missing countChanged notifications
+ width: 100; height: 100
+ TestFilterModel {
+ id: fm
+ filter: mfilter
+ }
+ model: fm
+ delegate: Text { text: "entry " + model.display }
+ }
+ }
+ }
+}
diff --git a/tests/auto/declarative/qdeclarativelistview/tst_qdeclarativelistview.cpp b/tests/auto/declarative/qdeclarativelistview/tst_qdeclarativelistview.cpp
index eb0e0948..f2f39102 100644
--- a/tests/auto/declarative/qdeclarativelistview/tst_qdeclarativelistview.cpp
+++ b/tests/auto/declarative/qdeclarativelistview/tst_qdeclarativelistview.cpp
@@ -60,6 +60,8 @@ public:
tst_QDeclarativeListView();
private slots:
+ void initTestCase();
+
// Test both QListModelInterface and QAbstractItemModel model types
void qListModelInterface_items();
void qAbstractItemModel_items();
@@ -116,6 +118,7 @@ private slots:
void test_mirroring();
void orientationChange();
void contentPosJump();
+ void QTBUG_37115();
private:
template <class T> void items();
@@ -350,10 +353,41 @@ private:
QList<QPair<QString,QString> > list;
};
+class TestFilterModel : public QSortFilterProxyModel
+{
+ Q_OBJECT
+ Q_PROPERTY(QString filter READ filter WRITE setFilter NOTIFY filterChanged)
+ QString m_filter;
+
+public:
+ explicit TestFilterModel(QObject *parent = 0) : QSortFilterProxyModel(parent)
+ {
+ setSourceModel(new QStringListModel(QStringList() << "AA" << "BB" << "CC", this));
+ }
+
+ QString filter() const { return m_filter; }
+ void setFilter(const QString &filter)
+ {
+ if (m_filter != filter) {
+ m_filter = filter;
+ setFilterWildcard(m_filter);
+ emit filterChanged();
+ }
+ }
+
+signals:
+ void filterChanged();
+};
+
tst_QDeclarativeListView::tst_QDeclarativeListView()
{
}
+void tst_QDeclarativeListView::initTestCase()
+{
+ qmlRegisterType<TestFilterModel>("org.test.models", 1, 0, "TestFilterModel");
+}
+
template <class T>
void tst_QDeclarativeListView::items()
{
@@ -2721,6 +2755,20 @@ void tst_QDeclarativeListView::contentPosJump()
delete canvas;
}
+void tst_QDeclarativeListView::QTBUG_37115()
+{
+ QDeclarativeView *canvas = createView();
+
+ canvas->setSource(QUrl::fromLocalFile(SRCDIR "/data/qtbug37115.qml"));
+ qApp->processEvents();
+
+ QDeclarativeListView *listview = findItem<QDeclarativeListView>(canvas->rootObject(), "listview");
+ QTRY_VERIFY(listview != 0);
+ QTRY_COMPARE(listview->property("countCopy").toInt(), 0);
+
+ delete canvas;
+}
+
void tst_QDeclarativeListView::qListModelInterface_items()
{
items<TestModel>();