path: root/src/imports/controls/controls.pri
diff options
authorJ-P Nurmi <jpnurmi@qt.io>2017-10-31 14:30:39 +0100
committerJ-P Nurmi <jpnurmi@qt.io>2017-11-02 09:12:14 +0000
commit0504150e4a0a3874a8e431af351277f7342dac95 (patch)
tree1fc32d24f40763affcec66b03bcf59e04c9ec70b /src/imports/controls/controls.pri
parent6f89cf6370daa443169d24ce45a925000b6e0248 (diff)
Default: merge CheckIndicator back to CheckBox & CheckDelegate
The internal CheckIndicator helper was introduced together with CheckDelegate in 1acb34a, because we naturally wanted to share the indicator instead of duplicating it. This change is controversial, because it leads to duplicate code, but keeping the indicator definitions inline is clearly faster. This is not seen as a huge problem for the Default style, because the indicator is not too complicated. Basically, this fixes a ~5% performance regression introduced by 1acb34a. Before: running: qmlbench/benchmarks/auto/creation/quick.controls2/delegates_checkbox.qml [...] Average: 72.8 frames; using samples; MedianAll=73; StdDev=1.48324, CoV=0.0203742 After: running: qmlbench/benchmarks/auto/creation/quick.controls2/delegates_checkbox.qml [...] Average: 77 frames; using samples; MedianAll=77; StdDev=1.41421, CoV=0.0183664 Change-Id: Ibee0e29e83a64ee4a6a772a90b1784a9c8c715bb Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Diffstat (limited to 'src/imports/controls/controls.pri')
1 files changed, 0 insertions, 1 deletions
diff --git a/src/imports/controls/controls.pri b/src/imports/controls/controls.pri
index 56c7a8ee..0bdf0e52 100644
--- a/src/imports/controls/controls.pri
+++ b/src/imports/controls/controls.pri
@@ -22,7 +22,6 @@ QML_CONTROLS = \
$$PWD/ButtonGroup.qml \
$$PWD/CheckBox.qml \
$$PWD/CheckDelegate.qml \
- $$PWD/CheckIndicator.qml \
$$PWD/ComboBox.qml \
$$PWD/Container.qml \
$$PWD/Control.qml \