aboutsummaryrefslogtreecommitdiffstats
path: root/src/imports/controls/imagine
diff options
context:
space:
mode:
authorFabian Kosmale <fabian.kosmale@qt.io>2019-06-11 11:40:31 +0200
committerFabian Kosmale <fabian.kosmale@qt.io>2019-06-11 09:44:10 +0000
commit467aa59a88d381dddb0e5b797c73f205d0b275c9 (patch)
tree7f9db5135d40cfdd18c3486dbe1f8fb44c9c9619 /src/imports/controls/imagine
parentd7b2f407cff40b75423c93bef6f5f2255747c4ee (diff)
Qualify unqualified id lookup in controls
This is a preparation for https://codereview.qt-project.org/c/qt/qtdeclarative/+/259561 and also avoids walking up the contexts Change-Id: I9f016b7346db088dfe1519924c9770e486b46ec9 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Diffstat (limited to 'src/imports/controls/imagine')
-rw-r--r--src/imports/controls/imagine/RadioButton.qml2
-rw-r--r--src/imports/controls/imagine/ScrollBar.qml6
-rw-r--r--src/imports/controls/imagine/ScrollIndicator.qml4
-rw-r--r--src/imports/controls/imagine/Switch.qml2
-rw-r--r--src/imports/controls/imagine/SwitchDelegate.qml2
-rw-r--r--src/imports/controls/imagine/Tumbler.qml8
6 files changed, 12 insertions, 12 deletions
diff --git a/src/imports/controls/imagine/RadioButton.qml b/src/imports/controls/imagine/RadioButton.qml
index d431695f..a50bc127 100644
--- a/src/imports/controls/imagine/RadioButton.qml
+++ b/src/imports/controls/imagine/RadioButton.qml
@@ -61,7 +61,7 @@ T.RadioButton {
bottomInset: background ? -background.bottomInset || 0 : 0
indicator: Image {
- x: text ? (control.mirrored ? control.width - width - control.rightPadding : control.leftPadding) : control.leftPadding + (control.availableWidth - width) / 2
+ x: control.text ? (control.mirrored ? control.width - width - control.rightPadding : control.leftPadding) : control.leftPadding + (control.availableWidth - width) / 2
y: control.topPadding + (control.availableHeight - height) / 2
source: Imagine.url + "radiobutton-indicator"
diff --git a/src/imports/controls/imagine/ScrollBar.qml b/src/imports/controls/imagine/ScrollBar.qml
index 1b21becb..68772e12 100644
--- a/src/imports/controls/imagine/ScrollBar.qml
+++ b/src/imports/controls/imagine/ScrollBar.qml
@@ -105,14 +105,14 @@ T.ScrollBar {
transitions: [
Transition {
to: "active"
- NumberAnimation { targets: [contentItem, background]; property: "opacity"; to: 1.0 }
+ NumberAnimation { targets: [control.contentItem, control.background]; property: "opacity"; to: 1.0 }
},
Transition {
from: "active"
SequentialAnimation {
- PropertyAction{ targets: [contentItem, background]; property: "opacity"; value: 1.0 }
+ PropertyAction{ targets: [control.contentItem, control.background]; property: "opacity"; value: 1.0 }
PauseAnimation { duration: 3000 }
- NumberAnimation { targets: [contentItem, background]; property: "opacity"; to: 0.0 }
+ NumberAnimation { targets: [control.contentItem, control.background]; property: "opacity"; to: 0.0 }
}
}
]
diff --git a/src/imports/controls/imagine/ScrollIndicator.qml b/src/imports/controls/imagine/ScrollIndicator.qml
index 2fd578ef..896cd876 100644
--- a/src/imports/controls/imagine/ScrollIndicator.qml
+++ b/src/imports/controls/imagine/ScrollIndicator.qml
@@ -98,13 +98,13 @@ T.ScrollIndicator {
transitions: [
Transition {
to: "active"
- NumberAnimation { targets: [contentItem, background]; property: "opacity"; to: 1.0 }
+ NumberAnimation { targets: [contentItem, control.background]; property: "opacity"; to: 1.0 }
},
Transition {
from: "active"
SequentialAnimation {
PauseAnimation { duration: 5000 }
- NumberAnimation { targets: [contentItem, background]; property: "opacity"; to: 0.0 }
+ NumberAnimation { targets: [contentItem, control.background]; property: "opacity"; to: 0.0 }
}
}
]
diff --git a/src/imports/controls/imagine/Switch.qml b/src/imports/controls/imagine/Switch.qml
index 7d1f3a2a..50b407ac 100644
--- a/src/imports/controls/imagine/Switch.qml
+++ b/src/imports/controls/imagine/Switch.qml
@@ -61,7 +61,7 @@ T.Switch {
bottomInset: background ? -background.bottomInset || 0 : 0
indicator: NinePatchImage {
- x: text ? (control.mirrored ? control.width - width - control.rightPadding : control.leftPadding) : control.leftPadding + (control.availableWidth - width) / 2
+ x: control.text ? (control.mirrored ? control.width - width - control.rightPadding : control.leftPadding) : control.leftPadding + (control.availableWidth - width) / 2
y: control.topPadding + (control.availableHeight - height) / 2
width: Math.max(implicitWidth, handle.leftPadding && handle.rightPadding ? handle.implicitWidth : 2 * handle.implicitWidth)
height: Math.max(implicitHeight, handle.implicitHeight)
diff --git a/src/imports/controls/imagine/SwitchDelegate.qml b/src/imports/controls/imagine/SwitchDelegate.qml
index e95023fb..73e5aac0 100644
--- a/src/imports/controls/imagine/SwitchDelegate.qml
+++ b/src/imports/controls/imagine/SwitchDelegate.qml
@@ -67,7 +67,7 @@ T.SwitchDelegate {
icon.color: control.palette.text
indicator: NinePatchImage {
- x: text ? (control.mirrored ? control.leftPadding : control.width - width - control.rightPadding) : control.leftPadding + (control.availableWidth - width) / 2
+ x: control.text ? (control.mirrored ? control.leftPadding : control.width - width - control.rightPadding) : control.leftPadding + (control.availableWidth - width) / 2
y: control.topPadding + (control.availableHeight - height) / 2
width: Math.max(implicitWidth, handle.leftPadding && handle.rightPadding ? handle.implicitWidth : 2 * handle.implicitWidth)
height: Math.max(implicitHeight, handle.implicitHeight)
diff --git a/src/imports/controls/imagine/Tumbler.qml b/src/imports/controls/imagine/Tumbler.qml
index d49966b0..12025cc5 100644
--- a/src/imports/controls/imagine/Tumbler.qml
+++ b/src/imports/controls/imagine/Tumbler.qml
@@ -69,11 +69,11 @@ T.Tumbler {
model: control.model
delegate: control.delegate
path: Path {
- startX: contentItem.width / 2
- startY: -contentItem.delegateHeight / 2
+ startX: control.contentItem.width / 2
+ startY: -control.contentItem.delegateHeight / 2
PathLine {
- x: contentItem.width / 2
- y: (control.visibleItemCount + 1) * contentItem.delegateHeight - contentItem.delegateHeight / 2
+ x: control.contentItem.width / 2
+ y: (control.visibleItemCount + 1) * control.contentItem.delegateHeight - control.contentItem.delegateHeight / 2
}
}