aboutsummaryrefslogtreecommitdiffstats
path: root/src/imports/controls/material/MenuItem.qml
diff options
context:
space:
mode:
authorJ-P Nurmi <jpnurmi@qt.io>2016-07-14 16:38:56 +0200
committerJ-P Nurmi <jpnurmi@qt.io>2016-07-14 19:17:30 +0000
commit2ce7e45532c0defb73220fc3e53ad9cde01636c6 (patch)
tree41afb9bd0e502b8fd737c442cd7e6f5e841be4c5 /src/imports/controls/material/MenuItem.qml
parent2e19d8eafa9aeb75a09f2f54f8da272acd9700be (diff)
Material: revert "trigger ripple effects on release" for MenuItem
MenuItem looks very similar to ItemDelegate, so I unthoughtfully made both trigger ripples on release. However, Menus typically close when menu items are triggered, so triggering ripples on release means the ripples are never shown. For what it's worth, Android 6 also shows ripple effects on release for list items, and on press for menu items. Task-number: QTBUG-54764 Change-Id: I3bc362dbe4b890908ecb38a19edc804a5deb31e6 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Diffstat (limited to 'src/imports/controls/material/MenuItem.qml')
-rw-r--r--src/imports/controls/material/MenuItem.qml1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/imports/controls/material/MenuItem.qml b/src/imports/controls/material/MenuItem.qml
index 63379e84..4f221f2c 100644
--- a/src/imports/controls/material/MenuItem.qml
+++ b/src/imports/controls/material/MenuItem.qml
@@ -84,7 +84,6 @@ T.MenuItem {
height: parent.height
clip: visible
- trigger: Ripple.Release
pressed: control.pressed
anchor: control
active: control.down || control.visualFocus || control.hovered