Fix dereference after null check

CID 182271 (#1 of 1): Dereference after null check (FORWARD_NULL)
5. var_deref_model: Passing null pointer item to setParentItem, which dereferences it.

Coverity-Id: 182271
Change-Id: Ifd7dcf58b58271c9b5e2f461f68153aaed4b97a2
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

1 files changed, 4 insertions, 1 deletions

diff --git a/src/quicktemplates2/qquickmenubar.cpp b/src/quicktemplates2/qquickmenubar.cpp
index f44edbd0..de3cc9a7 100644
--- a/src/quicktemplates2/qquickmenubar.cpp
+++ b/src/quicktemplates2/qquickmenubar.cpp
@@ -100,8 +100,11 @@ QQuickItem *QQuickMenuBarPrivate::beginCreateItem()
 
     QObject *object = delegate->beginCreate(context);
     QQuickItem *item = qobject_cast<QQuickItem *>(object);
-    if (!item)
+    if (!item) {
         delete object;
+        delete context;
+        return nullptr;
+    }
 
     item->setParentItem(q);
     QQml_setParent_noEvent(item, q);