diff options
author | Mitch Curtis <mitch.curtis@qt.io> | 2020-07-23 14:55:18 +0200 |
---|---|---|
committer | Mitch Curtis <mitch.curtis@qt.io> | 2020-08-27 16:46:03 +0200 |
commit | 7f29e89c26ae2babc358b1c4e6f965af6ec759f4 (patch) | |
tree | b8d1b68f53a4d39c9f389d8c68a77d60d4cc4888 /tests/auto/styleimports | |
parent | bda2925304525be1dacc16fe9779199f29a08f45 (diff) |
Material: fix binding loops when binding between attached properties
The paletteChanged signal was used as the change signal for a lot of
properties. The problem with this was this binding, for example:
Material.foreground: Material.toolTextColor
results in foreground being set, which emits paletteChanged.
toolTextColor has paletteChanged as its change signal, so that is
triggered and then the foreground binding is re-evaluated in the middle
of already being evaluated.
I haven't found a way to fix this for toolTextColor yet, so we
temporarily skip emission of toolTextColorChanged when foreground
changes. This means that some text will be the wrong color when
foreground is changed after startup.
For other properties, using more specific change handlers is enough
to solve any binding loops.
Task-number: QTBUG-85699
Pick-to: 5.15
Change-Id: Ied52d4c38914765ed5c75e234954f4baabaaa9af
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Diffstat (limited to 'tests/auto/styleimports')
0 files changed, 0 insertions, 0 deletions