Replace some Q_FOREACH loops by consume loops

These loops consume their input container, so make it explicit by
using qExchange(). This also means we dodge the potential issue of
container modification under iteration.

Change-Id: Ifc18f3d77b171e8f8e80f7c7c2db1b6ecf25f461
Reviewed-by: Michael Brasser <michael.brasser@live.com>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>

1 files changed, 1 insertions, 2 deletions

diff --git a/src/remoteobjects/qremoteobjectabstractitemmodelreplica.cpp b/src/remoteobjects/qremoteobjectabstractitemmodelreplica.cpp
index b8ca6f3..a1c8916 100644
--- a/src/remoteobjects/qremoteobjectabstractitemmodelreplica.cpp
+++ b/src/remoteobjects/qremoteobjectabstractitemmodelreplica.cpp
@@ -570,7 +570,7 @@ void QAbstractItemModelReplicaImplementation::fetchPendingData()
 
     std::vector<RequestedData> finalRequests;
     RequestedData curData;
-    Q_FOREACH (const RequestedData &data, m_requestedData) {
+    for (const RequestedData &data : qExchange(m_requestedData, {})) {
         qCDebug(QT_REMOTEOBJECT_MODELS) << Q_FUNC_INFO << "REQUESTED start=" << data.start << "end=" << data.end << "roles=" << data.roles;
 
         Q_ASSERT(!data.start.isEmpty());
@@ -644,7 +644,6 @@ void QAbstractItemModelReplicaImplementation::fetchPendingData()
         m_pendingRequests.push_back(watcher);
         connect(watcher, &RowWatcher::finished, this, &QAbstractItemModelReplicaImplementation::requestedData);
     }
-    m_requestedData.clear();
 }
 
 void QAbstractItemModelReplicaImplementation::onModelReset()