diff options
| author | Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com> | 2016-06-28 15:29:15 +0200 |
|---|---|---|
| committer | Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com> | 2016-06-29 08:13:04 +0000 |
| commit | 4c348cd95b0f69d1bcd61b6114d827799bc6de57 (patch) | |
| tree | f5457ed496fd7151c56ef6587ce7ed95652ff63d /git-hooks | |
| parent | 40bdbd1ab3f93e9836447eabadb41fc736663cb2 (diff) | |
complain only about summaries longer than 72, not 70 columns
it's kinda stupid to complain about something the commit template leads
one to do.
the wisdom of the template is debatable. github in particular will make
an ellipsis after column 69. and the official recommendation is 50.
Change-Id: I7a4aed1867f4f9ab15fe513b92b80c0eed37dd07
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Diffstat (limited to 'git-hooks')
| -rwxr-xr-x | git-hooks/sanitize-commit | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/git-hooks/sanitize-commit b/git-hooks/sanitize-commit index c8adc56..93fd6f7 100755 --- a/git-hooks/sanitize-commit +++ b/git-hooks/sanitize-commit @@ -329,7 +329,7 @@ while (<MSG>) { complain_cln("Summary is too short", "log"); } elsif (!$badlog && !$revert1 && length($_) > 120) { complain_cln("Summary is excessively long", "log"); - } elsif ($parents < 2 && !$revert1 && length($_) > 70) { + } elsif ($parents < 2 && !$revert1 && length($_) > 72) { complain_cln("Aim for shorter summaries", "", -1); } } else { |