summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVolker Hilsheimer <volker.hilsheimer@qt.io>2021-09-20 10:36:19 +0200
committerVolker Hilsheimer <volker.hilsheimer@qt.io>2021-09-20 10:44:16 +0200
commit77c706ed02d848f5f294237049da5560a3620a0c (patch)
tree8d2b39977d6c150b1af5ba4c87f227e885552282
parent20518ae999155a0dac5758d3d853d11629da5ca1 (diff)
Fix usage of QMutexLocker
Hold it for the entire scope, not just for the line in which it is declared. Pick-to: 6.2 5.15 Change-Id: I6d85e722c7fdda57c3e3b11898558f3b27cf4ccd Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io> Reviewed-by: Karsten Heimrich <karsten.heimrich@qt.io>
-rw-r--r--src/serialbus/qcanbusdevice.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/serialbus/qcanbusdevice.cpp b/src/serialbus/qcanbusdevice.cpp
index aa98c9a..bf7ae44 100644
--- a/src/serialbus/qcanbusdevice.cpp
+++ b/src/serialbus/qcanbusdevice.cpp
@@ -573,7 +573,7 @@ void QCanBusDevice::clear(QCanBusDevice::Directions direction)
clearError();
if (direction & Direction::Input) {
- QMutexLocker(&d->incomingFramesGuard);
+ QMutexLocker locker(&d->incomingFramesGuard);
d->incomingFrames.clear();
}