diff options
| author | Andre Hartmann <aha_1980@gmx.de> | 2021-01-06 19:00:57 +0100 |
|---|---|---|
| committer | Andre Hartmann <aha_1980@gmx.de> | 2021-02-03 14:57:12 +0100 |
| commit | 227060f8c17aaf90fe542ad6079a6badaf410a0d (patch) | |
| tree | 4c6e441c846a199a4e436f0a4fea07eeca9fa292 /src/plugins/canbus/virtualcan | |
| parent | c990bdbf8ec922dd7702a2a0e33b9b70db3ac6ee (diff) | |
QCanBusDevice: Replace int parameter with ConfigurationKey
They only place where this might break user code,
is for custom plugins using custom configuration
parameters.
For most users however, this type safety makes the
API easier to use.
[ChangeLog][QCanBusDevice]
All functions dealing with configuration parameters
now take a QCanBusDevice::ConfigurationKey instead
an int.
Fixes: QTBUG-89839
Change-Id: I0a1de5fdcfc4292b23599d4770102740a2df1601
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
Diffstat (limited to 'src/plugins/canbus/virtualcan')
| -rw-r--r-- | src/plugins/canbus/virtualcan/virtualcanbackend.cpp | 2 | ||||
| -rw-r--r-- | src/plugins/canbus/virtualcan/virtualcanbackend.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/plugins/canbus/virtualcan/virtualcanbackend.cpp b/src/plugins/canbus/virtualcan/virtualcanbackend.cpp index ce1ca3e..0067ded 100644 --- a/src/plugins/canbus/virtualcan/virtualcanbackend.cpp +++ b/src/plugins/canbus/virtualcan/virtualcanbackend.cpp @@ -224,7 +224,7 @@ void VirtualCanBackend::close() m_clientSocket->write("disconnect:can" + QByteArray::number(m_channel) + '\n'); } -void VirtualCanBackend::setConfigurationParameter(int key, const QVariant &value) +void VirtualCanBackend::setConfigurationParameter(ConfigurationKey key, const QVariant &value) { if (key == QCanBusDevice::ReceiveOwnKey || key == QCanBusDevice::CanFdKey) QCanBusDevice::setConfigurationParameter(key, value); diff --git a/src/plugins/canbus/virtualcan/virtualcanbackend.h b/src/plugins/canbus/virtualcan/virtualcanbackend.h index 38f79da..0d908ca 100644 --- a/src/plugins/canbus/virtualcan/virtualcanbackend.h +++ b/src/plugins/canbus/virtualcan/virtualcanbackend.h @@ -82,7 +82,7 @@ public: bool open() override; void close() override; - void setConfigurationParameter(int key, const QVariant &value) override; + void setConfigurationParameter(ConfigurationKey key, const QVariant &value) override; bool writeFrame(const QCanBusFrame &frame) override; |