diff options
| author | Thiago Macieira <thiago.macieira@intel.com> | 2013-04-06 13:49:20 -0700 |
|---|---|---|
| committer | The Qt Project <gerrit-noreply@qt-project.org> | 2013-04-08 06:59:48 +0200 |
| commit | 29a1b0576f08b01f46b86a8c394bb1b5b70a9ead (patch) | |
| tree | 7384c8f60b5d3d48b24e77a4222b8b9195ea920c /src/serviceframework | |
| parent | 782aeb0aae75d542b2692ee07abd08e04a720cf4 (diff) | |
Make QServicePackagePrivate::clean non-virtual
This class method does not need to be virtual, since nothing is
deriving from it. If something ever does, then the destructor should
be virtual too, to avoid this warning:
qservicepackage.cpp:49:10: required from here
qshareddata.h:163:72: warning: deleting object of polymorphic class type ‘QServicePackagePrivate’ which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor]
Change-Id: I0e5ccc6edcb6a74e801edfbe73320cf5a0ece171
Reviewed-by: Aaron McCarthy <mccarthy.aaron@gmail.com>
Diffstat (limited to 'src/serviceframework')
| -rw-r--r-- | src/serviceframework/ipc/qservicepackage_p.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/serviceframework/ipc/qservicepackage_p.h b/src/serviceframework/ipc/qservicepackage_p.h index 05ede234..956273ba 100644 --- a/src/serviceframework/ipc/qservicepackage_p.h +++ b/src/serviceframework/ipc/qservicepackage_p.h @@ -117,7 +117,7 @@ public: QUuid instanceId; QServicePackage::ResponseType responseType; - virtual void clean() + void clean() { packageType = QServicePackage::ObjectCreation; messageId = QUuid(); |