diff options
| author | Jarek Kobus <jaroslaw.kobus@qt.io> | 2024-02-08 23:34:37 +0100 |
|---|---|---|
| committer | Jarek Kobus <jaroslaw.kobus@qt.io> | 2024-02-14 04:06:41 +0100 |
| commit | 6b582d71c5b421e44759c1212d92fae9ba7d5ef7 (patch) | |
| tree | bb2a1004d723d3f32ee45b0e89f971accdb25044 | |
| parent | 25a36bca696023c9fe8ea7514a074df360660473 (diff) | |
QtHelp: Replace QMap with QHash in QOptionsWidget
Use QListWidget::addItem() instead of insertItem().
Task-number: QTBUG-122025
Change-Id: Ifcd360bdfb9e97152c54615637bb7938e5aba9ce
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
| -rw-r--r-- | src/assistant/help/qoptionswidget.cpp | 4 | ||||
| -rw-r--r-- | src/assistant/help/qoptionswidget_p.h | 6 |
2 files changed, 5 insertions, 5 deletions
diff --git a/src/assistant/help/qoptionswidget.cpp b/src/assistant/help/qoptionswidget.cpp index e42f852ad..688b4ed72 100644 --- a/src/assistant/help/qoptionswidget.cpp +++ b/src/assistant/help/qoptionswidget.cpp @@ -149,7 +149,7 @@ QListWidgetItem *QOptionsWidget::appendItem(const QString &optionName, bool vali { QListWidgetItem *optionItem = new QListWidgetItem(optionText(optionName, valid), m_listWidget); optionItem->setCheckState(selected ? Qt::Checked : Qt::Unchecked); - m_listWidget->insertItem(m_listWidget->count(), optionItem); + m_listWidget->addItem(optionItem); m_optionToItem[optionName] = optionItem; m_itemToOption[optionItem] = optionName; return optionItem; @@ -159,7 +159,7 @@ void QOptionsWidget::appendSeparator() { QListWidgetItem *separatorItem = new QListWidgetItem(m_listWidget); ListWidgetDelegate::setSeparator(separatorItem); - m_listWidget->insertItem(m_listWidget->count(), separatorItem); + m_listWidget->addItem(separatorItem); } void QOptionsWidget::itemChanged(QListWidgetItem *item) diff --git a/src/assistant/help/qoptionswidget_p.h b/src/assistant/help/qoptionswidget_p.h index 0aef8bb7a..d22ab0878 100644 --- a/src/assistant/help/qoptionswidget_p.h +++ b/src/assistant/help/qoptionswidget_p.h @@ -15,7 +15,7 @@ // We mean it. // -#include <QtCore/qmap.h> +#include <QtCore/qhash.h> #include <QtWidgets/qwidget.h> QT_BEGIN_NAMESPACE @@ -52,8 +52,8 @@ private: QStringList m_validOptions; QStringList m_invalidOptions; QStringList m_selectedOptions; - QMap<QString, QListWidgetItem *> m_optionToItem; - QMap<QListWidgetItem *, QString> m_itemToOption; // TODO: Replace with QHash + QHash<QString, QListWidgetItem *> m_optionToItem; + QHash<QListWidgetItem *, QString> m_itemToOption; }; QT_END_NAMESPACE |