summaryrefslogtreecommitdiffstats
path: root/src/qdoc/qmlvisitor.h
diff options
context:
space:
mode:
authorPaul Wicking <paul.wicking@qt.io>2021-04-28 13:36:28 +0200
committerPaul Wicking <paul.wicking@qt.io>2021-05-03 10:05:04 +0200
commit6f462ac37916d9fc3fae793e040690741845ef62 (patch)
tree66bc4b997e0b38cd3d2cd86e8787d54672ca38a6 /src/qdoc/qmlvisitor.h
parenta1ed48d0d073a8bdd7b5e608982a5bbd9af47af8 (diff)
QDoc: Code cleanup
* Use multiple arguments for QStrings instead of calling .arg() multiple times. * Define trivial constructor/destructor '= default' instead of adding empty implementations. * Remove unreachable code. * Prefer ranged-based for loops. * Initialize with auto from static_cast<>() and new. * Simplify expressions. * Prefer "QList::empty()" over "QList::size() > 0". * Remove unused method. * Return qsizetype instead of int to avoid narrowing conversion. * Remove unused include. * Remove unreachable return statement. * Prefer raw string literals over escaped regexes. * Initialize struct members. * Make variables used as const refs const refs. * Use std::move instead of passing const ref in ctor. * Drop redundant 'virtual' from methods marked 'override'. * Make local copies that arent ever modified const refs to avoid copying. * Turn for-loop into std::any_of. * Made single-argument constructor explicit. * Don't shadow variable names from outer scope if not necessary. * Remove const at top level that does not improve const correctness. * Update copyright notice for affected classes. Task-number: QTBUG-71176 Change-Id: Ia41e5b947b72f594b60d189b6b0ff68587c3afb9 Reviewed-by: Topi Reiniƶ <topi.reinio@qt.io>
Diffstat (limited to 'src/qdoc/qmlvisitor.h')
-rw-r--r--src/qdoc/qmlvisitor.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/qdoc/qmlvisitor.h b/src/qdoc/qmlvisitor.h
index a717c7d0d..17cff7617 100644
--- a/src/qdoc/qmlvisitor.h
+++ b/src/qdoc/qmlvisitor.h
@@ -1,6 +1,6 @@
/****************************************************************************
**
-** Copyright (C) 2019 The Qt Company Ltd.
+** Copyright (C) 2021 The Qt Company Ltd.
** Contact: https://www.qt.io/licensing/
**
** This file is part of the tools applications of the Qt Toolkit.
@@ -65,7 +65,7 @@ class QmlDocVisitor : public QQmlJS::AST::Visitor
public:
QmlDocVisitor(const QString &filePath, const QString &code, QQmlJS::Engine *engine,
const QSet<QString> &commands, const QSet<QString> &topics);
- ~QmlDocVisitor() override;
+ ~QmlDocVisitor() override = default;
bool visit(QQmlJS::AST::UiImport *import) override;
void endVisit(QQmlJS::AST::UiImport *definition) override;