diff options
author | Shawn Rutledge <shawn.rutledge@qt.io> | 2022-02-03 10:32:50 +0100 |
---|---|---|
committer | Shawn Rutledge <shawn.rutledge@qt.io> | 2022-02-04 08:53:01 +0100 |
commit | 94f6991d4d9ccd9408847e1ecc1b77d94fffa865 (patch) | |
tree | 0acbe3d12f7e50e9b45deba11049453168ee15d3 /src/shared/qtpropertybrowser/qtgroupboxpropertybrowser.cpp | |
parent | 9f5998f94a363610c868b6784971418fa8273148 (diff) |
Fix set-but-not-read warning in QtGroupBoxPropertyBrowserPrivate
oldRow was set but not read.
Pick-to: 6.3
Change-Id: I6a7616a9f9cd85152fa451b404ea75c1be9099f0
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Diffstat (limited to 'src/shared/qtpropertybrowser/qtgroupboxpropertybrowser.cpp')
-rw-r--r-- | src/shared/qtpropertybrowser/qtgroupboxpropertybrowser.cpp | 13 |
1 files changed, 1 insertions, 12 deletions
diff --git a/src/shared/qtpropertybrowser/qtgroupboxpropertybrowser.cpp b/src/shared/qtpropertybrowser/qtgroupboxpropertybrowser.cpp index 43ca132d8..0b8e86e83 100644 --- a/src/shared/qtpropertybrowser/qtgroupboxpropertybrowser.cpp +++ b/src/shared/qtpropertybrowser/qtgroupboxpropertybrowser.cpp @@ -300,18 +300,7 @@ void QtGroupBoxPropertyBrowserPrivate::propertyRemoved(QtBrowserItem *index) removeRow(parentItem->layout, row); } else { WidgetItem *par = parentItem->parent; - QGridLayout *l = nullptr; - int oldRow = -1; - if (!par) { - l = m_mainLayout; - oldRow = m_children.indexOf(parentItem); - } else { - l = par->layout; - oldRow = par->children.indexOf(parentItem); - if (hasHeader(par)) - oldRow += 2; - } - + QGridLayout *l = (par ? par->layout : m_mainLayout); if (parentItem->widget) { parentItem->widget->hide(); parentItem->widget->setParent(0); |