diff options
Diffstat (limited to 'src/assistant/assistant')
-rw-r--r-- | src/assistant/assistant/bookmarkdialog.cpp | 2 | ||||
-rw-r--r-- | src/assistant/assistant/doc/src/assistant-manual.qdoc | 1 | ||||
-rw-r--r-- | src/assistant/assistant/doc/src/assistant-quick-guide.qdoc | 2 | ||||
-rw-r--r-- | src/assistant/assistant/helpenginewrapper.cpp | 5 | ||||
-rw-r--r-- | src/assistant/assistant/helpenginewrapper.h | 3 | ||||
-rw-r--r-- | src/assistant/assistant/indexwindow.cpp | 22 | ||||
-rw-r--r-- | src/assistant/assistant/indexwindow.h | 4 | ||||
-rw-r--r-- | src/assistant/assistant/main.cpp | 1 | ||||
-rw-r--r-- | src/assistant/assistant/mainwindow.cpp | 6 | ||||
-rw-r--r-- | src/assistant/assistant/mainwindow.h | 3 | ||||
-rw-r--r-- | src/assistant/assistant/preferencesdialog.cpp | 4 | ||||
-rw-r--r-- | src/assistant/assistant/remotecontrol.cpp | 15 | ||||
-rw-r--r-- | src/assistant/assistant/topicchooser.cpp | 12 | ||||
-rw-r--r-- | src/assistant/assistant/topicchooser.h | 3 |
14 files changed, 45 insertions, 38 deletions
diff --git a/src/assistant/assistant/bookmarkdialog.cpp b/src/assistant/assistant/bookmarkdialog.cpp index 1ffe6dc84..cb775d30a 100644 --- a/src/assistant/assistant/bookmarkdialog.cpp +++ b/src/assistant/assistant/bookmarkdialog.cpp @@ -60,7 +60,7 @@ BookmarkDialog::BookmarkDialog(BookmarkModel *sourceModel, const QString &title, bookmarkProxyModel = new BookmarkFilterModel(this); bookmarkProxyModel->setSourceModel(bookmarkModel); ui.bookmarkFolders->setModel(bookmarkProxyModel); - connect(ui.bookmarkFolders, QOverload<int, const QString &>::of(&QComboBox::currentIndexChanged), + connect(ui.bookmarkFolders, &QComboBox::currentIndexChanged, this, QOverload<int>::of(&BookmarkDialog::currentIndexChanged)); bookmarkTreeModel = new BookmarkTreeModel(this); diff --git a/src/assistant/assistant/doc/src/assistant-manual.qdoc b/src/assistant/assistant/doc/src/assistant-manual.qdoc index c86a19cac..b03cffeaa 100644 --- a/src/assistant/assistant/doc/src/assistant-manual.qdoc +++ b/src/assistant/assistant/doc/src/assistant-manual.qdoc @@ -62,7 +62,6 @@ \page assistant-custom-help-viewer.html \title Customizing Qt Assistant - \contentspage {Qt Assistant Manual}{Contents} \previouspage Using Qt Assistant Using \QA as custom help viewer requires more than just being able to diff --git a/src/assistant/assistant/doc/src/assistant-quick-guide.qdoc b/src/assistant/assistant/doc/src/assistant-quick-guide.qdoc index 411bf19e1..2a8dc01e1 100644 --- a/src/assistant/assistant/doc/src/assistant-quick-guide.qdoc +++ b/src/assistant/assistant/doc/src/assistant-quick-guide.qdoc @@ -27,7 +27,6 @@ /*! \if !defined(ASSISTANT_INTERNAL) - \contentspage {Qt Assistant Manual}{Contents} \previouspage Qt Assistant Manual \endif \page assistant-quick-guide.html @@ -99,7 +98,6 @@ /*! \if !defined(ASSISTANT_INTERNAL) - \contentspage {Qt Assistant Manual}{Contents} \nextpage Customizing Qt Assistant \endif \page assistant-details.html diff --git a/src/assistant/assistant/helpenginewrapper.cpp b/src/assistant/assistant/helpenginewrapper.cpp index d69138ff8..c927a2ef1 100644 --- a/src/assistant/assistant/helpenginewrapper.cpp +++ b/src/assistant/assistant/helpenginewrapper.cpp @@ -41,6 +41,7 @@ #include <QtHelp/QHelpEngine> #include <QtHelp/QHelpFilterEngine> #include <QtHelp/QHelpIndexModel> +#include <QtHelp/QHelpLink> #include <QtHelp/QHelpSearchEngine> QT_BEGIN_NAMESPACE @@ -261,10 +262,10 @@ QByteArray HelpEngineWrapper::fileData(const QUrl &url) const return d->m_helpEngine->fileData(url); } -QMap<QString, QUrl> HelpEngineWrapper::linksForIdentifier(const QString &id) const +QList<QHelpLink> HelpEngineWrapper::documentsForIdentifier(const QString &id) const { TRACE_OBJ - return d->m_helpEngine->linksForIdentifier(id); + return d->m_helpEngine->documentsForIdentifier(id); } QString HelpEngineWrapper::error() const diff --git a/src/assistant/assistant/helpenginewrapper.h b/src/assistant/assistant/helpenginewrapper.h index 81d8ffa1f..df2ec8a73 100644 --- a/src/assistant/assistant/helpenginewrapper.h +++ b/src/assistant/assistant/helpenginewrapper.h @@ -47,6 +47,7 @@ class QHelpIndexWidget; class QHelpSearchEngine; class QHelpFilterEngine; class QHelpEngineCore; +struct QHelpLink; enum { ShowHomePage = 0, @@ -80,7 +81,7 @@ public: bool unregisterDocumentation(const QString &namespaceName); QUrl findFile(const QUrl &url) const; QByteArray fileData(const QUrl &url) const; - QMap<QString, QUrl> linksForIdentifier(const QString &id) const; + QList<QHelpLink> documentsForIdentifier(const QString &id) const; QString error() const; QHelpFilterEngine *filterEngine() const; diff --git a/src/assistant/assistant/indexwindow.cpp b/src/assistant/assistant/indexwindow.cpp index d8c0f8212..c0647ca6f 100644 --- a/src/assistant/assistant/indexwindow.cpp +++ b/src/assistant/assistant/indexwindow.cpp @@ -44,6 +44,8 @@ #include <QtWidgets/QListWidgetItem> #include <QtHelp/QHelpIndexWidget> +#include <QtHelp/QHelpEngineCore> +#include <QtHelp/QHelpLink> QT_BEGIN_NAMESPACE @@ -71,10 +73,12 @@ IndexWindow::IndexWindow(QWidget *parent) this, &IndexWindow::disableSearchLineEdit); connect(helpEngine.indexModel(), &QHelpIndexModel::indexCreated, this, &IndexWindow::enableSearchLineEdit); - connect(m_indexWidget, &QHelpIndexWidget::linkActivated, - this, &IndexWindow::linkActivated); - connect(m_indexWidget, &QHelpIndexWidget::linksActivated, - this, &IndexWindow::linksActivated); + connect(m_indexWidget, &QHelpIndexWidget::documentActivated, + this, [this](const QHelpLink &link) { + emit linkActivated(link.url); + }); + connect(m_indexWidget, &QHelpIndexWidget::documentsActivated, + this, &IndexWindow::documentsActivated); connect(m_searchLineEdit, &QLineEdit::returnPressed, m_indexWidget, &QHelpIndexWidget::activateCurrentItem); layout->addWidget(m_indexWidget); @@ -196,15 +200,15 @@ void IndexWindow::open(QHelpIndexWidget* indexWidget, const QModelIndex &index) QHelpIndexModel *model = qobject_cast<QHelpIndexModel*>(indexWidget->model()); if (model) { const QString keyword = model->data(index, Qt::DisplayRole).toString(); - const QMap<QString, QUrl> links = model->linksForKeyword(keyword); + const QList<QHelpLink> docs = model->helpEngine()->documentsForKeyword(keyword); QUrl url; - if (links.count() > 1) { - TopicChooser tc(this, keyword, links); + if (docs.count() > 1) { + TopicChooser tc(this, keyword, docs); if (tc.exec() == QDialog::Accepted) url = tc.link(); - } else if (!links.isEmpty()) { - url = links.first(); + } else if (!docs.isEmpty()) { + url = docs.first().url; } else { return; } diff --git a/src/assistant/assistant/indexwindow.h b/src/assistant/assistant/indexwindow.h index 647d3b3b9..be82543dd 100644 --- a/src/assistant/assistant/indexwindow.h +++ b/src/assistant/assistant/indexwindow.h @@ -37,6 +37,7 @@ QT_BEGIN_NAMESPACE class QHelpIndexWidget; class QModelIndex; +struct QHelpLink; class IndexWindow : public QWidget { @@ -54,8 +55,7 @@ public: signals: void linkActivated(const QUrl &link); - void linksActivated(const QMap<QString, QUrl> &links, - const QString &keyword); + void documentsActivated(const QList<QHelpLink> &documents, const QString &keyword); void escapePressed(); private slots: diff --git a/src/assistant/assistant/main.cpp b/src/assistant/assistant/main.cpp index cd6487751..88e89ed69 100644 --- a/src/assistant/assistant/main.cpp +++ b/src/assistant/assistant/main.cpp @@ -373,7 +373,6 @@ int main(int argc, char *argv[]) { QCoreApplication::setAttribute(Qt::AA_EnableHighDpiScaling); QCoreApplication::setAttribute(Qt::AA_UseHighDpiPixmaps); - QCoreApplication::setAttribute(Qt::AA_DisableWindowContextHelpButton); TRACE_OBJ QScopedPointer<QCoreApplication> a(createApplication(argc, argv)); #if QT_CONFIG(library) diff --git a/src/assistant/assistant/mainwindow.cpp b/src/assistant/assistant/mainwindow.cpp index b3c0240ba..b651d43b5 100644 --- a/src/assistant/assistant/mainwindow.cpp +++ b/src/assistant/assistant/mainwindow.cpp @@ -682,7 +682,7 @@ void MainWindow::setupActions() // index window connect(m_indexWindow, &IndexWindow::linkActivated, m_centralWidget, &CentralWidget::setSource); - connect(m_indexWindow, &IndexWindow::linksActivated, + connect(m_indexWindow, &IndexWindow::documentsActivated, this, &MainWindow::showTopicChooser); connect(m_indexWindow, &IndexWindow::escapePressed, this, &MainWindow::activateCurrentCentralWidgetTab); @@ -822,11 +822,11 @@ void MainWindow::gotoAddress() m_centralWidget->setSource(m_addressLineEdit->text()); } -void MainWindow::showTopicChooser(const QMap<QString, QUrl> &links, +void MainWindow::showTopicChooser(const QList<QHelpLink> &documents, const QString &keyword) { TRACE_OBJ - TopicChooser tc(this, keyword, links); + TopicChooser tc(this, keyword, documents); if (tc.exec() == QDialog::Accepted) { m_centralWidget->setSource(tc.link()); } diff --git a/src/assistant/assistant/mainwindow.h b/src/assistant/assistant/mainwindow.h index c5bf5837e..b9d86cfc7 100644 --- a/src/assistant/assistant/mainwindow.h +++ b/src/assistant/assistant/mainwindow.h @@ -46,6 +46,7 @@ class ContentWindow; class IndexWindow; class QtDocInstaller; class SearchWidget; +struct QHelpLink; class MainWindow : public QMainWindow { @@ -88,7 +89,7 @@ private slots: void showNewAddress(); void showAboutDialog(); void showNewAddress(const QUrl &url); - void showTopicChooser(const QMap<QString, QUrl> &links, const QString &keyword); + void showTopicChooser(const QList<QHelpLink> &documents, const QString &keyword); void updateApplicationFont(); void filterDocumentation(int filterIndex); void setupFilterCombo(); diff --git a/src/assistant/assistant/preferencesdialog.cpp b/src/assistant/assistant/preferencesdialog.cpp index 5dd24a102..ebd2a96e8 100644 --- a/src/assistant/assistant/preferencesdialog.cpp +++ b/src/assistant/assistant/preferencesdialog.cpp @@ -200,13 +200,13 @@ void PreferencesDialog::updateFontSettingsPage() const QList<QComboBox*> &appCombos = m_appFontPanel->findChildren<QComboBox*>(); for (QComboBox* box : appCombos) { - connect(box, QOverload<int, const QString &>::of(&QComboBox::currentIndexChanged), + connect(box, QOverload<int>::of(&QComboBox::currentIndexChanged), this, &PreferencesDialog::appFontSettingChanged); } const QList<QComboBox*> &browserCombos = m_browserFontPanel->findChildren<QComboBox*>(); for (QComboBox* box : browserCombos) { - connect(box, QOverload<int, const QString &>::of(&QComboBox::currentIndexChanged), + connect(box, QOverload<int>::of(&QComboBox::currentIndexChanged), this, &PreferencesDialog::browserFontSettingChanged); } } diff --git a/src/assistant/assistant/remotecontrol.cpp b/src/assistant/assistant/remotecontrol.cpp index 7fdbee41e..0c9cc6c14 100644 --- a/src/assistant/assistant/remotecontrol.cpp +++ b/src/assistant/assistant/remotecontrol.cpp @@ -44,6 +44,7 @@ #include <QtHelp/QHelpEngine> #include <QtHelp/QHelpFilterEngine> #include <QtHelp/QHelpIndexWidget> +#include <QtHelp/QHelpLink> #include <QtHelp/QHelpSearchQueryWidget> #ifdef Q_OS_WIN @@ -199,9 +200,9 @@ void RemoteControl::handleActivateIdentifierCommand(const QString &arg) clearCache(); m_activateIdentifier = arg; } else { - const QMap<QString, QUrl> links = helpEngine.linksForIdentifier(arg); - if (!links.isEmpty()) - CentralWidget::instance()->setSource(links.first()); + const auto docs = helpEngine.documentsForIdentifier(arg); + if (!docs.isEmpty()) + CentralWidget::instance()->setSource(docs.first().url); } } @@ -266,10 +267,10 @@ void RemoteControl::applyCache() m_mainWindow->setIndexString(m_activateKeyword); helpEngine.indexWidget()->activateCurrentItem(); } else if (!m_activateIdentifier.isEmpty()) { - const QMap<QString, QUrl> links = - helpEngine.linksForIdentifier(m_activateIdentifier); - if (!links.isEmpty()) - CentralWidget::instance()->setSource(links.first()); + const auto docs = + helpEngine.documentsForIdentifier(m_activateIdentifier); + if (!docs.isEmpty()) + CentralWidget::instance()->setSource(docs.first().url); } else if (!m_currentFilter.isEmpty()) { helpEngine.filterEngine()->setActiveFilter(m_currentFilter); } diff --git a/src/assistant/assistant/topicchooser.cpp b/src/assistant/assistant/topicchooser.cpp index d058646c5..ec9faddb6 100644 --- a/src/assistant/assistant/topicchooser.cpp +++ b/src/assistant/assistant/topicchooser.cpp @@ -35,9 +35,11 @@ #include <QSortFilterProxyModel> #include <QUrl> +#include <QtHelp/QHelpLink> + QT_BEGIN_NAMESPACE -TopicChooser::TopicChooser(QWidget *parent, const QString &keyword, const QMap<QString, QUrl> &links) +TopicChooser::TopicChooser(QWidget *parent, const QString &keyword, const QList<QHelpLink> &docs) : QDialog(parent) , m_filterModel(new QSortFilterProxyModel(this)) { @@ -53,10 +55,10 @@ TopicChooser::TopicChooser(QWidget *parent, const QString &keyword, const QMap<Q m_filterModel->setSourceModel(model); m_filterModel->setFilterCaseSensitivity(Qt::CaseInsensitive); - for (auto it = links.cbegin(), end = links.cend(); it != end; ++it) { - m_links.append(it.value()); - QStandardItem *item = new QStandardItem(it.key()); - item->setToolTip(it.value().toString()); + for (const auto &doc : docs) { + m_links.append(doc.url); + QStandardItem *item = new QStandardItem(doc.title); + item->setToolTip(doc.url.toString()); model->appendRow(item); } diff --git a/src/assistant/assistant/topicchooser.h b/src/assistant/assistant/topicchooser.h index 730ad68a0..2406ef99f 100644 --- a/src/assistant/assistant/topicchooser.h +++ b/src/assistant/assistant/topicchooser.h @@ -36,13 +36,14 @@ QT_BEGIN_NAMESPACE class QSortFilterProxyModel; +struct QHelpLink; class TopicChooser : public QDialog { Q_OBJECT public: - TopicChooser(QWidget *parent, const QString &keyword, const QMap<QString, QUrl> &links); + TopicChooser(QWidget *parent, const QString &keyword, const QList<QHelpLink> &docs); ~TopicChooser() override; QUrl link() const; |