aboutsummaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
...
* doc: Fix qdoc warning after Wayland Compositor changeEskil Abrahamsen Blomfeldt2023-03-011-2/+1
| | | | | | | | | | The compositor examples no longer include the module name in the title. Pick-to: 6.5 Change-Id: I90b5974b53c46dabde1f2f0288310bec9480c7c9 Reviewed-by: Inho Lee <inho.lee@qt.io> Reviewed-by: Paul Olav Tvete <paul.tvete@qt.io>
* Rename and tag exampleVolker Hilsheimer2023-02-241-2/+3
| | | | | | | | No need to use the module name or the term "example" in the title. Pick-to: 6.5 Change-Id: I47e78bdaabe16d8d81314d0b62ffd2e01a3bdce5 Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>
* Fix InputPanel keyboardRectangle bindingJarkko Koivikko2023-02-102-30/+38
| | | | | | | | | | | | | | | | | | The word candidate view was previously accounted to InputPanel.Keyboard height based on visibility. This caused complex binding issues during animations. The word candidate view was also included into keyboardRectangle. This prevented the application from comparing it to the cursorRectangle in binding fullScreenMode on the result. With this change the word candidate list is not accounted to keyboard height anymore. Instead, the height is added to the InputPanel.height. Furthermore, the keyboardRectangle never includes the word candidate list. This allows the application to compare it to the cursorRectangle. Pick-to: 6.5 6.4 Fixes: QTBUG-97830 Change-Id: I40de1bbc9a79da3e0a0cc1de70836bc8bd3289ff Reviewed-by: Inho Lee <inho.lee@qt.io>
* Fix selection with handles when highdpi is usedJarkko Koivikko2023-02-081-1/+6
| | | | | | | | | | | | | QPlatformInputContext::setSelectionOnFocusObject expects coordinates in native pixels. This was changed in qtbase in commit dc3446c1e35fb451070654709fe3c9b71eef7bb6 "Make setSelectionOnFocusObject() take native pixels" Pick-to: 6.5 6.4 Change-Id: I40c849638173df47fd6121a0a9165950df4b7e31 Reviewed-by: Inho Lee <inho.lee@qt.io>
* Do not allow empty selections (shadow input control)Jarkko Koivikko2023-02-081-0/+2
| | | | | | | | | | | | The same change was applied to qtbase qplatforminputcontext.cpp in commit 626b33dca1dc0d95e80bf139c197fbb13d740277: Allowing empty selections leads to strange behavior, it switches from selection handles to cursor handle. Pick-to: 6.5 6.4 Change-Id: Ied653085d8870350ee117f1b6531a3b0d678dd05 Reviewed-by: Inho Lee <inho.lee@qt.io>
* Fix full screen input control sync (disable when not active)Jarkko Koivikko2023-02-081-6/+6
| | | | | | | | | | | | | | | | | | | | | | The full screen input (aka shadow input) was continued being synchronized even after the full screen mode was disabled. Not only this caused an unnecessary overhead, it resulted in incorrect behavior in some cases when initializing cursorPosition and selection. This caused some of the test to fail without obvious reason. The root cause was the cursor synchronization of the shadow input setting the cursor during the tests. Now the shadow input item is reset when full screen mode is disabled. In addition, the cursor synchronization is not run when full screen mode is toggled. Remove affected test cases from the blacklist. Fixes: QTBUG-97901 Task-number: QTBUG-97830 Pick-to: 6.5 6.4 Change-Id: I571433adfdb5a3f3cd9d994f0d6e916cae372054 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Inho Lee <inho.lee@qt.io>
* Fix pre-edit text on shadow input when reselecting the first wordJarkko Koivikko2023-02-081-5/+11
| | | | | | | | | | | | | | | | | The shadow input control did not receive pre-edit text when the first word was reselected. In this case, the text is transferred from the input field to pre-edit field. Analysis shows that QInputMethodEvent::Selection cannot be used together when complete text buffer is replaced. This is because of quirks found in QQuickTextInput's processInputMethodEvent. Fix by handling text replacement and selection as separate events. Pick-to: 6.5 6.4 Change-Id: I2f730a491685e55ff28a98a4929a1cd1b5bf0e6a Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Inho Lee <inho.lee@qt.io>
* cerence: Don't use deprecated QLocale::countryJarkko Koivikko2023-02-062-4/+4
| | | | | Change-Id: I1eadd04af2ffd3f59687bfa788f29ebd7c2c7db0 Reviewed-by: Inho Lee <inho.lee@qt.io>
* Disable shadow input cursor blinking while invisibleJarkko Koivikko2023-02-011-2/+3
| | | | | | | | | | Shadow input control consumes resources in vain by blinking invisible cursor. This change disables the cursor blinking while invisible. Pick-to: 5.15 6.2 6.4 6.5 Change-Id: Icc9d8684285f5adbcf70388d961b7e5141a16197 Reviewed-by: <vaibhav.kumar@qt.io> Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>
* Doc: Revise Qt Virtual Keyboard module landing pageAndreas Eliasson2023-01-263-51/+61
| | | | | | | | | | | | | * Add CMake and qmake sections. * Make the technical guide an overview; It's not really a guide. * Move general info from the landing page to the overview page. * Move sections to make the landing page consistent with other modules. * Make minor punctuation fixes. Fixes: QTBUG-105592 Pick-to: 6.5 6.4 6.2 Change-Id: I7a1358c93841f63702c88ab796da14b8799ce0d7 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Fix the broken test after the retirement of qt_parse_all_argumentsAmir Masoud Abdol2023-01-202-9/+9
| | | | | | | | | | As we are now processing the arguments with cmake_parse_arguments(PARSE_ARGV, we don't need to pass the escape characters anymore. Task-number: QTBUG-99238 Change-Id: I9e288c8e9b95e4ef498e4dedcffa0c90d57718ab Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
* Doc: Fix ambiguous linksAndreas Eliasson2022-11-222-2/+3
| | | | | | | | | | I believe the link is supposed to go to the Advanced Usage page in the qmake manual. Fixes: QTBUG-108396 Pick-to: 6.4 6.2 Change-Id: Ib5d2098afd7c88a4f90f99359968337febce9e50 Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
* Revert "Fix build condition for vkb-desktop feature"Jani Heikkinen2022-11-111-1/+1
| | | | | | | | | This reverts commit 31af66738059a502d2808f196b03a8cd2d3fba2a. Reason for revert: Breaks builds for boot2qt Change-Id: Id70dc477bb8f682b5b5a64b4b9902c8e644863b4 Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* Fix build condition for vkb-desktop featureJarkko Koivikko2022-11-051-1/+1
| | | | | | | | Fixes: QTBUG-108030 Pick-to: 6.2 6.4 6.4.1 Change-Id: Ib9fb7827de3bb8cbe01e00a597d817b5a4200484 Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* Doc: Improve locale section of technical guidePaul Wicking2022-10-211-27/+49
| | | | | | | | | | | | * Clarify the layout fallback mechanism. * Rewrite parts of the text to improve legibility and reduce use of passive voice. Pick-to: 6.4 6.2 5.15 Fixes: QTBUG-105371 Change-Id: I062579bec6a2780b36dcdd9cf5c2b0f07a9c7801 Reviewed-by: Tuomas Vaarala <tuomas.vaarala@qt.io> Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
* Port from qAsConst() to std::as_const()Marc Mutz2022-10-068-9/+9
| | | | | | | | | | | | | | We've been requiring C++17 since Qt 6.0, and our qAsConst use finally starts to bother us (QTBUG-99313), so time to port away from it now. Since qAsConst has exactly the same semantics as std::as_const (down to rvalue treatment, constexpr'ness and noexcept'ness), there's really nothing more to it than a global search-and-replace. Task-number: QTBUG-99313 Change-Id: I44cfc9e829f4204750571be786f23cefac714a2a Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>
* Port from container::count() and length() to size()Marc Mutz2022-10-0636-148/+148
| | | | | | | | | | | | | | | | | | | | | This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Done-with: Jarkko Koivikko <jarkko.koivikko@code-q.fi> Change-Id: I28ad3f9b59bcfd2db9401c8d4ecc0800c57a3b17 Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>
* Fix syncqt warningsAlexey Edelev2022-09-288-17/+20
| | | | | | | | Adjust header files to fit syncqt standards. Task-number: QTBUG-87480 Change-Id: I2d07098edd704e5f99b22a777be1a5a4a8ee8900 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Revert "Add workaround for QML compiler bug"Ulf Hermann2022-09-131-1/+1
| | | | | | | | | | | | This reverts commit 47a7a9e16922b22fb0adc5b138348ea7cf49a212. If the issue has been fixed in qmlsc, we don't need the workaround anymore. Task-number: QTBUG-102152 Change-Id: I59041d53bcabd3cda6d01a2c2aa4371c80316758 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>
* Purge remaining usage of Q_NULLPTRJohannes Kauffmann2022-08-281-2/+2
| | | | | | Pick-to: 6.4 Change-Id: I61aa2bbfc5131eac1fc357255ed3acaa6c24a8af Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* Change the license of all CMakeLists.txt and *.cmake files to BSDLucie Gérard2022-08-2525-25/+25
| | | | | | Task-number: QTBUG-105718 Change-Id: I910246fa10b5be2742c9e9840e37b16c908c70a6 Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
* Remove Cpp.ignoretokens, Cpp.ignoredirectives from .qdocconfKai Köhne2022-08-221-6/+0
| | | | | | | | qdoc's new clang backend does not use them anymore. Task-number: QTBUG-104903 Change-Id: Ib143c6e9ca9d9b9610822d79f16cf9a7f3bda23d Reviewed-by: Paul Wicking <paul.wicking@qt.io>
* Fix static linking for styles and builtin styles pluginsJarkko Koivikko2022-08-182-0/+2
| | | | | | | | | | | | QT_MOC_EXPORT_PLUGIN and Q_IMPORT_PLUGIN are using different names in this case resulting in linker error. Fix the linker error by explicitly defining class name. Fixes: QTBUG-105685 Pick-to: 6.4 Change-Id: Ib41e92e3fb33a4d6d93b89479f3e15b48781f6e1 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* cerence: Fix errors (QLocale::country and QCryptographicHash::addData)Jarkko Koivikko2022-07-251-2/+2
| | | | | | | | | | Fix compiler errors (warnings as errors) that were missed because the cerence plugin is not built in normal case as it requires SDK. Pick-to: 6.4 Change-Id: I016bbdd2669ff09427e6af9484509f0d9feef0a3 Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi> Reviewed-by: Inho Lee <inho.lee@qt.io>
* Doc: Make QtVirtualKeyboard project name match the includeKai Köhne2022-07-221-20/+20
| | | | | | | | | | | | Fixes (qdoc) Could not find the module header in include paths for module "QtVirtualKeyboardDoc" Pick-to: 6.4 Change-Id: Id0a8c81b1466ba60abc197293d609441772c7d04 Reviewed-by: Luca Di Sera <luca.disera@qt.io> Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi> Reviewed-by: Paul Wicking <paul.wicking@qt.io>
* Add new header qvirtualkeyboardnamespace.hKai Köhne2022-07-193-41/+52
| | | | | | | | | | | | | | | Replace qvirtualkeyboard_namespace.h by new header without underscore, but keep old code working by making qvirtualkeyboard_namespace.h a forwarding header. This header could be removed in Qt 7. This fixes an issue with the QVirtualKeyboard module header that is generated by syncqt. Because of the underscore in the name, syncqt does _not_ include qvirtualkeyboard_namespace.h, which is unexpected for end users, and also did prevent qdoc from properly documenting the content. Pick-to: 6.4 Change-Id: I5097aa1ee7ada6ac9cd6e12568063426e3e510d3 Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>
* Add brief description for QtVirtualKeyboard namespaceKai Köhne2022-07-181-0/+1
| | | | | | | Pick-to: 6.4 Change-Id: I69af8f37763547bd5efcc23562de8758d62aa07e Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi> Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Add license headers to cmake filesLucie Gérard2022-07-0825-0/+75
| | | | | | | | | | | | CMakeLists.txt and .cmake files of significant size (more than 2 lines according to our check in tst_license.pl) now have the copyright and license header. Existing copyright statements remain intact Task-number: QTBUG-88621 Change-Id: Iaee7f8b319c5e1356395a65c78604b23e3b3b16b Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
* Remove platform-dependent codes for XCBInho Lee2022-06-143-67/+4
| | | | | | | | | | | | | | | Since 519cb821911681c837a02eb2fb2eddf7a43d967f, DesktopInputPanel::updateInputRegion maintains a platform-dependent implementation. However, it cannot handle a global scale factor (QT_SCALE_FACTOR) correctly. The main reason of the platform dependency was Qt::X11BypassWindowManagerHint and it was removed already. It seems to be safe to remove the platform-dependency here. Fixes: QTBUG-94770 Pick-to: 6.4 6.3 6.2 5.15 Change-Id: I3430b2c2ec9abe486f5660c3e61f26c6bfc34806 Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>
* Use SPDX license identifiersLucie Gérard2022-06-14309-8634/+624
| | | | | | | | | | | Replace the current license disclaimer in files by a SPDX-License-Identifier. License files are organized under LICENSES directory. Pick-to: 6.4 Task-number: QTBUG-67283 Change-Id: Iaeb3cb05cd781031a35e40f712805fa265116076 Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
* Fix links to "QML Import Path" sectionKai Köhne2022-06-131-1/+1
| | | | | | | | | qmake documentation happens to have a QML_IMPORT_PATH target. Make sure we actually link to the section in Qt Qml. Pick-to: 6.4 Change-Id: I0db5fa18ea6b931b44af381a141a6a5bafcf9c86 Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
* Avoid crash from nullptr accessVolker Hilsheimer2022-06-131-1/+3
| | | | | | | | | | Experienced when trying to reproduce QTBUG-85414 on macOS. The platformInputContext variable is tested for nullptr elsewhere, so it's evidently plausible that it is. Pick-to: 6.4 6.3 Change-Id: I9aa1047fa58a760c5d1a51acac96620e1438ceb6 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
* Doc: Use find_package(Qt6 REQUIRED COMPONENTS ...) idiomKai Köhne2022-05-121-1/+1
| | | | | | | | | | | Using REQUIRED as a prefix instead of suffix works better with OPTIONAL_COMPONENTS, and is also the order in the CMake manual. Task-number: QTBUG-98867 Pick-to: 6.3 Change-Id: I92c4c0c0e0fb3a072ddb9bb4482173f6908277c1 Reviewed-by: Rui Oliveira Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
* Update documentationJarkko Koivikko2022-04-2552-403/+432
| | | | | | | Task-number: QTBUG-100783 Change-Id: If48efba10aa9cfd856e54b0a8154c1a78389d5a9 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Nicholas Bennett <nicholas.bennett@qt.io>
* Revert "Fix broken layout that results from making key visible after startup"Jarkko Koivikko2022-04-221-7/+0
| | | | | | | | | | | | | | | | This reverts commit 13a199e6e2c5f27b0f12eff380df4f0c0d156e6e. Reverting this change because the layout optimization change in qtdeclarative: 10e359fa0b567534741b8a2550a336dffaf7a68f would otherwise break virtual keyboard layout. Fixes: QTBUG-102737 Change-Id: I4664161cf8cacb70e47d55d766dc53780fe00d28 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
* Add missing configure option -[no]-vkb-layoutsJarkko Koivikko2022-04-071-0/+1
| | | | | | Pick-to: 6.2 6.3 Change-Id: I7cf89bd1d8d8bd6c127723a2f6138c9a63243ad8 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* Port qtvirtualkeyboard to declarative type registrationJarkko Koivikko2022-04-07498-7178/+1743
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Port settings plugin to declarative type registration - Port styles plugin to declarative type registration - Dissect Components QML module from QtQuick.VirtualKeyboard Previously the QML components included in this module were located in the resources of virtualkeyboard Qt module and registered via manual type registration. Since migrating away from manual type registration, it is time to move these components out of the QtQuick.VirtualKeyboard namespace where they did not belong in the first place. They are implementation detail of the VirtualKeyboard and the VirtualKeyboard layouts. There is no use for them outside of this scope. - Add QtQuick.VirtualKeyboard.Plugins QML module - Port hangul to declarative type registrations - Port openwnn to declarative type registrations - Port tcime to declarative type registrations - Port thai to declarative type registrations - Port hunspell to declarative type registrations - Port pinyin to declarative type registrations - Port cerence to declarative type registrations - Port myscript to declarative type registrations - Add VirtualKeyboardFeatures namespace for feature detection - Remove QVirtualKeyboardInputContextPrivate::inputMethods property This is no longer needed (and cannot be supported) because of the new QML module based extensions model. Runtime feature detection is happens on the VirtualKeyboardFeatures namespace. - Remove Q_VKB_IMPORT_PLUGIN - Remove extensionloader (replaced with QML modules) This is no longer needed as all the extensions have been ported to QML modules. - Remove QML dependency from platforminputcontext plugin Since all the extra functionality (extensions, qml types registrations) have been moved out of this plugin, we can remove the dependency to QML module too. - Move keyboard layouts to Layouts plugin (but keep them as resources) Previously the keyboard layouts were located in the resources of the QtQuick.VirtualKeyboard plugin. This change moves them to new QtQuick.VirtualKeyboard.Layouts QML module. This module is loaded by explicit (qmldir) import at QtQuick.VirtualKeyboard plugin. We cannot make the layouts as compiled qml, because it will prevent from using resource path overload currently used by vendor plugins to override keyboard layouts. - Move builtin styles to new module QtQuick.VirtualKeyboard.Styles.Builtin No changes to style loading mechanism - the styles are still loaded using Loader. The internal resource path for builtin styles changed from :/QtQuick/VirtualKeyboard/content/styles to :/QtQuick/VirtualKeyboard/Styles/Builtin This has no impact on external users, because it can already specify custom style path using settings API. [ChangeLog] Virtual Keyboard extension mechanism was replaced with QML modules. Previously the virtual keyboard was using plugin mechanism with custom interface to load extensions. With the introduction of declarative type registration, this interface became obsolete. All of the existing virtual keyboard extensions are now registered as standard QML modules, loaded implicitly by the QtQuick.VirtualKeyboard module. This change does not impact the users of the virtual keyboard public API. Task-number: QTBUG-100783 Fixes: QTBUG-92212 Fixes: QTBUG-100705 Fixes: QTBUG-95680 Fixes: QTBUG-95660 Change-Id: Id2f87670d2678fa0b18bae56ee172bf206d99d3a Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* Add workaround for QML compiler bugJarkko Koivikko2022-03-311-1/+1
| | | | | | | | | | | | | | This change is required before the bug in the QML compiler is fixed and the virtual keyboard is ported to declarative type registrations. Without this, there is a runtime error: FunctionPopupList.qml:88:13: Unable to assign [undefined] to bool Task-number: QTBUG-102152 Task-number: QTBUG-100783 Change-Id: Iea5d01f8a089c0dc2c84aab0b04984c736c51380 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* Cleanup direct hunspell.h include from hunspell module interfaceJarkko Koivikko2022-03-319-415/+505
| | | | | | | | | | | | | | | | | | | | Including the hunspellinputmethod.h module header was not possible without also having hunspell headers in the include path. This was because the module header included the hunspellworker_p.h header, which in turn had the dependency to hunspell.h. Fix this by making the following changes: - Use the common QObjectPrivate derived private class for virtual keyboard input methods QVirtualKeyboardAbstractInputMethod to enable use of private slots (to hide connections with the HunspellWorker class). - Move HunspellWordList class out of the hunspellworker_p.h header to another private header, which does not depend on the hunspell.h. - Use private slots in the HunspellInputMethodPrivate to communicate with the HunspellWorker. Change-Id: I2b2e0dc922237388108470a2ae8da3a145fa4078 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* Make 3rdparty/hunspell buildable by simple git checkoutJarkko Koivikko2022-03-312-33/+22
| | | | | | | | | | | Previously the 3rdparty/hunspell sources had to be copied over to the src/plugins/hunspell/3rdparty. This change modifies the build files so that it is possible to do a simple git checkout of the hunspell sources at the same directory. Change-Id: I18d4a8f5d3819fdf61f19a1dc84e068fbf6a5600 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* zh_TW/main: Fix source file name of the created input method objectJarkko Koivikko2022-03-301-1/+1
| | | | | Change-Id: I445ccebf26a9e163b09f62b61a54d58763900b04 Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>
* Prevent Trace objects from being garbage collectedJarkko Koivikko2022-03-301-1/+9
| | | | | | | | Explicitly set QQmlEngine::CppOwnership to created Trace objects. Change-Id: Ie1bc0635f69eed07de859321e866bfadf7870797 Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi> Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* plugins/cerence: Move Q_DECLARE_PUBLIC to the public sectionJarkko Koivikko2022-03-303-2/+5
| | | | | | | | This is now required to use QObjectPrivate::connect. Pick-to: 6.2 6.3 Change-Id: I0d649ab9ac2106f2e1cf63be7e06f33acaa8203f Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>
* Use proper type (instead of var) for Keyboard.activeKeyJarkko Koivikko2022-03-302-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Virtual Keyboard was not impacted by this bug until it started using qmlcachegen with combined qmlmodule. The bug triggered with following property and code: property var activeKey ... activeKey = functionThatReturnsAnItem() ... if (activeKey) { // Unreachable code } The reason is that qmlcachegen incorrectly handled implicit type cast. This issue does not impact on any of the previous released qt versions, since none of them were using qmlcachegen for virtual keyboard components. This is because the components were embedded in the resources of the virtual keyboard qt module (QtXVirtualKeyboard). The preferred workaround in this case is to use an explicit type instead of variant. This will eliminate the implicit type cast. Task-number: QTBUG-100883 Change-Id: I4fea27df2d1242f6bdb38a4f4fddd44a8d5902fc Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi> Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* Fix build after qtbase changesVolker Hilsheimer2022-03-181-0/+2
| | | | | | | | Don't rely on transitive include for QMultiHash. Pick-to: 6.3 Change-Id: I89b34471f966427aeb14b45152d408a4bf33341a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* Make sure all private headers include at least one otherThiago Macieira2022-03-0817-15/+32
| | | | | | | | | | | See script in qtbase/util/includeprivate for the rules. Since these files are being touched anyway, I also ran the updatecopyright.pl script too. Change-Id: Ib056b47dde3341ef9a52ffff13ef677e471674b6 Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* Better handle input plugin switches in the KeyboardSelectionListModelDominik Holland2022-02-222-1/+21
| | | | | | | | | | | | | | | If the current dataSource gets destroyed, make sure to update the rowCount accordingly, otherwise there might be a lot of QML warnings like these: .../style.qml:709:13: Unable to assign [undefined] to QString In addition also do a boundary check in the data() function to make sure the data requested from the plugin are really available. Change-Id: I5ea57b945bc33a309c3b3b18ec029296d5428950 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* Improve configure message for HunspellKai Köhne2022-02-111-1/+1
| | | | | | | | Make it explicit that this is for Qt Virtual Keyboard. Pick-to: 6.3 Change-Id: I78dbd68ed1f12d723704f92da1e0107a115d221b Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
* Remove unused .qrc filesJoerg Bornemann2022-01-184-112/+0
| | | | | | | Task-number: QTBUG-94446 Change-Id: I46bcfdb89dda3c8f28bc25ef1d89413f64b4307b Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>
* Update documentation wrt modality and z orderingVolker Hilsheimer2021-12-201-10/+3
| | | | | | | | | | | | | | | As of 1129af130964c5e0f2db6e8a6fb6dc2fe70f3bc8, the InputPanel uses a containment masks on the overlay popup to keep it enabled even during modal sessions. It no longer reparents itself to the overlay item and doesn't change the z value, so remove that documentation. Add instead that the one, common input panel is bypassing modality, and that it may be obscured by items with a higher z value. Task-number: QTBUG-97439 Pick-to: 6.2 6.3 Change-Id: I493d5446186dae48523f63b29a473ee83daa4ffb Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-06 05:09:44 +0000