aboutsummaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* hunspell: Fix build with bundled hunspellJarkko Koivikko2024-04-161-1/+1
| | | | | | | | hunspell/config.h is generated in the build directory, so fix SOURCES reference. Pick-to: 6.7 6.5 Change-Id: I8847e50d4e7920792d59f829a6cc3fb7eb9bb45c Reviewed-by: Kai Köhne <kai.koehne@qt.io>
* Remove the use of QT_IM_MODULEJiDe Zhang2024-04-101-2/+2
| | | | | | | | | | Sync from QPlatformInputContextFactory::requested in 8596998cb025a8338c9403f5ef9db5a23f5cc682 of qtbase to QPlatformInputContextFactory. Change-Id: I37f9762610f91a93583a67cfade029079bb2a239 Reviewed-by: Johannes Kauffmann <johanneskauffmann@hotmail.com> Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>
* tcime: Add missing symbol ER to Zhuyin layoutJarkko Koivikko2024-04-091-1/+1
| | | | | | | | Pick-to: 6.7 Task-number: QTBUG-80663 Change-Id: I599a634bb507db36b037c89435614f85a3121878 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>
* Correct license for tools fileLucie Gérard2024-04-041-1/+1
| | | | | | | | | | | According to QUIP-18 [1], all tools file should be LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0 [1]: https://contribute.qt-project.org/quips/18 Task-number: QTBUG-121787 Change-Id: Ie7c6aa46e03a92f5e1780ca5c3bc920f912af765 Reviewed-by: Kai Köhne <kai.koehne@qt.io>
* Remove the use of GENERATE_CPP_EXPORTS argumentAlexey Edelev2024-03-262-2/+0
| | | | | | | | | The behavior that argument was enabling is the default one now. Task-number: QTBUG-90492 Change-Id: Id71dfcda1e056604e03fb6e32197733eeaf7b328 Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi> Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
* Use NO_GENERATE_CPP_EXPORTS explicitlyAlexey Edelev2024-03-2517-0/+17
| | | | | | | | | | | Use NO_GENERATE_CPP_EXPORTS explicitly for modules that don't need the autogenerated exports header file. Task-number: QTBUG-90492 Change-Id: Icef7252ed25a562b02c1ec9d78f13ee0934a2068 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io> Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>
* Make hide behavior of qt vkb configurable through its settingsSanthosh Kumar2024-03-127-2/+99
| | | | | | | | | | | | | | | The patch 6da66ff611902d8c4d485568d746f49c69f1330f (introdued in Qt6) changed the behavior to handle the hide through platform plugins. But this cause issue for some users, with the concern that the qt virtual keyboard hides after input accepted in Qt5 and not in Qt6. This patch introduced new virtual keyboard settings property closeOnReturn to control the hiding behavior of virtual keyboard. Task-number: QTBUG-112963 Change-Id: Ia9433a7fe14eb896758e05f0943ad461f2790a98 Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi> Reviewed-by: Santhosh Kumar <santhosh.kumar.selvaraj@qt.io>
* Enable QVirtualKeyboardPlugin on Android platforms by defaultAlexey Edelev2024-02-221-1/+1
| | | | | | | | | | | It does make sense to enable QVirtualKeyboardPlugin on Android platforms by default, since Android devices require virtual keyboard as HMI. Task-number: QTBUG-121658 Pick-to: 6.7 6.6 6.5 Change-Id: Ia876d9435226ed1e74acf785d186da611f135f95 Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>
* Link VKB and VKB.Settings into VKB.Components and VKB into VKB.StylesUlf Hermann2024-02-074-5/+8
| | | | | | | | | | | This forces the build system to build VirtualKeyboard and VirtualKeyboardSettings first which makes their qmltypes available to subsequent build steps. Pick-to: 6.7 6.6 Task-number: QTBUG-121643 Change-Id: Ia0cdfe522d78c94eb87f7fd2cbaf6c2fdac954aa Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* Remove the use of GENERATE_PRIVATE_CPP_EXPORTSAlexey Edelev2024-01-152-2/+0
| | | | | | | Task-number: QTBUG-117983 Change-Id: I76971f6df74a93910ac790e765d7fd82a803e133 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>
* Remove the use of Q_VIRTUALKEYBOARD_PRIVATE_EXPORTAlexey Edelev2024-01-151-2/+2
| | | | | | Task-number: QTBUG-117983 Change-Id: If775ffb2e27ea0ef2ea2d5ebf408a9b0690b7a92 Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>
* Update 3rd party directories to SPDX-License-RefLucie Gérard2024-01-111-28/+2
| | | | | | | Task-number: QTBUG-120262 Pick-to: 6.6 6.7 Change-Id: I3449c3a60664c46a8fd75dc0bba6886d71652abd Reviewed-by: Kai Köhne <kai.koehne@qt.io>
* Pinyin: free _syncs in userdictInho Lee2024-01-081-0/+3
| | | | | | | | There is an unfreed memory block in a 3rdparty module, pinyin. Pick-to: 6.7 6.6 6.5 Change-Id: I652b987437472b6e4f3bcf0e1cf600ba6d78d816 Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>
* Fix VirtualKeyboard attached propertiesJarkko Koivikko2023-11-142-2/+4
| | | | | | | | | | | | | | | VirtualKeyboard attached type was missing QML_NAMED_ELEMENT and QML_UNCREATABLE rendering it useless. Add missing type definitions and also fix the documentation. Add a simple automated test which checks the availability of the existing attached properties. Pick-to: 6.6 Fixes: QTBUG-118565 Change-Id: I9297dfab9b7168e65e35f78738be3fb46b1fe8bc Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* Fix QML revisioningJarkko Koivikko2023-11-0833-3/+44
| | | | | | | | | | | | | | | | | | | | | | | | | This change adds the missing revisioning for various components: - QtQuick.VirtualKeyboard.Plugins 2.0: Must be version 2.0 because it is essential import. - QtQuick.VirtualKeyboard.Styles.Builtin 1.0: Must be version 1.0 since the dependent module QtQuick.VirtualKeyboard.Styles is also 1.0. - QtQuick.VirtualKeyboard 6.4: VirtualKeyboardFeatures namespace and QtVirtualKeyboard namespace were introduced at this version (Port qtvirtualkeyboard to declarative type registration). - QtQuick.VirtualKeyboard 2.0: Added PlainInputMethod element and InputContext.priv property at this revision. - QtQuick.VirtualKeyboard 2.4: Fix revisioning of InputContext.shiftActive and InputContext.capsLockActive properties, which were specified only with minor version 4 that is implicitly coupled to current major version 6. Specify revision 2.4 explicitly. Fixes: QTBUG-116432 Pick-to: 6.6 Change-Id: I8abe5652355a32afbf9659b8dd9e1d1fe0f358db Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi> Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* Modify copyright format in qt_attribution.jsonLucie Gérard2023-10-271-5/+5
| | | | | | | | | Multiline copyright entries are entered via string array. Task-number: QTBUG-111873 Pick-to: 6.5 6.6 Change-Id: I6df1d6d1a2e8870e3e9c71a95080a1d3381cc034 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
* Fix licensing of Qt VirtualKeyboard basic exampleJarkko Koivikko2023-10-232-2/+2
| | | | | | | Fixes: QTBUG-118324 Pick-to: 6.6 Change-Id: I8d0c05acb549f4abed2030ed5fd3fb7f8b1685e1 Reviewed-by: Kai Köhne <kai.koehne@qt.io>
* Include what you need: <QPointer>Marc Mutz2023-10-133-0/+6
| | | | | | | | | | | | | | | | | | | | | | | All these TUs relied on transitive includes of qpointer.h, maybe to a large extent via qevent.h, though, given that qevent.h is more or less the only public QtBase header that includes qpointer.h, something else seems to be at play here. Said qevent.h actually needs QPointer in-name-only, so a forward declaration would suffice. Prepare for qevent.h dropping the include. The algorithm I used was: If the TU mentions 'passiveGrabbers', the name of the QEvent function that returns QPointers, and the TU doesn't have qpointer.h included explicitly, include it. That may produce False Positives, but better safe than sorry. Otherwise, in src/, add an include to all source and header files which mention QPointer. Exception: if foo.h of a foo.cpp already includes it, don't include again. Task-number: QTBUG-117670 Change-Id: I7fe6750395c64a327252321431d8e7b371f066e5 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* Doc: Mark example as highlighted (again)Kai Köhne2023-10-041-1/+1
| | | | | | | | | This broke with commit 46f44cb428e969e Pick-to: 6.5 6.6 6.6.0 Task-number: QTBUG-117210 Change-Id: I5447e1b753176881d3582d2ccbf6abd107b36601 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* plugins/myscript: Fix build (remove missing plugin sources)Jarkko Koivikko2023-09-131-1/+0
| | | | | | | | | | Plugin sources are automatically generated. These were left in place in the myscript plugin by accident. Pick-to: 6.5 6.6 6.6.0 Change-Id: Ie2f486bcc4eaa3fc088ce0955de424803eaa86b3 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Yuntaek Rim <yuntaek.rim@myscript.com>
* Fix navigation key left/right handling with LayoutMirroring.enabledJarkko Koivikko2023-09-131-10/+7
| | | | | | | | | | When LayoutMirroring.enabled is true, right navigation key should wrap to line above and left navigation key should wrap to line below. Pick-to: 6.5 6.6 Change-Id: Iec7c4cd4372ba5a511acb30e04b46c5dcc56d149 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* Optimize inputpanel test execution timeJarkko Koivikko2023-09-132-14/+19
| | | | | | | | | | | | | | | | | | | | | | | | This change is based on several optimizations which together reduce the execution time of inputpanel test by roughly 80%. - Avoid Utils.findChild* functions when it is possible to use alias. - Introduce Keyboard.noAnimations property, which disables all internal animations in the keyboard. - Remove most of the waitForRendering calls which are useless. Add explicit wait() where it is absolutely necessary. - Reduce pressAndHoldDelay for alternative keys to avoid unnecessary waiting. - Avoid handwriting tests; utilize the handwriting feature flag for speed. It's a build-time constant, preventing unnecessary locale layout loading when no handwriting layout exists. - Finally, a minor optimization for the for loops in the Utils.findChild functions. Use "for of" instead of "for index", because it is much faster. Pick-to: 6.5 6.6 Change-Id: I2e3b9169eb8ab082f5b842909f91621643ba2803 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* Doc: Update reference to 'Pure QML' exampleTopi Reinio2023-09-062-3/+7
| | | | | | | | | | | | | | | The 'Pure QML' example compositor in Qt Wayland has been renamed to 'Fancy Compositor'. Split the long snippet code line for starting the compositor for better readability. Mark the module clear of documentation warnings. Pick-to: 6.6 Change-Id: I6e07fa2f7a54820613760e98dd501821e0afb3b5 Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi> Reviewed-by: Andreas Eliasson <andreas.eliasson@qt.io>
* Disable desktop input panel on AndroidJarkko Koivikko2023-09-061-1/+1
| | | | | | | Fixes: QTBUG-108030 Pick-to: 6.5 6.6 Change-Id: Ic8fd9ea87723c58672489c9422d2e6a446a9181c Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
* Fix binding loop warning emitted by inputpanel testJarkko Koivikko2023-09-051-1/+10
| | | | | | | | | | | | | | | | | | | | | | | zh_TW has only two supported input modes Zhuyin and Cangjie. At the time locale is set to zh_TW and the main layout is loaded, inputMode is not yet set to Zhuyin or Cangjie, because the input method is created by the layout and the default input mode is defined by the input method. The binding loop happens, because in the test case the inputMode is Latin during creation: create: inputMode === Latin -> Cangjie default: inputMode === Zhuyin -> Zhuyin test: inputMode === Cangjie -> Cangjie Fix by setting sourceComponent to null if the inputMode is not yet set to supported input mode. Pick-to: 6.5 6.6 Change-Id: I1c9bcccc5655e3ec1553e6e5414b47733eba5b82 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* Work around QML creating separate singletons for each versionUlf Hermann2023-08-304-4/+45
| | | | | | | | | | | | | We define our own create() method and make sure to only create one singleton per engine, no matter the version. Since we cannot do this in the public header for QVirtualKeyboardInput, we create a QML registration shim for it in a private header. Pick-to: 6.6 6.5 Task-number: QTBUG-116432 Change-Id: I53391a92daf0777952401453038d2d523b86b4ef Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* Doc: Add \examplecategory to qtvirtualkeyboardSafiyyah Moosa2023-08-291-0/+1
| | | | | | | Task-number: QTBUG-116332 Pick-to: 6.5 6.6 Change-Id: Ic31ba41f6c63fd59acc9199064d18849565b99ad Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
* Add QT_NO_CONTEXTLESS_CONNECT to the default build flagsAhmad Samir2023-08-221-4/+4
| | | | | | | | | | | | This disables the 3-arg QObject::connect() overload: QObject::connect(sender, signal, functor) For details see: https://lists.qt-project.org/pipermail/development/2023-July/044141.html Change-Id: Idf6e8a3abfb66363adaa1de817eb8feaef2d3b37 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>
* Restore style path for backwards compatibilityJarkko Koivikko2023-08-221-0/+3
| | | | | | | | | | | | | This was broken since commit 4395ca0fdd04d4e8655f2c8765ff229e236bfdc2 [ChangeLog] Restored style path /QtQuick/VirtualKeyboard/content/styles for backwards compatibility. Fixes: QTBUG-116078 Pick-to: 6.5 6.6 Change-Id: Iadef58af5bea2dd5849f2a15500eac8a40c38eee Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* Doc: List of all Qt overviews which are now termed as explanationJaishree Vyas2023-07-241-1/+1
| | | | | | | | | | | | The autogenerated list of overviews was adding the \group command which included all the groups instead of overviews. The idea here is to categorize the overviews later on once we have the list of all overviews. Task-number: QTBUG-114762 Pick-to: 6.5 6.6 Change-Id: I3f6f0d88b5d21ac128c74d56c136c0d00368626c Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Doc: Remove warninglimit .qdocconf variableTopi Reinio2023-06-271-3/+0
| | | | | | | | | | | | | | | | The most common limit for the maximum number of allowed documentation warnings is zero. As all Qt module docs include() a common configuration from qtbase, it's better to control the base warninglimit from a central location in qtbase/doc/global. This allows for a temporary increase of the limit across all modules as needed - for example, when updating the QDoc binary that the CI provisions to a version that introduces new types of documentation warnings. Task-number: QTBUG-113326 Change-Id: I53d84dca3d82469b4401ffa463bddd29bdf8afe6 Reviewed-by: Paul Wicking <paul.wicking@qt.io>
* Remove repetitive names from KeyboardFunctionKeys enum valuesJarkko Koivikko2023-06-267-18/+18
| | | | | | | | This change was made based on feedback on Qt 6.6 api review. Pick-to: 6.6 Change-Id: I13ea8314708a97258dcef1c17961022e1f422025 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* Fix Settings icon visible in the comma key when Settings not availableJarkko Koivikko2023-06-211-1/+1
| | | | | | | | | This change fixes regression introduced in the commit 8ceee9b6af24911eac7b7f9862a293133f953b1a Pick-to: 6.6 Change-Id: I059215e767e5ada809feed09f9089e8485a7528c Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* Use scoped values in QML for enum classesJarkko Koivikko2023-06-2121-45/+45
| | | | | | | | | | | | | This change was made based on feedback on Qt 6.6 api review. Update all the remaining instances of unscoped enum class usage in QML to use scoped values. Remove test for unscoped enums. Pick-to: 6.6 Change-Id: I8c1147001d41666cbf6fab967ada8981065c28fe Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* Make qvirtualkeyboardnamespace.h privateJarkko Koivikko2023-06-206-9/+20
| | | | | | | | | | | | | | | This change was made based on feedback on Qt 6.6 api review. Since the qvirtualkeyboardnamespace.h is currently used as private API, it makes no sense to keep it public. [ChangeLog][Potentially Source-Incompatible Changes][VirtualKeyboard] The qvirtualkeyboardnamespace.h header has been made private. None of the enum types declared in that header are used in public C++ APIs. Pick-to: 6.6 Change-Id: I889bf71bb36d00140dcffad7e672452c93eaaa98 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* Use unsigned type for enum KeyboardFunctionKeyJarkko Koivikko2023-06-165-10/+12
| | | | | | | | | | | | | | | These changes were made based on feedback on Qt 6.6 api review. - Use unsigned type for enum KeyboardFunctionKey (avoid QTBUG-113792) - Use 0xffffffff as the value of AllFunctionKeys to enable BC - Use scoped name for QtVirtualKeyboard.KeyboardFunctionKeys values This change amends commits 4ef502b77eedf1ec1683535143c01c43f4abfaf2 and 71daa433bf630af56998d6d5a524c23bb4fd8b17. Pick-to: 6.6 Change-Id: I4fe33bbff07505280ba5e937fccf38d3ebbb7b6e Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* Doc: Add a DocBook version of custom svg imagesLuca Di Sera2023-06-141-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | QDoc provides a "\raw" command that allows a user to inject format-specific code that complements the code that QDoc generates. The "\raw" command expect the user to provide a "format" argument to ensure that the provided code is generated only for the format that is written for. Due to a bug in QDoc DocBook generation, the DocBook documentation was generating, sometimes incorrectly, "\raw" commands intended for the HTML format. The Qt virtual keyboard documentation uses the "\raw HTML" commands to provide some custom SVGs. Due to the aforementioned bug, QDoc was generating some equivalent code for DocBook, albeit no user-provided DocBook equivalent existed. As the bug is now being fixed, the DocBook documentation for virtual keyboard will lose the custom SVGs in its output. To preserve the SVGs for when generating DocBook documentation, an equivalent "\raw DocBook" command is now provided. Change-Id: I272163cd88b133e07fb790293baa9d4833429087 Reviewed-by: Topi Reiniö <topi.reinio@qt.io> Reviewed-by: Paul Wicking <paul.wicking@qt.io>
* Doc: Fix links to Supported Languages sectionVolker Hilsheimer2023-06-111-2/+2
| | | | | | Pick-to: 6.6 Change-Id: Ic31e435a9a46821330f0d18fac3780aa20ccfae5 Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>
* Fix position of function popup listJarkko Koivikko2023-06-091-1/+1
| | | | | | | | | | | For some reason origin is not set correctly if currentIndex is set after. Perhaps ListView.width versus ListView.currentIndex behavior has changed. Anyway, set the currentIndex first and then create binding for the origin. This seems to fix the issue. Pick-to: 6.6 Change-Id: I78f3ff2b89b4ed1bb88e7556a20935748664a01b Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* Rename KeyboardFunctionKeyFlag and KeyboardFunctionKeyJarkko Koivikko2023-06-097-23/+23
| | | | | | | | | | | | | | | | | | These changes were made based on feedback on Qt 6.6 api review. - Rename QFlags class KeyboardFunctionKey to KeyboardFunctionKeys - Rename enum class KeyboardFunctionKeyFlag to KeyboardFunctionKey - Rename enum value QtVirtualKeyboard.NoFunctionKey to NoFunctionKeys Also: - don't pass QFlags by cref, pass them by value - change include order. This change amends commit 4ef502b77eedf1ec1683535143c01c43f4abfaf2 Pick-to: 6.6 Change-Id: I80736365b2fc5db53ae71b1b5e0ae141e9c804f5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* Doc: Remove incorrect module identifiers in \qmlproperty commandsTopi Reinio2023-06-081-3/+2
| | | | | | | | | | | | | With upcoming changes to QDoc these will start to generate documentation warnings. Remove them as QDoc is capable of resolving the parent QML type without the identifier. Also, drop the \qmlpropertygroup command as that's no longer required and is ignored by QDoc. Pick-to: 6.6 6.5 Change-Id: I4803fcdf039c89a5de6e931ad571369541612872 Reviewed-by: Andreas Eliasson <andreas.eliasson@qt.io>
* Fix VirtualKeyboardSettings.fullScreenMode bindingJarkko Koivikko2023-05-121-0/+13
| | | | | | | | | | | | | | The VirtualKeyboardSettings.fullScreenMode behavior was broken in commit e9c701803d because the change did not apply initial value. Fix the issue by initializing the shadow input control at component completed handler. Also, clear the contents of shadow input control when shadow input is not active. Add new test case to verify. Fixes: QTBUG-113168 Pick-to: 6.5 Change-Id: I3bbe44229bcae7e85ae253dbcd30d500326bc4da Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* Restore language and hide buttons to handwriting layoutJarkko Koivikko2023-05-0930-983/+685
| | | | | | | Fixes: QTBUG-113024 Change-Id: I5eb776e8a31d14060970404d9bf3be7421dce784 Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* Add example handwriting pluginJarkko Koivikko2023-05-0910-4/+1015
| | | | | | | | | | | | | | This can be used for demonstration and development purposes. The plugin is enabled by defining -DINPUT_vkb_handwriting:STRING=example-hwr In the cmake command line. Task-number: QTBUG-113024 Change-Id: I05fd8dab88ea4f0d040c39836f55dcd52bc3e332 Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>
* Ensure that the language popup is within keyboard boundsJarkko Koivikko2023-05-091-1/+4
| | | | | | | | | | | | | | | | Currently the language popup is always located correctly, because it is opened from a keyboard key located away from the edges. However, if the key is at the edge, the language popup clips with keyboard boundaries. This change adjusts the offset so that the popup is within keyboard area. Task-number: QTBUG-113024 Change-Id: I9c58658130e1c8806827b765c8be4ba364962318 Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* Restore language and hide function keysJarkko Koivikko2023-05-0976-134/+908
| | | | | | | | | | | | | | | | | | | | | | | | | Commit adeb526a39433943f2843c0fd0276de428bc6ea2 was a major update to all existing layouts with a goal to modernize the look and make the layouts symmetrical in appearance. The change also organized some of the functionality and combined the functionality of language switch, hide keyboard and handwriting mode switch keys to new gear popup menu accessible by long press comma key. However, there has been complaints that this solution is not very user friendly. This change brings back the language and hide keys. It will also make them configurable through VirtualKeyboardSettings.visibleFunctionKeys property, which allows to hide them for more compact look. Some special layouts, such as digits input will always have the keys visible regardless of the setting, because the particular layouts depend on their visibility. Therefore, the visibility is always true. Fixes: QTBUG-112964 Change-Id: Ic5db14cf8b523ff71a783172b3cb301caa05daab Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* VirtualKeyboard.Settings: ensure availability of valid engine pointerFabian Kosmale2023-03-282-13/+18
| | | | | | | | | | | | | | qmlEngine/qmlContext doesn't work on a singleton while the engine is in the process of constructing it. Use the create factory function instead of a default ctor to ensure that we get a valid engine pointer. Fixes: QTBUG-108536 Fixes: QTBUG-111154 Pick-to: 6.5 Change-Id: Ic77fa013e634b44c9d11a43ef67ea57ed85ffb5c Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>
* Fix DesktopInputSelectionControlJarkko Koivikko2023-03-244-4/+19
| | | | | | | | | | | Previously, the desktop selection handles were not functioning correctly. They were displayed at the wrong location and were not always appearing when needed. This issue has been resolved, ensuring the selection handles are now working as intended. Pick-to: 6.5 Change-Id: Ic546361285a88c06bf3d28cd545c2bda17ddadac Reviewed-by: Inho Lee <inho.lee@qt.io>
* Fix collapsed keyboard layout caused by zero width input panelJarkko Koivikko2023-03-201-5/+11
| | | | | | | | | | | | | | | | | | | This patch fixes the problem by delaying the loading of the layout until the keyboard width is valid. An additional updateInputMethod call is necessary, as the input method is dependent on the keyboard layout. However, this should only be called if the inputMethod is not set. This can occur with DesktopInputPanel. Furthermore, the restoreMode has been removed from the keyboard layout binding, as the keyboard layout should not be reset. Pick-to: 6.5 Fixes: QTBUG-111928 Change-Id: I94aae3dc978e3c0445edd2d55fcae233a43d581a Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Inho Lee <inho.lee@qt.io>
* Remove alternative latin layouts from some non-latin localesIvan Tkachenko2023-03-022-737/+323
| | | | | | | | | | | | | | | | | | | | | | Effectively reverts QTBUG-67756 and 4a424bd5df903caae1d36dafe05be5ee4fc224b9 As a native speaker of russian language, I testify that having such alternative layout on a ru_RU locale is inappropriate for two simple reasons: - No one does that, except Qt. If you need one, just switch to en_US. - qwertZ german-style layout is alien to most russians. And as a [[part-time]] native ukrainian, I take responsibility for modifications to uk_UA locale too. Whatever the original problem was, which led to that suggestion and subsequently an implementation, I'm sure there are better ways to handle it. And it better be handled uniformly instead of copying same latinLayout component code into every other non-latin locale. Change-Id: I478fdedbac291599632bd5601a73171558d712e8 Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>