Init variables where they are declared when possible (clang-tidy)

clang-tidy -p compile_commands.json $file \
    -checks='-*,modernize-use-default-member-init,readability-redundant-member-init' \
    -config='{CheckOptions: [{key: modernize-use-default-member-init.UseAssignment, value: "1"}]}' \
    -header-filter='qtwayland' \
    -fix

Afterwards I ran search and replace on the diff to clean up some whitespace errors:

- Replaced '(\n\+[^:\n]*)(:\s+\+\s+)' with '$1: '
- Replaced '(\n\+[^,\n]*)(,\s+\+\s+)' with '$1, '
- Replaced '\n\+\s*\n' with '\n'

I also had to do some manual edits, because for some reason, this particular
clang-tidy check doesn't trigger for some files.

Change-Id: I3b3909bac4bf20108bbe8ad1e01bcc54236dae1b
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>

1 files changed, 5 insertions, 9 deletions

diff --git a/src/client/qwaylandabstractdecoration.cpp b/src/client/qwaylandabstractdecoration.cpp
index 6a7a2ef4c..c20b70e9e 100644
--- a/src/client/qwaylandabstractdecoration.cpp
+++ b/src/client/qwaylandabstractdecoration.cpp
@@ -60,21 +60,17 @@ public:
     QWaylandAbstractDecorationPrivate();
     ~QWaylandAbstractDecorationPrivate();
 
-    QWindow *m_window;
-    QWaylandWindow *m_wayland_window;
+    QWindow *m_window = nullptr;
+    QWaylandWindow *m_wayland_window = nullptr;
 
-    bool m_isDirty;
+    bool m_isDirty = true;
     QImage m_decorationContentImage;
 
-    Qt::MouseButtons m_mouseButtons;
+    Qt::MouseButtons m_mouseButtons = Qt::NoButton;
 };
 
 QWaylandAbstractDecorationPrivate::QWaylandAbstractDecorationPrivate()
-    : m_window(nullptr)
-    , m_wayland_window(nullptr)
-    , m_isDirty(true)
-    , m_decorationContentImage(nullptr)
-    , m_mouseButtons(Qt::NoButton)
+    : m_decorationContentImage(nullptr)
 {
 }