Init variables where they are declared when possible (clang-tidy)

clang-tidy -p compile_commands.json $file \
    -checks='-*,modernize-use-default-member-init,readability-redundant-member-init' \
    -config='{CheckOptions: [{key: modernize-use-default-member-init.UseAssignment, value: "1"}]}' \
    -header-filter='qtwayland' \
    -fix

Afterwards I ran search and replace on the diff to clean up some whitespace errors:

- Replaced '(\n\+[^:\n]*)(:\s+\+\s+)' with '$1: '
- Replaced '(\n\+[^,\n]*)(,\s+\+\s+)' with '$1, '
- Replaced '\n\+\s*\n' with '\n'

I also had to do some manual edits, because for some reason, this particular
clang-tidy check doesn't trigger for some files.

Change-Id: I3b3909bac4bf20108bbe8ad1e01bcc54236dae1b
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>

1 files changed, 5 insertions, 5 deletions

diff --git a/src/client/qwaylandinputcontext_p.h b/src/client/qwaylandinputcontext_p.h
index a131bc5bd..a554f2301 100644
--- a/src/client/qwaylandinputcontext_p.h
+++ b/src/client/qwaylandinputcontext_p.h
@@ -112,17 +112,17 @@ private:
 
     QVector<Qt::KeyboardModifier> m_modifiersMap;
 
-    uint32_t m_serial;
-    struct ::wl_surface *m_surface;
+    uint32_t m_serial = 0;
+    struct ::wl_surface *m_surface = nullptr;
 
     QString m_preeditCommit;
 
-    bool m_inputPanelVisible;
+    bool m_inputPanelVisible = false;
     QRectF m_keyboardRectangle;
     QLocale m_locale;
-    Qt::LayoutDirection m_inputDirection;
+    Qt::LayoutDirection m_inputDirection = Qt::LayoutDirectionAuto;
 
-    struct ::wl_callback *m_resetCallback;
+    struct ::wl_callback *m_resetCallback = nullptr;
     static const wl_callback_listener callbackListener;
     static void resetCallback(void *data, struct wl_callback *wl_callback, uint32_t time);
 };