Init variables where they are declared when possible (clang-tidy)

clang-tidy -p compile_commands.json $file \
    -checks='-*,modernize-use-default-member-init,readability-redundant-member-init' \
    -config='{CheckOptions: [{key: modernize-use-default-member-init.UseAssignment, value: "1"}]}' \
    -header-filter='qtwayland' \
    -fix

Afterwards I ran search and replace on the diff to clean up some whitespace errors:

- Replaced '(\n\+[^:\n]*)(:\s+\+\s+)' with '$1: '
- Replaced '(\n\+[^,\n]*)(,\s+\+\s+)' with '$1, '
- Replaced '\n\+\s*\n' with '\n'

I also had to do some manual edits, because for some reason, this particular
clang-tidy check doesn't trigger for some files.

Change-Id: I3b3909bac4bf20108bbe8ad1e01bcc54236dae1b
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>

1 files changed, 1 insertions, 11 deletions

diff --git a/src/compositor/wayland_wrapper/qwldatadevice.cpp b/src/compositor/wayland_wrapper/qwldatadevice.cpp
index 3b557a109..6dc1355d5 100644
--- a/src/compositor/wayland_wrapper/qwldatadevice.cpp
+++ b/src/compositor/wayland_wrapper/qwldatadevice.cpp
@@ -61,18 +61,8 @@ QT_BEGIN_NAMESPACE
 namespace QtWayland {
 
 DataDevice::DataDevice(QWaylandSeat *seat)
-    : wl_data_device()
-    , m_compositor(seat->compositor())
+    : m_compositor(seat->compositor())
     , m_seat(seat)
-    , m_selectionSource(nullptr)
-#if QT_CONFIG(draganddrop)
-    , m_dragClient(nullptr)
-    , m_dragDataSource(nullptr)
-    , m_dragFocus(nullptr)
-    , m_dragFocusResource(nullptr)
-    , m_dragIcon(nullptr)
-    , m_dragOrigin(nullptr)
-#endif
 {
 }