1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
|
# Copyright 2015 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import sys
def _RunArgs(args, input_api):
p = input_api.subprocess.Popen(args, stdout=input_api.subprocess.PIPE,
stderr=input_api.subprocess.STDOUT)
out, _ = p.communicate()
return (out, p.returncode)
def _CheckRegisteredMetrics(input_api, output_api):
""" Check that all tracing metrics are imported in all_metrics.html """
results = []
tracing_dir = input_api.PresubmitLocalPath()
out, return_code = _RunArgs(
[input_api.python_executable,
input_api.os_path.join(tracing_dir, 'bin', 'validate_all_metrics')],
input_api)
if return_code:
results.append(output_api.PresubmitError(
'Failed validate_all_metrics: ', long_text=out))
return results
def _CheckRegisteredDiagnostics(input_api, output_api):
"""Check that all Diagnostic subclasses are registered."""
results = []
tracing_dir = input_api.PresubmitLocalPath()
out, return_code = _RunArgs(
[input_api.python_executable,
input_api.os_path.join(tracing_dir, 'bin', 'validate_all_diagnostics')],
input_api)
if return_code:
results.append(output_api.PresubmitError(
'Failed validate_all_diagnostics: ', long_text=out))
return results
def _WarnOnReservedInfosChanges(input_api, output_api):
source_file_filter = lambda x: input_api.FilterSourceFile(
x, files_to_check=[r'.*reserved_infos\.(py|cc)$'])
count = len(input_api.AffectedSourceFiles(source_file_filter))
results = []
if count == 1:
results.append(output_api.PresubmitPromptWarning(
'Looks like you are modifying one of reserved_infos.py and\n'
'reserved_infos.cc. Please make sure the values in both files\n'
'are in sync.'))
return results
def _CheckHistogramProtoIsGated(input_api, output_api):
source_file_filter = lambda x: input_api.FilterSourceFile(
x, files_to_check=[r'.*\.py$'], block_list=['.*PRESUBMIT.py$'])
files = []
for f in input_api.AffectedSourceFiles(source_file_filter):
contents = input_api.ReadFile(f)
if ('histogram_pb2' in contents and
not f.LocalPath().endswith('histogram_proto.py')):
files.append(f)
results = []
if files:
results.append(output_api.PresubmitError(
'Only histogram_proto.py should reference histogram_pb2.\n'
'This file is not available in many places where the tracing\n'
'python code is used, so it needs to be gated properly.', files))
return results
def _CheckProtoNamespace(input_api, output_api):
source_file_filter = lambda x: input_api.FilterSourceFile(
x, files_to_check=[r'.*\.(cc|h)$'])
files = []
for f in input_api.AffectedSourceFiles(source_file_filter):
contents = input_api.ReadFile(f)
if 'protobuf::' in contents:
files.append(f)
if files:
return [output_api.PresubmitError(
'Do not use the google::protobuf namespace. Use auto for '
'google::protobuf::Map or other proto types you need.\n'
'google::protobuf is currently not compatible with downstream '
'proto libraries.',
files)]
return []
def CheckChangeOnUpload(input_api, output_api):
return _CheckChange(input_api, output_api)
def CheckChangeOnCommit(input_api, output_api):
return _CheckChange(input_api, output_api)
def _CheckChange(input_api, output_api):
results = []
original_sys_path = sys.path
try:
sys.path += [input_api.PresubmitLocalPath()]
from tracing_build import check_gni
error = check_gni.GniCheck()
if error:
results.append(output_api.PresubmitError(error))
finally:
sys.path = original_sys_path
files_to_skip = input_api.DEFAULT_FILES_TO_SKIP + (".*_pb2.py$",)
results += input_api.RunTests(input_api.canned_checks.GetPylint(
input_api, output_api, extra_paths_list=_GetPathsToPrepend(input_api),
pylintrc='../pylintrc', files_to_skip=files_to_skip))
results += _CheckRegisteredMetrics(input_api, output_api)
results += _CheckRegisteredDiagnostics(input_api, output_api)
results += _WarnOnReservedInfosChanges(input_api, output_api)
results += _CheckProtoNamespace(input_api, output_api)
results += _CheckHistogramProtoIsGated(input_api, output_api)
return results
def _GetPathsToPrepend(input_api):
import tracing_project
project_dir = input_api.PresubmitLocalPath()
catapult_dir = input_api.os_path.join(project_dir, '..')
return [
project_dir,
input_api.os_path.join(catapult_dir, 'third_party', 'mock'),
] + tracing_project.GetDependencyPaths()
|
