summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichal Klocek <michal.klocek@qt.io>2024-02-02 18:21:05 +0100
committerMichael BrĂ¼ning <michael.bruning@qt.io>2024-04-09 20:13:27 +0200
commitabf4c440191fc78f17222ad9bf1226b2d0d63d1e (patch)
tree81949c5e46b4dffdb5b80b0b691b585793163b08
parent7f888fd919ce21a5ff2b26d9287d9eb2c30e1763 (diff)
Use only 'pdbpagesize' linker option for webenginecore debug
Using 'pdbpagesize' allows to create larger pdbfiles and it is needed for debug builds for qwebenginecore as it gets over 4Gb. However, these files are not yet well supported by older tooling therefore use the setting only for webengine debug build. This allows qtpdf debug builds and webenginecore/qtpdf release with debug info have functional pdb files with older tooling like cdb on windows. Task-number: QTCREATORBUG-30308 Change-Id: Icd79a0d36b2f4b7f767d17ed79de3a4cbf96f1b4 Reviewed-by: Michael BrĂ¼ning <michael.bruning@qt.io> (cherry picked from commit 2af8c8c0b35bd37ba8df591d928720d2b894e816) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 0d1439fdf9b3b437f7bbf0876c92a3b2212175c1) (cherry picked from commit 90db5b974201b9061ec2238f9c4e89698150d118) Reviewed-by: Michal Klocek <michal.klocek@qt.io>
-rw-r--r--cmake/Functions.cmake6
1 files changed, 4 insertions, 2 deletions
diff --git a/cmake/Functions.cmake b/cmake/Functions.cmake
index 95b252277..40554ad6b 100644
--- a/cmake/Functions.cmake
+++ b/cmake/Functions.cmake
@@ -458,8 +458,10 @@ function(add_linker_options target buildDir completeStatic)
target_link_options(${cmakeTarget}
PRIVATE /DELAYLOAD:mf.dll /DELAYLOAD:mfplat.dll /DELAYLOAD:mfreadwrite.dll /DELAYLOAD:winmm.dll
)
- # enable larger PDBs
- target_link_options(${cmakeTarget} PRIVATE "/pdbpagesize:8192")
+ # enable larger PDBs if webenginecore debug build
+ if(cmakeTarget STREQUAL "WebEngineCore")
+ target_link_options(${cmakeTarget} PRIVATE "$<$<CONFIG:Debug>:/pdbpagesize:8192>")
+ endif()
endif()
target_link_options(${cmakeTarget} PRIVATE "$<$<CONFIG:${config}>:@${objects_rsp}>")
if(NOT completeStatic)