diff options
| author | Michael Brüning <michael.bruning@qt.io> | 2023-08-14 18:06:21 +0200 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2023-08-18 17:51:27 +0000 |
| commit | 7ad43ca5eb51e56d79201b2af323a506f8a0c113 (patch) | |
| tree | c76abff51170dc0ebeff721768e8c28a700d423b | |
| parent | d302a9e6202567a97036265d28e5111eb755aebb (diff) | |
Replace string literals with already defined constants
CodeChecker gave us a friendly hint that our defined constants were not
used as they were intended to be.
Change-Id: I4d7ae374222000f97f4c4869c9d1e7f357e1cd5f
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
(cherry picked from commit d65add56d146211c5ce53ab1e2fbdd8058f020d5)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
| -rw-r--r-- | src/core/version_ui_qt.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/core/version_ui_qt.cpp b/src/core/version_ui_qt.cpp index 252394e2b..0208299eb 100644 --- a/src/core/version_ui_qt.cpp +++ b/src/core/version_ui_qt.cpp @@ -17,7 +17,7 @@ const char kQtWebEngineChromiumSecurityPatchVersion[] = "qtwebengine_chromium_security_patch_version"; const char kCommandLine[] = "command_line"; const char kQtVersionCSS[] = "qt_version.css"; -const char kQtLogo[] = "images/qtlogo.png"; +const char kQtLogo[] = "images/qt.png"; const char kQtWebEngineLogo[] = "images/qtwebengine.png"; } @@ -32,8 +32,8 @@ VersionUIQt::VersionUIQt(content::WebUI *web_ui) : content::WebUIController(web_ "script-src chrome://resources 'self' 'unsafe-inline';"); html_source->SetDefaultResource(IDR_VERSION_UI_QT_HTML); html_source->AddResourcePath(kQtVersionCSS, IDR_VERSION_UI_QT_CSS); - html_source->AddResourcePath("images/qt.png", IDR_QT_LOGO); - html_source->AddResourcePath("images/qtwebengine.png", IDR_QTWEBENGINE_LOGO); + html_source->AddResourcePath(kQtLogo, IDR_QT_LOGO); + html_source->AddResourcePath(kQtWebEngineLogo, IDR_QTWEBENGINE_LOGO); html_source->AddString(kQtWebEngineVersion, qWebEngineVersion()); html_source->AddString(kQtWebEngineChromiumVersion, qWebEngineChromiumVersion()); |